From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0DEF229A2 for ; Mon, 7 Jul 2025 08:29:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751876968; cv=none; b=QcK/s/w5y/FIiLeOT40vNIGnbccgoeJuXchuZrkm0j0GiTlx/N0u0Pbrmtr/FrfZZce+CVD6Sy7GM97Z519KCmp+TRUgpNBNiMbokXOwWhxQtZHL6cs1T7GBdqaw6437FithMj03IRs7wfZ2vDUuLT6KpmQJB54gd0GazTJGBwI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751876968; c=relaxed/simple; bh=m3tTiQMcfBAfQyX11t85i93eQCMelvm/YOEBukz2Nis=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=JFTGcr4DgVyJkVrqGtv6jIddhYZ5su7IH4LfPtGei4TRqCxAe/me2EBW6U+CDVLmOWKb6/R/1EgCkQnwL0QU3kFIuKnDt9esFh9j5ERSTjVunto8W8s9LlbQ0FB2tJ/5SKVR3NjIijfDcXzGTrTz8qTek9LtKcItrzM+OUe0r6k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=AcfpN0/6; arc=none smtp.client-ip=198.175.65.18 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="AcfpN0/6" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1751876967; x=1783412967; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=m3tTiQMcfBAfQyX11t85i93eQCMelvm/YOEBukz2Nis=; b=AcfpN0/6lkU9DvOv23z1EFNMyY/Ygbdn5Rw/tQoU+bxNICPeDhe4Y0Kw 6JiuFBKj2uEDJz2Wu79HYhv0XH0bHgkEj7qV6R/Boa25jQhi7OwGOtTKW iE+pJR+mxelEN894pq3qKkvO/eyTdthtN0U9CHL/1bmiRvwa8f+t0QtGO SgCYDLlNzPn56hiOEOczLl5Orphq0x6sG7xH2t2rIkolPTLt0n1QVaf7p 5lNCOZyNmmc6mSdPsur6lJ0gIF1ii4NTvOqE1tYFANhW8vRp/mNd65+D1 AuFhZlnpmE8Qf9spHlwYghXsjOVGZjqdzVB2lPyICm60oLxhnpLDa/2Gl w==; X-CSE-ConnectionGUID: jkyNbQ7NRVukOhShcXZBaQ== X-CSE-MsgGUID: 7BM6f16YRqOiSupHYNQFcA== X-IronPort-AV: E=McAfee;i="6800,10657,11486"; a="54210134" X-IronPort-AV: E=Sophos;i="6.16,293,1744095600"; d="scan'208";a="54210134" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jul 2025 01:29:27 -0700 X-CSE-ConnectionGUID: aOBhQV9bS82IavxWJk+idQ== X-CSE-MsgGUID: Jg+4ERqdRgSApF2KuIeUlg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,293,1744095600"; d="scan'208";a="154895044" Received: from unknown (HELO [10.245.253.148]) ([10.245.253.148]) by orviesa009-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jul 2025 01:29:24 -0700 Message-ID: <0219dd95-8847-49d3-9e7b-8e793fe1eeaf@linux.intel.com> Date: Mon, 7 Jul 2025 10:29:23 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 01/80] accel/ivpu: Remove redundant pm_runtime_mark_last_busy() calls To: Sakari Ailus , Maciej Falkowski , Oded Gabbay Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20250704075225.3212486-1-sakari.ailus@linux.intel.com> <20250704075356.3216699-1-sakari.ailus@linux.intel.com> Content-Language: en-US From: Jacek Lawrynowicz Organization: Intel Technology Poland sp. z o.o. - ul. Slowackiego 173, 80-298 Gdansk - KRS 101882 - NIP 957-07-52-316 In-Reply-To: <20250704075356.3216699-1-sakari.ailus@linux.intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Reviewed-by: Jacek Lawrynowicz On 7/4/2025 9:53 AM, Sakari Ailus wrote: > pm_runtime_put_autosuspend(), pm_runtime_put_sync_autosuspend(), > pm_runtime_autosuspend() and pm_request_autosuspend() now include a call > to pm_runtime_mark_last_busy(). Remove the now-reduntant explicit call to > pm_runtime_mark_last_busy(). > > Signed-off-by: Sakari Ailus > --- > The cover letter of the set can be found here > . > > In brief, this patch depends on PM runtime patches adding marking the last > busy timestamp in autosuspend related functions. The patches are here, on > rc2: > > git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git \ > pm-runtime-6.17-rc1 > > drivers/accel/ivpu/ivpu_job.c | 1 - > drivers/accel/ivpu/ivpu_pm.c | 2 -- > 2 files changed, 3 deletions(-) > > diff --git a/drivers/accel/ivpu/ivpu_job.c b/drivers/accel/ivpu/ivpu_job.c > index 060f1fc031d3..05a1a768e1c9 100644 > --- a/drivers/accel/ivpu/ivpu_job.c > +++ b/drivers/accel/ivpu/ivpu_job.c > @@ -1049,6 +1049,5 @@ void ivpu_context_abort_work_fn(struct work_struct *work) > mutex_unlock(&vdev->submitted_jobs_lock); > > runtime_put: > - pm_runtime_mark_last_busy(vdev->drm.dev); > pm_runtime_put_autosuspend(vdev->drm.dev); > } > diff --git a/drivers/accel/ivpu/ivpu_pm.c b/drivers/accel/ivpu/ivpu_pm.c > index eacda1dbe840..761b4d7e1a5a 100644 > --- a/drivers/accel/ivpu/ivpu_pm.c > +++ b/drivers/accel/ivpu/ivpu_pm.c > @@ -359,7 +359,6 @@ int ivpu_rpm_get(struct ivpu_device *vdev) > > void ivpu_rpm_put(struct ivpu_device *vdev) > { > - pm_runtime_mark_last_busy(vdev->drm.dev); > pm_runtime_put_autosuspend(vdev->drm.dev); > } > > @@ -428,7 +427,6 @@ void ivpu_pm_enable(struct ivpu_device *vdev) > struct device *dev = vdev->drm.dev; > > pm_runtime_allow(dev); > - pm_runtime_mark_last_busy(dev); > pm_runtime_put_autosuspend(dev); > } >