Re: 2.4.5 does not link on Ruffian (alpha)

Andrea Arcangeli
2001-05-26T23:24:35Z

On Sat, May 26, 2001 at 07:36:49PM +0200, Andrea Arcangeli wrote:
> I got exactly the above when compiling for dp264 so I sent to Linus a
> patch to fix those compile problems, now I suspect my fix broke the
> generic compile :(, I will check that.

2.4.5aa1 compiles fine, but 2.4.5 doesn't, don't know why yet. Please
backout this patch from 2.4.5 for now, this should be the right thing to
do in the long run:

diff -urN alpha/arch/alpha/kernel/sys_dp264.c alpha-1/arch/alpha/kernel/sys_dp264.c
--- alpha/arch/alpha/kernel/sys_dp264.c Sun Apr 1 01:17:07 2001
+++ alpha-1/arch/alpha/kernel/sys_dp264.c Wed May 23 02:43:49 2001
@@ -16,15 +16,18 @@
#include <linux/pci.h>
#include <linux/init.h>

+#define __EXTERN_INLINE inline
+#include <asm/io.h>
+#include <asm/core_tsunami.h>
+#undef __EXTERN_INLINE
+
#include <asm/ptrace.h>
#include <asm/system.h>
#include <asm/dma.h>
#include <asm/irq.h>
#include <asm/bitops.h>
#include <asm/mmu_context.h>
-#include <asm/io.h>
#include <asm/pgtable.h>
-#include <asm/core_tsunami.h>
#include <asm/hwrpb.h>

#include "proto.h"

Now I will start a robot that will tell me in some hour of computations
which of the patches in my tree actually makes me to need the above
patch to compile both generic and dp264 correctly. After I localized the
offender patch it should be very easy to found why I need the above and
2.4.5 doesn't.

Andrea