From: Jens Axboe <axboe@kernel.dk>
To: Douglas Gilbert <dgilbert@interlog.com>,
linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org
Cc: bart.vanassche@wdc.com, dvyukov@google.com
Subject: Re: [PATCH] blk_rq_map_user_iov: fix error override
Date: Mon, 15 Jan 2018 08:50:53 -0700 [thread overview]
Message-ID: <0241d415-dc04-110a-771f-c245d963fec0@kernel.dk> (raw)
In-Reply-To: <20180114220048.8114-1-dgilbert@interlog.com>
On 1/14/18 3:00 PM, Douglas Gilbert wrote:
> During stress tests by syzkaller on the sg driver the block layer
> infrequently returns EINVAL. Closer inspection shows the block
> layer was trying to return ENOMEM (which is much more
> understandable) but for some reason overroad that useful error.
>
> Patch below does not show this (unchanged) line:
> ret =__blk_rq_map_user_iov(rq, map_data, &i, gfp_mask, copy);
> That 'ret' was being overridden when that function failed.
Thanks, applied.
--
Jens Axboe
prev parent reply other threads:[~2018-01-15 15:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-14 22:00 [PATCH] blk_rq_map_user_iov: fix error override Douglas Gilbert
2018-01-15 15:50 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0241d415-dc04-110a-771f-c245d963fec0@kernel.dk \
--to=axboe@kernel.dk \
--cc=bart.vanassche@wdc.com \
--cc=dgilbert@interlog.com \
--cc=dvyukov@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox