From: Jeff Johnson <quic_jjohnson@quicinc.com>
To: Paul Cercueil <paul@crapouillou.net>
Cc: Arend Van Spriel <aspriel@gmail.com>,
Franky Lin <franky.lin@broadcom.com>,
<linux-wireless@vger.kernel.org>,
<brcm80211-dev-list.pdl@broadcom.com>,
<SHA-cyfmac-dev-list@infineon.com>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] brcmfmac: Remove #ifdef guards for PM related functions
Date: Fri, 24 Jun 2022 11:59:25 -0700 [thread overview]
Message-ID: <0251f2c9-0f66-7dc9-7fb6-cc41a8dfd918@quicinc.com> (raw)
In-Reply-To: <WHVZDR.GB0H9SQC9PDP@crapouillou.net>
On 6/24/2022 11:32 AM, Paul Cercueil wrote:
> Hi,
>
> Le ven., juin 24 2022 at 09:31:22 -0700, Jeff Johnson
> <quic_jjohnson@quicinc.com> a écrit :
>> On 6/24/2022 2:24 AM, Arend Van Spriel wrote:
>>> On 6/23/2022 2:42 PM, Paul Cercueil wrote:
>>
>> [snip]
>>
>>>> - if (sdiodev->freezer) {
>>>> + if (IS_ENABLED(CONFIG_PM_SLEEP) && sdiodev->freezer) {
>>>
>>> This change is not necessary. sdiodev->freezer will be NULL when
>>> \x7fCONFIG_PM_SLEEP is not enabled.
>>
>> but won't the compiler be able to completely optimize the code away if
>> the change is present?
>
> That's correct. But do we want to complexify a bit the code for the sake
> of saving a few bytes? I leave that as an open question to the
> maintainer, I'm really fine with both options.
I'm fine either way as well. I'd have stronger opinions if ath drivers
were involved ;)
prev parent reply other threads:[~2022-06-24 18:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-23 12:42 [PATCH v2] brcmfmac: Remove #ifdef guards for PM related functions Paul Cercueil
2022-06-24 9:24 ` Arend Van Spriel
2022-06-24 16:31 ` Jeff Johnson
2022-06-24 18:32 ` Paul Cercueil
2022-06-24 18:59 ` Jeff Johnson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0251f2c9-0f66-7dc9-7fb6-cc41a8dfd918@quicinc.com \
--to=quic_jjohnson@quicinc.com \
--cc=SHA-cyfmac-dev-list@infineon.com \
--cc=aspriel@gmail.com \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=franky.lin@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=paul@crapouillou.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox