From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-24.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A9A7C433EF for ; Tue, 14 Sep 2021 16:01:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7447061151 for ; Tue, 14 Sep 2021 16:01:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235233AbhINQCm (ORCPT ); Tue, 14 Sep 2021 12:02:42 -0400 Received: from mail.kernel.org ([198.145.29.99]:57258 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234037AbhINQCh (ORCPT ); Tue, 14 Sep 2021 12:02:37 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 24E4061151; Tue, 14 Sep 2021 16:01:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1631635280; bh=YvnFp+LTkAmgQGEWe/SBIyJmwTJ98eh4cA8SOGc7JFg=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=PoeDqNqBcSWSq1v+Ma1vPWkDVmsjzdnoNH6UUs+V6Q3jziaFY5UXhmF6yE+k8LOuV pDIwhVhEAeUXWFuhV5EeEvCu0y0iAINaXs+FMhZ25+5/eDn0gkyBgAhx6/AcGRtBPc 31mYGojmg8mqOzxoHcqd2Ulah1rFqBjib1XZWeJ5lzPbBLEYEMapC3jKYkDOHgpjkR LqMlFFUi3jwDRzRs1YHR1Nyn/M4GJVKCySeFzIh1e1MhE1vYXWNWDgjVlIaq0Qt3Q4 BzM1A+Kvw2V8cMZCtlJqdHDZao17Q0Xc+WLssKOlpqzZiP/Ifx5gUFIEprQGxpaP0d W3t5hV+r1gz+A== Subject: Re: [PATCH] gen_compile_commands: add missing sys import To: andreas@rammhold.de, Nick Desaulniers Cc: llvm@lists.linux.dev, linux-kernel@vger.kernel.org References: <20210914154441.1726853-1-andreas@rammhold.de> From: Nathan Chancellor Message-ID: <026a4e82-da46-a559-06d5-18cff798ad96@kernel.org> Date: Tue, 14 Sep 2021 09:01:17 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20210914154441.1726853-1-andreas@rammhold.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Andreas, On 9/14/2021 8:44 AM, andreas@rammhold.de wrote: > From: Andreas Rammhold > > The sys.exit was being used at multiple locations within the script but > never imported. This lead to the script exiting with a error instead of > with the nicely formatted (useful) error output. > > Signed-off-by: Andreas Rammhold > --- > scripts/clang-tools/gen_compile_commands.py | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/scripts/clang-tools/gen_compile_commands.py b/scripts/clang-tools/gen_compile_commands.py > index 0033eedce003e..1d1bde1fd45eb 100755 > --- a/scripts/clang-tools/gen_compile_commands.py > +++ b/scripts/clang-tools/gen_compile_commands.py > @@ -13,6 +13,7 @@ import logging > import os > import re > import subprocess > +import sys > > _DEFAULT_OUTPUT = 'compile_commands.json' > _DEFAULT_LOG_LEVEL = 'WARNING' > Thank you for the patch! Someone else submitted the exact same fix and it is now pending in the kbuild tree: https://git.kernel.org/masahiroy/linux-kbuild/c/776f04ca2c29f13d483a3effc0c27404fe901143 I am curious, how did you discover this? Did you hit one of those error paths? Cheers, Nathan