From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
	by smtp.subspace.kernel.org (Postfix) with ESMTP id 5127D314B76
	for <linux-kernel@vger.kernel.org>; Thu, 18 Dec 2025 11:14:58 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1766056501; cv=none; b=rsysNU572k+h5EJec5ciHk38k9SBjCPJvuLi7GdV1/YBuN+lzr2/Mzg50cjKWjXQGUR1zmZCVtiHfik/7z8KF8VczJ2OkJfZMhKwNjAvOChv63LNyzijAQDwqbPKtcvOUy407b/IITyuKTWtpHAZ6goQfElnuA7JpJjOjDvnHiw=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1766056501; c=relaxed/simple;
	bh=r7hGxBFo4cB5hl+VL6eRjZ0gGGf9YnBWCL/J9Gh3/kY=;
	h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:
	 In-Reply-To:Content-Type; b=gAyqdx1JAJjnhQWfJRAagwFrqQ5HcWxbMLxWobxOdhMyNqULfh1vJEDsrwrESUnqGTI1ISP0xdPpDrFxpRU3yuNAeglMlWBbpZ8l+i79bsK18Q5tCwqvCOQUHue5U1zjeVB1qT7DJNM12U9SrRAaYIT3hFdw3CLSopo3yweyN0s=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172
Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com
Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
	by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8CC5BFEC;
	Thu, 18 Dec 2025 03:14:50 -0800 (PST)
Received: from [10.1.39.180] (unknown [10.1.39.180])
	by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id AB3983F73F;
	Thu, 18 Dec 2025 03:14:56 -0800 (PST)
Message-ID: <026b42f6-2f83-448a-9b45-cc8740dd8d50@arm.com>
Date: Thu, 18 Dec 2025 11:14:55 +0000
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 2/2] mm/vmalloc: Add attempt_larger_order_alloc parameter
Content-Language: en-GB
To: Uladzislau Rezki <urezki@gmail.com>
Cc: linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>,
 Vishal Moola <vishal.moola@gmail.com>, Dev Jain <dev.jain@arm.com>,
 Baoquan He <bhe@redhat.com>, LKML <linux-kernel@vger.kernel.org>
References: <20251216211921.1401147-1-urezki@gmail.com>
 <20251216211921.1401147-2-urezki@gmail.com>
 <6ca6e796-cded-4221-b1f8-92176a80513e@arm.com> <aUKb1bL7CUcCWi8V@milan>
 <0f69442d-b44e-4b30-b11e-793511db9f1e@arm.com>
 <4a66f13d-318b-4cdb-b168-0c993ff8a309@arm.com> <aUMNyfeoEh_tJHpT@pc636>
From: Ryan Roberts <ryan.roberts@arm.com>
In-Reply-To: <aUMNyfeoEh_tJHpT@pc636>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 17/12/2025 20:08, Uladzislau Rezki wrote:
>>
>> What do you think?
>>
> I think with such big improvement we do not need a configuration knob.
> Your change will fully complete Vishal's work, i.e an idea to allocate
> using high-order pages.

Yes agreed. How do you want to proceed? I'll tidy up my patch and post it
properly if you like? (likely won't be until Tuesday though). Or if you prefer
to work on it, that's fine by me too.

Personally I think we should aim to get the fix into 6.19 to avoid the
performance regression (even if we think the allocation pattern of those
benchmarks is not the common case).

Thanks,
Ryan

> 
> --
> Uladzislau Rezki