Re: [PATCH 1/4] dt-bindings: memory: mediatek: Add mt8188 SMI reset control binding

["Friday Yang (杨阳)" <Friday.Yang@mediatek.com>]

On Wed, 2024-08-21 at 10:54 +0200, Krzysztof Kozlowski wrote:
>  	 
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
>  On 21/08/2024 10:26, friday.yang wrote:
> > To support SMI clamp and reset operation in genpd callback, add
> > SMI LARB reset register offset and mask related information in
> > the bindings. Add index in mt8188-resets.h to query the register
> > offset and mask in the SMI reset control driver.
> > 
> > Signed-off-by: friday.yang <friday.yang@mediatek.com>
> 
> User proper full name instead of login.
> 

Thanks for your comments and sorry for replying so late.
I will fix it to Friday Yang <friday.yang@mediatek.com>.

> 
> Please use subject prefixes matching the subsystem. You can get them
> for
> example with `git log --oneline -- DIRECTORY_OR_FILE` on the
> directory
> your patch is touching. For bindings, the preferred subjects are
> explained here:
> 
https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters
> 

I have already used this command `git log --oneline Documentation/devicetree/bindings/reset/`If you think it is inappropriate, how about this one?
'dt-bindings: reset: mediatek,mt8188-smi: Add SMI reset control binding
for MT8188'

> > ---
> >  .../bindings/reset/mediatek,smi-reset.yaml    | 46
> +++++++++++++++++++
> >  include/dt-bindings/reset/mt8188-resets.h     | 11 +++++
> >  2 files changed, 57 insertions(+)
> >  create mode 100644
> Documentation/devicetree/bindings/reset/mediatek,smi-reset.yaml
> > 
> > diff --git a/Documentation/devicetree/bindings/reset/mediatek,smi-
> reset.yaml b/Documentation/devicetree/bindings/reset/mediatek,smi-
> reset.yaml
> > new file mode 100644
> > index 000000000000..66ac121d2396
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/reset/mediatek,smi-
> reset.yaml
> > @@ -0,0 +1,46 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +# Copyright (c) 2024 MediaTek Inc.
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/reset/mediatek,smi-reset.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: MediaTek SMI Reset Controller
> > +
> > +maintainers:
> > +  - Friday Yang <friday.yang@mediatek.com>
> > +
> > +description: |
> > +  This reset controller node is used to perform reset management
> > +  of SMI larbs on MediaTek platform. It is used to implement
> various
> > +  reset functions required when SMI larbs apply clamp operation.
> > +
> > +  For list of all valid reset indices see
> > +    <dt-bindings/reset/mt8188-resets.h> for MT8188.
> > +
> > +properties:
> > +  compatible:
> > +    enum:
> > +      - mediatek,smi-reset-mt8188
> 
> Wrong placement of soc. It's mediatek,mt8189-whatever
> 

Thanks, I will fix it to 'mediatek,mt8188-smi-reset'.

> > +
> > +  "#reset-cells":
> > +    const: 1
> > +
> > +  mediatek,larb-rst-syscon:
> > +    $ref: /schemas/types.yaml#/definitions/phandle
> > +    description: phandle of the SMI larb's reset controller
> syscon.
> 
> Explain what is it used for.
> 

I will add the descriton like this, is this clear for you?
When SMI larb power on/off, we need larb clamp and reset to avoid bus
glitch, this is to improve bus protect. 
The reset controller node is used to update regmap to implement larb
reset function.

> > +
> > +required:
> > +  - compatible
> > +  - "#reset-cells"
> > +  - mediatek,larb-rst-syscon
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > +  - |
> > +    imgsys1_dip_top_rst: reset-controller {
> 
> Drop label

I see marvell,berlin2-reset.yaml, which also have a label.
Do you mean we should remove imgsys1_dip_top_rst, just use
'reset-controller' here.

> 
> > +          compatible = "mediatek,smi-reset-mt8188";
> 
> Use 4 spaces for example indentation.
> 

OK, I will use spaces instead of tab.

> > +          #reset-cells = <1>;
> > +          mediatek,larb-rst-syscon = <&imgsys1_dip_top>;
> > +    };
> 
> 
> Best regards,
> Krzysztof
>