From: "Stuart MacDonald" <stuartm@connecttech.com>
To: "'LKML'" <linux-kernel@vger.kernel.org>, <dwmw2@infradead.org>
Subject: Serial custom speed deprecated?
Date: Wed, 23 Aug 2006 17:41:34 -0400 [thread overview]
Message-ID: <028a01c6c6fc$e792be90$294b82ce@stuartm> (raw)
From
http://www.kernel.org/pub/linux/kernel/v2.5/ChangeLog-2.5.64
"<dwmw2@dwmw2.baythorne.internal>
Complain about setting custom speed or divisor on serial ports."
And the relevant patch hunk:
@@ -832,8 +826,17 @@
goto exit;
if (info->flags & UIF_INITIALIZED) {
if (((old_flags ^ port->flags) & UPF_SPD_MASK) ||
- old_custom_divisor != port->custom_divisor)
+ old_custom_divisor != port->custom_divisor) {
+ /* If they're setting up a custom divisor or speed,
+ * instead of clearing it, then bitch about it. No
+ * need to rate-limit; it's CAP_SYS_ADMIN only. */
+ if (port->flags & UPF_SPD_MASK) {
+ printk(KERN_NOTICE "%s sets custom speed on %s%d. This is deprecated.\n",
+ current->comm, info->tty->driver.name,
+ info->port->line);
+ }
uart_change_speed(info, NULL);
+ }
} else
retval = uart_startup(info, 1);
exit:
If custom speeds are deprecated, what's the new method for setting
them? Specifically, how can the SPD_CUST functionality be accomplished
without that flag? I've checked 2.5.64 and 2.6.17, and don't see how
it is possible.
..Stu
next reply other threads:[~2006-08-23 21:42 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-23 21:41 Stuart MacDonald [this message]
2006-08-24 9:18 ` Serial custom speed deprecated? David Woodhouse
2006-08-24 12:41 ` Stuart MacDonald
2006-08-24 13:19 ` Alan Cox
2006-08-24 13:03 ` David Woodhouse
2006-08-24 16:27 ` Krzysztof Halasa
2006-08-24 17:41 ` Alan Cox
2006-08-24 18:51 ` Krzysztof Halasa
2006-08-24 20:43 ` linux-os (Dick Johnson)
2006-08-24 22:11 ` Alan Cox
2006-08-27 6:52 ` Rogier Wolff
2006-08-27 10:00 ` Russell King
2006-08-28 14:14 ` Stuart MacDonald
2006-08-28 20:09 ` Russell King
2006-08-29 6:20 ` Rogier Wolff
2006-08-29 7:46 ` Russell King
2006-08-25 15:17 ` Stuart MacDonald
2006-08-25 15:52 ` linux-os (Dick Johnson)
2006-08-24 22:43 ` Alan Cox
2006-08-25 10:58 ` Krzysztof Halasa
2006-08-25 15:21 ` Stuart MacDonald
2006-08-25 19:32 ` Russell King
2006-08-25 20:21 ` Stuart MacDonald
2006-08-25 20:54 ` linux-os (Dick Johnson)
2006-08-25 20:39 ` Theodore Tso
2006-08-26 12:16 ` Krzysztof Halasa
2006-08-25 15:10 ` Stuart MacDonald
2006-08-24 22:05 ` Russell King
2006-08-25 15:01 ` Stuart MacDonald
[not found] <6N8LR-22A-5@gated-at.bofh.it>
[not found] ` <6Njxz-797-13@gated-at.bofh.it>
[not found] ` <6NqfR-5Ld-49@gated-at.bofh.it>
[not found] ` <6NrbQ-7Ab-27@gated-at.bofh.it>
[not found] ` <6NsB4-2GL-37@gated-at.bofh.it>
[not found] ` <6NvSc-1go-31@gated-at.bofh.it>
2006-08-25 11:40 ` Nick Craig-Wood
-- strict thread matches above, loose matches on Subject: below --
2006-08-26 18:16 linux
2006-08-26 19:37 ` Ian Stirling
2006-08-26 20:30 ` linux
2006-08-28 12:17 ` linux-os (Dick Johnson)
2006-08-28 14:39 ` Alan Cox
2006-08-28 14:50 ` linux-os (Dick Johnson)
2006-08-28 15:51 ` Michael Poole
2006-08-28 16:57 ` linux-os (Dick Johnson)
2006-08-28 17:40 ` Michael Poole
2006-08-28 18:04 ` linux-os (Dick Johnson)
2006-08-28 17:01 ` Alan Cox
2006-08-28 17:24 ` linux
2006-08-26 19:35 linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='028a01c6c6fc$e792be90$294b82ce@stuartm' \
--to=stuartm@connecttech.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox