public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Chanho Min" <chanho.min@lge.com>
To: "'Oleg Nesterov'" <oleg@redhat.com>, "'Ingo Molnar'" <mingo@kernel.org>
Cc: "'Linus Torvalds'" <torvalds@linux-foundation.org>,
	"'Linux List Kernel Mailing'" <linux-kernel@vger.kernel.org>,
	"'Rafael J. Wysocki'" <rafael.j.wysocki@intel.com>,
	"'Thomas Gleixner'" <tglx@linutronix.de>,
	"'Peter Zijlstra'" <a.p.zijlstra@chello.nl>,
	"'Pavel Machek'" <pavel@ucw.cz>,
	"'Michal Hocko'" <mhocko@suse.com>, <seungho1.park@lge.com>
Subject: RE: [PATCH] Revert "exec: make de_thread() freezable (was: Re: Linux 4.20-rc4)
Date: Thu, 6 Dec 2018 17:54:09 +0900	[thread overview]
Message-ID: <02a901d48d41$40aff110$c20fd330$@lge.com> (raw)
In-Reply-To: <20181205143618.GA9535@redhat.com>

> From: Oleg Nesterov [mailto:oleg@redhat.com]
> Sent: Wednesday, December 05, 2018 11:36 PM
> To: Ingo Molnar
> Cc: Linus Torvalds; Linux List Kernel Mailing; Rafael J. Wysocki; Chanho Min;
> Thomas Gleixner; Peter Zijlstra; Pavel Machek; Michal Hocko
> Subject: Re: [PATCH] Revert "exec: make de_thread() freezable (was: Re: Linux
> 4.20-rc4)
> 
> Ingo, et al,
> 
> Sorry, I am sick and can't participate this discussion right now,
> 
> On 12/04, Ingo Molnar wrote:
> >
> > * Oleg Nesterov <oleg@redhat.com> wrote:
> >
> > > we really need to narrow the (huge) scope of ->cred_guard_mutex in exec
> paths.
> > >
> > > my attempt to fix this was nacked, and nobody suggested a better solution
> so far.
> >
> > Any link to your patch and the NAK?
> 
> See https://lore.kernel.org/lkml/20170213141452.GA30203@redhat.com/
> 
> No questions, the patch wasn't pretty. And imo we need to rework the security
> hooks in the long term.
> 
> Oleg.

I am sorry for the reverting this patch. It's also my fault that
I didn't check lockdep. But, We decided to keep this patch in our product.
Freeze fail is a real problem we've had for the last two years,
whereas lockdep's notice is not a real problem.
We hope this issue will be resolved soon.

Special thanks to Oleg,
Chanho


  reply	other threads:[~2018-12-06  8:54 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-25 23:02 Linux 4.20-rc4 Linus Torvalds
2018-12-03  7:47 ` [PATCH] Revert "exec: make de_thread() freezable (was: Re: Linux 4.20-rc4) Ingo Molnar
2018-12-03  8:39   ` Michal Hocko
2018-12-03 12:03     ` Rafael J. Wysocki
2018-12-03 12:31     ` Oleg Nesterov
2018-12-03 12:38       ` Michal Hocko
2018-12-03 13:10         ` Pavel Machek
2018-12-03 13:53           ` Michal Hocko
2018-12-03 14:14             ` Pavel Machek
2018-12-03 14:17               ` Michal Hocko
2018-12-03 14:45                 ` Pavel Machek
2018-12-03 17:06                 ` Linus Torvalds
2018-12-03 17:18                   ` Michal Hocko
2018-12-03 18:55                   ` Pavel Machek
2018-12-04  9:02                 ` Ingo Molnar
2018-12-04  9:10                   ` Michal Hocko
2018-12-04  9:33                     ` Ingo Molnar
2018-12-04  9:58                       ` Michal Hocko
2018-12-04 17:31                         ` Linus Torvalds
2018-12-04 18:17                           ` Michal Hocko
2018-12-04 19:33                             ` Linus Torvalds
2018-12-04 19:49                               ` Linus Torvalds
2018-12-04 20:05                                 ` Linus Torvalds
2018-12-04 19:55                           ` Pavel Machek
2018-12-04 19:42                       ` Pavel Machek
2018-12-04 19:29                   ` Pavel Machek
2018-12-03 13:40         ` Oleg Nesterov
2018-12-03 11:56   ` Oleg Nesterov
2018-12-04  9:17     ` Ingo Molnar
2018-12-05 14:36       ` Oleg Nesterov
2018-12-06  8:54         ` Chanho Min [this message]
2018-12-06  8:57           ` Pavel Machek
2018-12-06  9:07             ` Chanho Min
2018-12-03 12:00   ` Rafael J. Wysocki
2018-12-04  8:42     ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='02a901d48d41$40aff110$c20fd330$@lge.com' \
    --to=chanho.min@lge.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mhocko@suse.com \
    --cc=mingo@kernel.org \
    --cc=oleg@redhat.com \
    --cc=pavel@ucw.cz \
    --cc=rafael.j.wysocki@intel.com \
    --cc=seungho1.park@lge.com \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox