public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Stuart MacDonald" <stuartm@connecttech.com>
To: "Jeff Garzik" <jgarzik@mandrakesoft.com>
Cc: <tytso@mit.edu>, <rmk@arm.linux.org.uk>, <linux-kernel@vger.kernel.org>
Subject: Re: Fw: [Patch] Some updates to serial-5.05
Date: Wed, 14 Nov 2001 13:46:17 -0500	[thread overview]
Message-ID: <02b901c16d3c$a4e4adc0$294b82ce@connecttech.com> (raw)
In-Reply-To: <00df01c16d23$b409ab20$294b82ce@connecttech.com> <3BF2947B.DF3BE9DC@mandrakesoft.com> <013d01c16d29$bc5d4380$294b82ce@connecttech.com> <3BF29D69.B16479A1@mandrakesoft.com>

From: "Jeff Garzik" <jgarzik@mandrakesoft.com>
> Easily.  Your patch:
> > +  case TIOCSER485GET:
> > +  case TIOCSER485SET:
> > +   if (state->lmode_fn)
> > +    return (state->lmode_fn)(state, cmd,
> > +       (unsigned int *) arg);
> > +   else
> > +    return -EINVAL;
> >    case TIOCMGET:
> >     return get_modem_info(info, (unsigned int *) arg);
> >    case TIOCMBIS:
>
> 2.4.x serial.c:
> >                 case TIOCMGET:
> >                         return get_modem_info(info, (unsigned int *)
arg);
> >                 case TIOCMBIS:
>
> The formatting is blatantly, obviously different.

Something is broken along the way then, as I have:
..?
Grrr. Something wicked (windowsian) has damaged all
the tabs when I was inlining the patches.

Hm. Attaching the patches mangles (uuencodes) them and
inlining them damages the tabs. So. Please get the patch tarball
from: ftp://ftp.connecttech.com/pub/linux/blueheat/

> Doubtful.  When applied to 2.4.x-current:
>
> [jgarzik@rum linux_2_4]$ patch drivers/char/serial.c < ~/tmp/patch
> patching file drivers/char/serial.c
> Hunk #1 FAILED at 1405.
> Hunk #2 FAILED at 2514.
> Hunk #3 FAILED at 2572.
> Hunk #4 FAILED at 3968.
> patch: **** malformed patch at line 55: {

You're right, the patches tend not to apply to non-5.05 versions.
However, applying them to 2.4.14 doesn't give me the above. What
exactly is 2.4.x-current, and where can I get it?

I'll do a patch set against 5.05c, should rmk or tytso request it.
Unless you're also a serial maintainer of some description?

..Stu



  reply	other threads:[~2001-11-14 18:43 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-11-14 15:47 Fw: [Patch] Some updates to serial-5.05 Stuart MacDonald
2001-11-14 15:57 ` Jeff Garzik
2001-11-14 16:30   ` Stuart MacDonald
2001-11-14 16:35     ` Jeff Garzik
2001-11-14 18:46       ` Stuart MacDonald [this message]
2001-11-14 18:57         ` Jeff Garzik
2001-11-14 19:24           ` Stuart MacDonald
2001-11-14 17:04 ` Roman Kurakin
2001-11-15  0:10 ` Russell King
2001-11-15  0:25   ` Jeff Garzik
2001-11-15 15:23   ` Stuart MacDonald

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='02b901c16d3c$a4e4adc0$294b82ce@connecttech.com' \
    --to=stuartm@connecttech.com \
    --cc=jgarzik@mandrakesoft.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rmk@arm.linux.org.uk \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox