From: Krzysztof Kozlowski <krzk@kernel.org>
To: Jie Gan <jie.gan@oss.qualcomm.com>
Cc: Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Tingwei Zhang <tingwei.zhang@oss.qualcomm.com>,
Jingyi Wang <jingyi.wang@oss.qualcomm.com>,
Abel Vesa <abel.vesa@oss.qualcomm.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Mike Leach <mike.leach@arm.com>,
James Clark <james.clark@linaro.org>, Leo Yan <leo.yan@arm.com>,
Yuanfang Zhang <yuanfang.zhang@oss.qualcomm.com>,
Abel Vesa <abelvesa@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, coresight@lists.linaro.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v5 1/5] dt-bindings: arm: coresight-tnoc: Drop arm,primecell to bind on platform bus
Date: Thu, 9 Jul 2026 10:46:40 +0200 [thread overview]
Message-ID: <02baada9-3f87-4e60-a469-44af5ebe1afe@kernel.org> (raw)
In-Reply-To: <e5876525-4568-43bd-8c91-6dc462b18fa3@oss.qualcomm.com>
On 09/07/2026 10:34, Jie Gan wrote:
>
>
> On 7/9/2026 3:59 PM, Krzysztof Kozlowski wrote:
>> On Tue, Jul 07, 2026 at 05:08:49PM +0800, Jie Gan wrote:
>>> The TNOC compatible previously required the two-string AMBA form
>>> "qcom,coresight-tnoc", "arm,primecell", which forces the device onto the
>>> AMBA bus.
>>>
>>> Change the compatible to a single "qcom,coresight-tnoc" string with no
>>> "arm,primecell" entry, so the device is created on the platform bus and
>>> bound by the platform driver through its compatible string.
>>
>> I asked already: this is not a valid reason. References to Linux
>> structures are not correct here. If this is your reason, then answer is:
>> fix drivers, by renaming or doing whatever is necessary to platform bus
>> to behave like amba bus.
>
> The issue is that we are not allowed to introduce a DT property to
> bypass the AMBA bus validation, which reads the Component ID (CID)
It is the first time "bypass the AMBU bus validation" appears in this
patch. You do not see that as a problem?
Again, third time and the last: describe the actual hardware and the
actual problem coming from the hardware.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-07-09 8:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-07 9:08 [PATCH v5 0/5] Fix traceNoC probe issue on multiple QCOM platforms Jie Gan
2026-07-07 9:08 ` [PATCH v5 1/5] dt-bindings: arm: coresight-tnoc: Drop arm,primecell to bind on platform bus Jie Gan
2026-07-09 7:59 ` Krzysztof Kozlowski
2026-07-09 8:34 ` Jie Gan
2026-07-09 8:46 ` Krzysztof Kozlowski [this message]
2026-07-09 9:02 ` Jie Gan
2026-07-09 9:17 ` Krzysztof Kozlowski
2026-07-07 9:08 ` [PATCH v5 2/5] coresight: tnoc: Bind Aggregator TNOC on the " Jie Gan
2026-07-07 9:08 ` [PATCH v5 3/5] arm64: dts: qcom: kaanapali: fix traceNoC probe issue Jie Gan
2026-07-07 9:08 ` [PATCH v5 4/5] arm64: dts: qcom: sm8750: " Jie Gan
2026-07-07 9:08 ` [PATCH v5 5/5] arm64: dts: qcom: glymur: use Aggregator TNOC compatible Jie Gan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=02baada9-3f87-4e60-a469-44af5ebe1afe@kernel.org \
--to=krzk@kernel.org \
--cc=abel.vesa@oss.qualcomm.com \
--cc=abelvesa@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=coresight@lists.linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=james.clark@linaro.org \
--cc=jie.gan@oss.qualcomm.com \
--cc=jingyi.wang@oss.qualcomm.com \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=leo.yan@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mike.leach@arm.com \
--cc=robh@kernel.org \
--cc=suzuki.poulose@arm.com \
--cc=tingwei.zhang@oss.qualcomm.com \
--cc=yuanfang.zhang@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox