From: Kukjin Kim <kgene.kim@samsung.com>
To: "'Mateusz Krawczuk'" <m.krawczuk@partner.samsung.com>,
t.figa@samsung.com, linus.walleij@linaro.org
Cc: thomas.abraham@linaro.org, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
"'Kyungmin Park'" <kyungmin.park@samsung.com>
Subject: RE: [PATCH] pinctrl: Correct number of pins for s5pv210
Date: Thu, 26 Sep 2013 13:36:33 +0900 [thread overview]
Message-ID: <02bc01ceba71$fa8bcda0$efa368e0$%kim@samsung.com> (raw)
In-Reply-To: <1380035051-24526-1-git-send-email-m.krawczuk@partner.samsung.com>
Mateusz Krawczuk wrote:
>
> Values of pins in table s5pv210 bank are incorrect. This patch correct
> values.
>
> Signed-off-by: Mateusz Krawczuk <m.krawczuk@partner.samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
This fix is correct,
Acked-by: Kukjin Kim <kgene.kim@samsung.com>
Thanks,
Kukjin
> ---
> drivers/pinctrl/pinctrl-exynos.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/pinctrl/pinctrl-exynos.c b/drivers/pinctrl/pinctrl-
> exynos.c
> index 2689f8d..155b1b3 100644
> --- a/drivers/pinctrl/pinctrl-exynos.c
> +++ b/drivers/pinctrl/pinctrl-exynos.c
> @@ -663,18 +663,18 @@ static void exynos_pinctrl_resume(struct
> samsung_pinctrl_drv_data *drvdata)
> /* pin banks of s5pv210 pin-controller */
> static struct samsung_pin_bank s5pv210_pin_bank[] = {
> EXYNOS_PIN_BANK_EINTG(8, 0x000, "gpa0", 0x00),
> - EXYNOS_PIN_BANK_EINTG(6, 0x020, "gpa1", 0x04),
> + EXYNOS_PIN_BANK_EINTG(4, 0x020, "gpa1", 0x04),
> EXYNOS_PIN_BANK_EINTG(8, 0x040, "gpb", 0x08),
> EXYNOS_PIN_BANK_EINTG(5, 0x060, "gpc0", 0x0c),
> EXYNOS_PIN_BANK_EINTG(5, 0x080, "gpc1", 0x10),
> EXYNOS_PIN_BANK_EINTG(4, 0x0a0, "gpd0", 0x14),
> - EXYNOS_PIN_BANK_EINTG(4, 0x0c0, "gpd1", 0x18),
> - EXYNOS_PIN_BANK_EINTG(5, 0x0e0, "gpe0", 0x1c),
> - EXYNOS_PIN_BANK_EINTG(8, 0x100, "gpe1", 0x20),
> - EXYNOS_PIN_BANK_EINTG(6, 0x120, "gpf0", 0x24),
> + EXYNOS_PIN_BANK_EINTG(6, 0x0c0, "gpd1", 0x18),
> + EXYNOS_PIN_BANK_EINTG(8, 0x0e0, "gpe0", 0x1c),
> + EXYNOS_PIN_BANK_EINTG(5, 0x100, "gpe1", 0x20),
> + EXYNOS_PIN_BANK_EINTG(8, 0x120, "gpf0", 0x24),
> EXYNOS_PIN_BANK_EINTG(8, 0x140, "gpf1", 0x28),
> EXYNOS_PIN_BANK_EINTG(8, 0x160, "gpf2", 0x2c),
> - EXYNOS_PIN_BANK_EINTG(8, 0x180, "gpf3", 0x30),
> + EXYNOS_PIN_BANK_EINTG(6, 0x180, "gpf3", 0x30),
> EXYNOS_PIN_BANK_EINTG(7, 0x1a0, "gpg0", 0x34),
> EXYNOS_PIN_BANK_EINTG(7, 0x1c0, "gpg1", 0x38),
> EXYNOS_PIN_BANK_EINTG(7, 0x1e0, "gpg2", 0x3c),
> --
> 1.8.1.2
next prev parent reply other threads:[~2013-09-26 4:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-24 15:04 [PATCH] pinctrl: Correct number of pins for s5pv210 Mateusz Krawczuk
2013-09-24 15:06 ` Tomasz Figa
2013-09-26 4:36 ` Kukjin Kim [this message]
2013-09-27 13:51 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='02bc01ceba71$fa8bcda0$efa368e0$%kim@samsung.com' \
--to=kgene.kim@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.krawczuk@partner.samsung.com \
--cc=t.figa@samsung.com \
--cc=thomas.abraham@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox