* [PATCH] pinctrl: Correct number of pins for s5pv210
@ 2013-09-24 15:04 Mateusz Krawczuk
2013-09-24 15:06 ` Tomasz Figa
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Mateusz Krawczuk @ 2013-09-24 15:04 UTC (permalink / raw)
To: t.figa, linus.walleij
Cc: thomas.abraham, kgene.kim, linux-arm-kernel, linux-samsung-soc,
linux-kernel, Mateusz Krawczuk, Kyungmin Park
Values of pins in table s5pv210 bank are incorrect. This patch correct values.
Signed-off-by: Mateusz Krawczuk <m.krawczuk@partner.samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
---
drivers/pinctrl/pinctrl-exynos.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/pinctrl/pinctrl-exynos.c b/drivers/pinctrl/pinctrl-exynos.c
index 2689f8d..155b1b3 100644
--- a/drivers/pinctrl/pinctrl-exynos.c
+++ b/drivers/pinctrl/pinctrl-exynos.c
@@ -663,18 +663,18 @@ static void exynos_pinctrl_resume(struct samsung_pinctrl_drv_data *drvdata)
/* pin banks of s5pv210 pin-controller */
static struct samsung_pin_bank s5pv210_pin_bank[] = {
EXYNOS_PIN_BANK_EINTG(8, 0x000, "gpa0", 0x00),
- EXYNOS_PIN_BANK_EINTG(6, 0x020, "gpa1", 0x04),
+ EXYNOS_PIN_BANK_EINTG(4, 0x020, "gpa1", 0x04),
EXYNOS_PIN_BANK_EINTG(8, 0x040, "gpb", 0x08),
EXYNOS_PIN_BANK_EINTG(5, 0x060, "gpc0", 0x0c),
EXYNOS_PIN_BANK_EINTG(5, 0x080, "gpc1", 0x10),
EXYNOS_PIN_BANK_EINTG(4, 0x0a0, "gpd0", 0x14),
- EXYNOS_PIN_BANK_EINTG(4, 0x0c0, "gpd1", 0x18),
- EXYNOS_PIN_BANK_EINTG(5, 0x0e0, "gpe0", 0x1c),
- EXYNOS_PIN_BANK_EINTG(8, 0x100, "gpe1", 0x20),
- EXYNOS_PIN_BANK_EINTG(6, 0x120, "gpf0", 0x24),
+ EXYNOS_PIN_BANK_EINTG(6, 0x0c0, "gpd1", 0x18),
+ EXYNOS_PIN_BANK_EINTG(8, 0x0e0, "gpe0", 0x1c),
+ EXYNOS_PIN_BANK_EINTG(5, 0x100, "gpe1", 0x20),
+ EXYNOS_PIN_BANK_EINTG(8, 0x120, "gpf0", 0x24),
EXYNOS_PIN_BANK_EINTG(8, 0x140, "gpf1", 0x28),
EXYNOS_PIN_BANK_EINTG(8, 0x160, "gpf2", 0x2c),
- EXYNOS_PIN_BANK_EINTG(8, 0x180, "gpf3", 0x30),
+ EXYNOS_PIN_BANK_EINTG(6, 0x180, "gpf3", 0x30),
EXYNOS_PIN_BANK_EINTG(7, 0x1a0, "gpg0", 0x34),
EXYNOS_PIN_BANK_EINTG(7, 0x1c0, "gpg1", 0x38),
EXYNOS_PIN_BANK_EINTG(7, 0x1e0, "gpg2", 0x3c),
--
1.8.1.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] pinctrl: Correct number of pins for s5pv210
2013-09-24 15:04 [PATCH] pinctrl: Correct number of pins for s5pv210 Mateusz Krawczuk
@ 2013-09-24 15:06 ` Tomasz Figa
2013-09-26 4:36 ` Kukjin Kim
2013-09-27 13:51 ` Linus Walleij
2 siblings, 0 replies; 4+ messages in thread
From: Tomasz Figa @ 2013-09-24 15:06 UTC (permalink / raw)
To: Mateusz Krawczuk
Cc: linus.walleij, thomas.abraham, kgene.kim, linux-arm-kernel,
linux-samsung-soc, linux-kernel, Kyungmin Park
Hi Mateusz,
On Tuesday 24 of September 2013 16:35:07 Mateusz Krawczuk wrote:
> Values of pins in table s5pv210 bank are incorrect. This patch correct values.
>
> Signed-off-by: Mateusz Krawczuk <m.krawczuk@partner.samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
> drivers/pinctrl/pinctrl-exynos.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
Acked-by: Tomasz Figa <t.figa@samsung.com>
Best regards,
Tomasz
P.S. Please be more careful next time when defining things like this.
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH] pinctrl: Correct number of pins for s5pv210
2013-09-24 15:04 [PATCH] pinctrl: Correct number of pins for s5pv210 Mateusz Krawczuk
2013-09-24 15:06 ` Tomasz Figa
@ 2013-09-26 4:36 ` Kukjin Kim
2013-09-27 13:51 ` Linus Walleij
2 siblings, 0 replies; 4+ messages in thread
From: Kukjin Kim @ 2013-09-26 4:36 UTC (permalink / raw)
To: 'Mateusz Krawczuk', t.figa, linus.walleij
Cc: thomas.abraham, linux-arm-kernel, linux-samsung-soc, linux-kernel,
'Kyungmin Park'
Mateusz Krawczuk wrote:
>
> Values of pins in table s5pv210 bank are incorrect. This patch correct
> values.
>
> Signed-off-by: Mateusz Krawczuk <m.krawczuk@partner.samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
This fix is correct,
Acked-by: Kukjin Kim <kgene.kim@samsung.com>
Thanks,
Kukjin
> ---
> drivers/pinctrl/pinctrl-exynos.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/pinctrl/pinctrl-exynos.c b/drivers/pinctrl/pinctrl-
> exynos.c
> index 2689f8d..155b1b3 100644
> --- a/drivers/pinctrl/pinctrl-exynos.c
> +++ b/drivers/pinctrl/pinctrl-exynos.c
> @@ -663,18 +663,18 @@ static void exynos_pinctrl_resume(struct
> samsung_pinctrl_drv_data *drvdata)
> /* pin banks of s5pv210 pin-controller */
> static struct samsung_pin_bank s5pv210_pin_bank[] = {
> EXYNOS_PIN_BANK_EINTG(8, 0x000, "gpa0", 0x00),
> - EXYNOS_PIN_BANK_EINTG(6, 0x020, "gpa1", 0x04),
> + EXYNOS_PIN_BANK_EINTG(4, 0x020, "gpa1", 0x04),
> EXYNOS_PIN_BANK_EINTG(8, 0x040, "gpb", 0x08),
> EXYNOS_PIN_BANK_EINTG(5, 0x060, "gpc0", 0x0c),
> EXYNOS_PIN_BANK_EINTG(5, 0x080, "gpc1", 0x10),
> EXYNOS_PIN_BANK_EINTG(4, 0x0a0, "gpd0", 0x14),
> - EXYNOS_PIN_BANK_EINTG(4, 0x0c0, "gpd1", 0x18),
> - EXYNOS_PIN_BANK_EINTG(5, 0x0e0, "gpe0", 0x1c),
> - EXYNOS_PIN_BANK_EINTG(8, 0x100, "gpe1", 0x20),
> - EXYNOS_PIN_BANK_EINTG(6, 0x120, "gpf0", 0x24),
> + EXYNOS_PIN_BANK_EINTG(6, 0x0c0, "gpd1", 0x18),
> + EXYNOS_PIN_BANK_EINTG(8, 0x0e0, "gpe0", 0x1c),
> + EXYNOS_PIN_BANK_EINTG(5, 0x100, "gpe1", 0x20),
> + EXYNOS_PIN_BANK_EINTG(8, 0x120, "gpf0", 0x24),
> EXYNOS_PIN_BANK_EINTG(8, 0x140, "gpf1", 0x28),
> EXYNOS_PIN_BANK_EINTG(8, 0x160, "gpf2", 0x2c),
> - EXYNOS_PIN_BANK_EINTG(8, 0x180, "gpf3", 0x30),
> + EXYNOS_PIN_BANK_EINTG(6, 0x180, "gpf3", 0x30),
> EXYNOS_PIN_BANK_EINTG(7, 0x1a0, "gpg0", 0x34),
> EXYNOS_PIN_BANK_EINTG(7, 0x1c0, "gpg1", 0x38),
> EXYNOS_PIN_BANK_EINTG(7, 0x1e0, "gpg2", 0x3c),
> --
> 1.8.1.2
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] pinctrl: Correct number of pins for s5pv210
2013-09-24 15:04 [PATCH] pinctrl: Correct number of pins for s5pv210 Mateusz Krawczuk
2013-09-24 15:06 ` Tomasz Figa
2013-09-26 4:36 ` Kukjin Kim
@ 2013-09-27 13:51 ` Linus Walleij
2 siblings, 0 replies; 4+ messages in thread
From: Linus Walleij @ 2013-09-27 13:51 UTC (permalink / raw)
To: Mateusz Krawczuk
Cc: Tomasz Figa, Thomas Abraham, Kukjin Kim,
linux-arm-kernel@lists.infradead.org, linux-samsung-soc,
linux-kernel@vger.kernel.org, Kyungmin Park
On Tue, Sep 24, 2013 at 5:04 PM, Mateusz Krawczuk
<m.krawczuk@partner.samsung.com> wrote:
> Values of pins in table s5pv210 bank are incorrect. This patch correct values.
>
> Signed-off-by: Mateusz Krawczuk <m.krawczuk@partner.samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
Patch applied for fixes with the ACKs from Tomasz and Kukjin.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-09-27 13:51 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-24 15:04 [PATCH] pinctrl: Correct number of pins for s5pv210 Mateusz Krawczuk
2013-09-24 15:06 ` Tomasz Figa
2013-09-26 4:36 ` Kukjin Kim
2013-09-27 13:51 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox