* [PATCH] cpufreq: exynos: allow build for !THERMAL or !CPU_THERMAL cases
@ 2015-02-20 16:20 Bartlomiej Zolnierkiewicz
2015-02-23 4:37 ` Viresh Kumar
2015-03-24 14:53 ` Eduardo Valentin
0 siblings, 2 replies; 7+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2015-02-20 16:20 UTC (permalink / raw)
To: Viresh Kumar, linux-samsung-soc
Cc: Kukjin Kim, Arnd Bergmann, Eduardo Valentin, Lukasz Majewski,
linux-pm, linux-arm-kernel, linux-kernel
Allow driver build for !THERMAL or !CPU_THERMAL cases.
The new dependency rule is the same as the one that CPUFREQ_DT
option has (for cpufreq-dt driver which has the same issue with
using of_cpufreq_cooling_register()).
Cc: Kukjin Kim <kgene@kernel.org>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Eduardo Valentin <edubezval@gmail.com>
Cc: Lukasz Majewski <l.majewski@samsung.com>
Fixes: 8b2b4a4e5366 ("cpufreq: exynos: allow modular build")
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
---
drivers/cpufreq/Kconfig.arm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm
index 1b06fc4..f4df4af3 100644
--- a/drivers/cpufreq/Kconfig.arm
+++ b/drivers/cpufreq/Kconfig.arm
@@ -28,7 +28,8 @@ config ARM_VEXPRESS_SPC_CPUFREQ
config ARM_EXYNOS_CPUFREQ
tristate "SAMSUNG EXYNOS CPUfreq Driver"
depends on CPU_EXYNOS4210 || SOC_EXYNOS4212 || SOC_EXYNOS4412 || SOC_EXYNOS5250
- depends on THERMAL
+ # if CPU_THERMAL is on and THERMAL=m, ARM_EXYNOS_CPUFREQ cannot be =y:
+ depends on !CPU_THERMAL || THERMAL
help
This adds the CPUFreq driver for Samsung EXYNOS platforms.
Supported SoC versions are:
--
1.8.2.3
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH] cpufreq: exynos: allow build for !THERMAL or !CPU_THERMAL cases
2015-02-20 16:20 [PATCH] cpufreq: exynos: allow build for !THERMAL or !CPU_THERMAL cases Bartlomiej Zolnierkiewicz
@ 2015-02-23 4:37 ` Viresh Kumar
2015-03-23 16:43 ` Bartlomiej Zolnierkiewicz
2015-03-24 14:53 ` Eduardo Valentin
1 sibling, 1 reply; 7+ messages in thread
From: Viresh Kumar @ 2015-02-23 4:37 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz
Cc: linux-samsung-soc, Kukjin Kim, Arnd Bergmann, Eduardo Valentin,
Lukasz Majewski, linux-pm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, Linux Kernel Mailing List
On 20 February 2015 at 21:50, Bartlomiej Zolnierkiewicz
<b.zolnierkie@samsung.com> wrote:
> Allow driver build for !THERMAL or !CPU_THERMAL cases.
>
> The new dependency rule is the same as the one that CPUFREQ_DT
> option has (for cpufreq-dt driver which has the same issue with
> using of_cpufreq_cooling_register()).
>
> Cc: Kukjin Kim <kgene@kernel.org>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: Eduardo Valentin <edubezval@gmail.com>
> Cc: Lukasz Majewski <l.majewski@samsung.com>
> Fixes: 8b2b4a4e5366 ("cpufreq: exynos: allow modular build")
> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> ---
> drivers/cpufreq/Kconfig.arm | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm
> index 1b06fc4..f4df4af3 100644
> --- a/drivers/cpufreq/Kconfig.arm
> +++ b/drivers/cpufreq/Kconfig.arm
> @@ -28,7 +28,8 @@ config ARM_VEXPRESS_SPC_CPUFREQ
> config ARM_EXYNOS_CPUFREQ
> tristate "SAMSUNG EXYNOS CPUfreq Driver"
> depends on CPU_EXYNOS4210 || SOC_EXYNOS4212 || SOC_EXYNOS4412 || SOC_EXYNOS5250
> - depends on THERMAL
> + # if CPU_THERMAL is on and THERMAL=m, ARM_EXYNOS_CPUFREQ cannot be =y:
> + depends on !CPU_THERMAL || THERMAL
> help
> This adds the CPUFreq driver for Samsung EXYNOS platforms.
> Supported SoC versions are:
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] cpufreq: exynos: allow build for !THERMAL or !CPU_THERMAL cases
2015-02-23 4:37 ` Viresh Kumar
@ 2015-03-23 16:43 ` Bartlomiej Zolnierkiewicz
2015-03-24 2:25 ` Viresh Kumar
2015-03-24 12:53 ` Kukjin Kim
0 siblings, 2 replies; 7+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2015-03-23 16:43 UTC (permalink / raw)
To: Viresh Kumar
Cc: linux-samsung-soc, Kukjin Kim, Arnd Bergmann, Eduardo Valentin,
Lukasz Majewski, linux-pm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, Linux Kernel Mailing List
Hi,
On Monday, February 23, 2015 10:07:50 AM Viresh Kumar wrote:
> On 20 February 2015 at 21:50, Bartlomiej Zolnierkiewicz
> <b.zolnierkie@samsung.com> wrote:
> > Allow driver build for !THERMAL or !CPU_THERMAL cases.
> >
> > The new dependency rule is the same as the one that CPUFREQ_DT
> > option has (for cpufreq-dt driver which has the same issue with
> > using of_cpufreq_cooling_register()).
> >
> > Cc: Kukjin Kim <kgene@kernel.org>
> > Cc: Arnd Bergmann <arnd@arndb.de>
> > Cc: Eduardo Valentin <edubezval@gmail.com>
> > Cc: Lukasz Majewski <l.majewski@samsung.com>
> > Fixes: 8b2b4a4e5366 ("cpufreq: exynos: allow modular build")
> > Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> > ---
> > drivers/cpufreq/Kconfig.arm | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm
> > index 1b06fc4..f4df4af3 100644
> > --- a/drivers/cpufreq/Kconfig.arm
> > +++ b/drivers/cpufreq/Kconfig.arm
> > @@ -28,7 +28,8 @@ config ARM_VEXPRESS_SPC_CPUFREQ
> > config ARM_EXYNOS_CPUFREQ
> > tristate "SAMSUNG EXYNOS CPUfreq Driver"
> > depends on CPU_EXYNOS4210 || SOC_EXYNOS4212 || SOC_EXYNOS4412 || SOC_EXYNOS5250
> > - depends on THERMAL
> > + # if CPU_THERMAL is on and THERMAL=m, ARM_EXYNOS_CPUFREQ cannot be =y:
> > + depends on !CPU_THERMAL || THERMAL
> > help
> > This adds the CPUFreq driver for Samsung EXYNOS platforms.
> > Supported SoC versions are:
>
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Thank you for the ACK.
Would you pick this patch up or should I resend it to Rafael?
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] cpufreq: exynos: allow build for !THERMAL or !CPU_THERMAL cases
2015-03-23 16:43 ` Bartlomiej Zolnierkiewicz
@ 2015-03-24 2:25 ` Viresh Kumar
2015-03-24 12:53 ` Kukjin Kim
1 sibling, 0 replies; 7+ messages in thread
From: Viresh Kumar @ 2015-03-24 2:25 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz
Cc: linux-samsung-soc, Kukjin Kim, Arnd Bergmann, Eduardo Valentin,
Lukasz Majewski, linux-pm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, Linux Kernel Mailing List
On 23 March 2015 at 22:13, Bartlomiej Zolnierkiewicz
<b.zolnierkie@samsung.com> wrote:
> Would you pick this patch up or should I resend it to Rafael?
Please resend it to Rafael and cc me and linux-pm list.. Also add my
Ack to it.
^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [PATCH] cpufreq: exynos: allow build for !THERMAL or !CPU_THERMAL cases
2015-03-23 16:43 ` Bartlomiej Zolnierkiewicz
2015-03-24 2:25 ` Viresh Kumar
@ 2015-03-24 12:53 ` Kukjin Kim
1 sibling, 0 replies; 7+ messages in thread
From: Kukjin Kim @ 2015-03-24 12:53 UTC (permalink / raw)
To: 'Bartlomiej Zolnierkiewicz', 'Viresh Kumar'
Cc: 'linux-samsung-soc', 'Kukjin Kim',
'Arnd Bergmann', 'Eduardo Valentin',
'Lukasz Majewski', linux-pm, linux-arm-kernel,
'Linux Kernel Mailing List'
Bartlomiej Zolnierkiewicz wrote:
>
> Hi,
>
Hi,
> On Monday, February 23, 2015 10:07:50 AM Viresh Kumar wrote:
> > On 20 February 2015 at 21:50, Bartlomiej Zolnierkiewicz
> > <b.zolnierkie@samsung.com> wrote:
> > > Allow driver build for !THERMAL or !CPU_THERMAL cases.
> > >
> > > The new dependency rule is the same as the one that CPUFREQ_DT
> > > option has (for cpufreq-dt driver which has the same issue with
> > > using of_cpufreq_cooling_register()).
> > >
> > > Cc: Kukjin Kim <kgene@kernel.org>
Looks OK to me,
Acked-by: Kukjin Kim <kgene@kernel.org>
Thanks,
Kukjin
> > > Cc: Arnd Bergmann <arnd@arndb.de>
> > > Cc: Eduardo Valentin <edubezval@gmail.com>
> > > Cc: Lukasz Majewski <l.majewski@samsung.com>
> > > Fixes: 8b2b4a4e5366 ("cpufreq: exynos: allow modular build")
> > > Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> > > ---
> > > drivers/cpufreq/Kconfig.arm | 3 ++-
> > > 1 file changed, 2 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm
> > > index 1b06fc4..f4df4af3 100644
> > > --- a/drivers/cpufreq/Kconfig.arm
> > > +++ b/drivers/cpufreq/Kconfig.arm
> > > @@ -28,7 +28,8 @@ config ARM_VEXPRESS_SPC_CPUFREQ
> > > config ARM_EXYNOS_CPUFREQ
> > > tristate "SAMSUNG EXYNOS CPUfreq Driver"
> > > depends on CPU_EXYNOS4210 || SOC_EXYNOS4212 || SOC_EXYNOS4412 || SOC_EXYNOS5250
> > > - depends on THERMAL
> > > + # if CPU_THERMAL is on and THERMAL=m, ARM_EXYNOS_CPUFREQ cannot be =y:
> > > + depends on !CPU_THERMAL || THERMAL
> > > help
> > > This adds the CPUFreq driver for Samsung EXYNOS platforms.
> > > Supported SoC versions are:
> >
> > Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
>
> Thank you for the ACK.
>
> Would you pick this patch up or should I resend it to Rafael?
>
> Best regards,
> --
> Bartlomiej Zolnierkiewicz
> Samsung R&D Institute Poland
> Samsung Electronics
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] cpufreq: exynos: allow build for !THERMAL or !CPU_THERMAL cases
2015-02-20 16:20 [PATCH] cpufreq: exynos: allow build for !THERMAL or !CPU_THERMAL cases Bartlomiej Zolnierkiewicz
2015-02-23 4:37 ` Viresh Kumar
@ 2015-03-24 14:53 ` Eduardo Valentin
1 sibling, 0 replies; 7+ messages in thread
From: Eduardo Valentin @ 2015-03-24 14:53 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz
Cc: Viresh Kumar, linux-samsung-soc, Kukjin Kim, Arnd Bergmann,
Lukasz Majewski, linux-pm, linux-arm-kernel, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1448 bytes --]
On Fri, Feb 20, 2015 at 05:20:22PM +0100, Bartlomiej Zolnierkiewicz wrote:
> Allow driver build for !THERMAL or !CPU_THERMAL cases.
>
> The new dependency rule is the same as the one that CPUFREQ_DT
> option has (for cpufreq-dt driver which has the same issue with
> using of_cpufreq_cooling_register()).
>
> Cc: Kukjin Kim <kgene@kernel.org>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: Eduardo Valentin <edubezval@gmail.com>
> Cc: Lukasz Majewski <l.majewski@samsung.com>
> Fixes: 8b2b4a4e5366 ("cpufreq: exynos: allow modular build")
> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Acked-by: Eduardo Valentin <edubezval@gmail.com>
> ---
> drivers/cpufreq/Kconfig.arm | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm
> index 1b06fc4..f4df4af3 100644
> --- a/drivers/cpufreq/Kconfig.arm
> +++ b/drivers/cpufreq/Kconfig.arm
> @@ -28,7 +28,8 @@ config ARM_VEXPRESS_SPC_CPUFREQ
> config ARM_EXYNOS_CPUFREQ
> tristate "SAMSUNG EXYNOS CPUfreq Driver"
> depends on CPU_EXYNOS4210 || SOC_EXYNOS4212 || SOC_EXYNOS4412 || SOC_EXYNOS5250
> - depends on THERMAL
> + # if CPU_THERMAL is on and THERMAL=m, ARM_EXYNOS_CPUFREQ cannot be =y:
> + depends on !CPU_THERMAL || THERMAL
> help
> This adds the CPUFreq driver for Samsung EXYNOS platforms.
> Supported SoC versions are:
> --
> 1.8.2.3
>
>
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] cpufreq: exynos: allow build for !THERMAL or !CPU_THERMAL cases
@ 2015-03-24 11:33 Bartlomiej Zolnierkiewicz
0 siblings, 0 replies; 7+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2015-03-24 11:33 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Viresh Kumar, linux-samsung-soc, Kukjin Kim, Arnd Bergmann,
Eduardo Valentin, Lukasz Majewski, linux-pm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, Linux Kernel Mailing List
Allow driver build for !THERMAL or !CPU_THERMAL cases.
The new dependency rule is the same as the one that CPUFREQ_DT
option has (for cpufreq-dt driver which has the same issue with
using of_cpufreq_cooling_register()).
Cc: Kukjin Kim <kgene@kernel.org>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Eduardo Valentin <edubezval@gmail.com>
Cc: Lukasz Majewski <l.majewski@samsung.com>
Fixes: 8b2b4a4e5366 ("cpufreq: exynos: allow modular build")
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
---
Hi Rafael, please apply this patch. It has been ACKed by Viresh already.
drivers/cpufreq/Kconfig.arm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm
index 1b06fc4..f4df4af3 100644
--- a/drivers/cpufreq/Kconfig.arm
+++ b/drivers/cpufreq/Kconfig.arm
@@ -28,7 +28,8 @@ config ARM_VEXPRESS_SPC_CPUFREQ
config ARM_EXYNOS_CPUFREQ
tristate "SAMSUNG EXYNOS CPUfreq Driver"
depends on CPU_EXYNOS4210 || SOC_EXYNOS4212 || SOC_EXYNOS4412 || SOC_EXYNOS5250
- depends on THERMAL
+ # if CPU_THERMAL is on and THERMAL=m, ARM_EXYNOS_CPUFREQ cannot be =y:
+ depends on !CPU_THERMAL || THERMAL
help
This adds the CPUFreq driver for Samsung EXYNOS platforms.
Supported SoC versions are:
--
1.8.2.3
^ permalink raw reply related [flat|nested] 7+ messages in thread
end of thread, other threads:[~2015-03-24 14:54 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-20 16:20 [PATCH] cpufreq: exynos: allow build for !THERMAL or !CPU_THERMAL cases Bartlomiej Zolnierkiewicz
2015-02-23 4:37 ` Viresh Kumar
2015-03-23 16:43 ` Bartlomiej Zolnierkiewicz
2015-03-24 2:25 ` Viresh Kumar
2015-03-24 12:53 ` Kukjin Kim
2015-03-24 14:53 ` Eduardo Valentin
-- strict thread matches above, loose matches on Subject: below --
2015-03-24 11:33 Bartlomiej Zolnierkiewicz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).