From: Ravi Bangoria <ravi.bangoria@linux.ibm.com>
To: kan.liang@linux.intel.com, acme@kernel.org
Cc: jolsa@kernel.org, mingo@redhat.com, linux-kernel@vger.kernel.org,
ak@linux.intel.com, Ravi Bangoria <ravi.bangoria@linux.ibm.com>
Subject: Re: [PATCH V2 1/3] perf parse-regs: Split parse_regs
Date: Wed, 15 May 2019 12:19:58 +0530 [thread overview]
Message-ID: <02cd8171-3dbf-b835-3fe0-245f6fbea1cb@linux.ibm.com> (raw)
In-Reply-To: <1557865174-56264-1-git-send-email-kan.liang@linux.intel.com>
On 5/15/19 1:49 AM, kan.liang@linux.intel.com wrote:
> From: Kan Liang <kan.liang@linux.intel.com>
>
> The available registers for --int-regs and --user-regs may be different,
> e.g. XMM registers.
>
> Split parse_regs into two dedicated functions for --int-regs and
> --user-regs respectively.
>
> Modify the warning message. "--user-regs=?" should be applied to show
> the available registers for --user-regs.
>
> Signed-off-by: Kan Liang <kan.liang@linux.intel.com>
> ---
For patch 1 and 2,
Tested-by: Ravi Bangoria <ravi.bangoria@linux.ibm.com>
Minor neat. Should we update document as well? May be something like:
tools/perf/Documentation/perf-record.txt
--user-regs::
Similar to -I, but capture user registers at sample time. To list the available
user registers use --user-regs=\?.
Ravi
next prev parent reply other threads:[~2019-05-15 6:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-14 20:19 [PATCH V2 1/3] perf parse-regs: Split parse_regs kan.liang
2019-05-14 20:19 ` [PATCH V2 2/3] perf parse-regs: Add generic support for arch__intr/user_reg_mask() kan.liang
2019-05-18 9:31 ` [tip:perf/core] " tip-bot for Kan Liang
2019-05-14 20:19 ` [PATCH V2 3/3] perf regs x86: Add X86 specific arch__intr_reg_mask() kan.liang
2019-05-15 19:28 ` Arnaldo Carvalho de Melo
2019-05-18 9:31 ` [tip:perf/core] " tip-bot for Kan Liang
2019-05-15 6:49 ` Ravi Bangoria [this message]
2019-05-15 14:15 ` [PATCH V2 1/3] perf parse-regs: Split parse_regs Liang, Kan
2019-05-18 9:30 ` [tip:perf/core] " tip-bot for Kan Liang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=02cd8171-3dbf-b835-3fe0-245f6fbea1cb@linux.ibm.com \
--to=ravi.bangoria@linux.ibm.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox