Re: [PATCH] IDE TCQ #4

Martin Dalecki
2002-04-18T13:18:33Z

Jens Axboe wrote:
> On Thu, Apr 18 2002, Martin Dalecki wrote:
>
>>Jens Axboe wrote:
>>
>>>On Thu, Apr 18 2002, Martin Dalecki wrote:
>>>
>>>
>>>>Jens Axboe wrote:
>>>>
>>>>
>>>>>On Thu, Apr 18 2002, Martin Dalecki wrote:
>>>>>
>>>>>
>>>>>
>>>>>>BTW> Jens: Do you have any idea what the "sector chaing" in ide-cd is
>>>>>>good for?! I would love to just get rid of it alltogether!
>>>>>
>>>>>
>>>>>Sector chaining? Are you talking about the cdrom_read_intr() comments?
>>>>
>>>>Sorry I did mean sector caching.
>>>
>>>
>>>That's for padding/caching sub-frame sized reads.
>>
>>I tought the BIO layer did this alredy... Well it's a pain
>
>
> Nope, it does not.
>
>
>>in the a** to deal with it. IDE-FLOPPY is passing packet commands
>
>
> It sure is... sr doesn't do it and lots of others don't as well, so I
> suppose we could rip it out. We already require reblocking with loop in
> those cases anyway.
>
>
>>through the request buffer but IDE-CD is passing them through
>>request special field... argh!
>
>
> So kill ->special usage in ide-cd and use ->buffer?

That's the idea, but the caching code mentioned above
is abusing it already in a way I can't grasp wholly immediately.

>

--
- phone: +49 214 8656 283
- job: eVision-Ventures AG, LEV .de (MY OPINIONS ARE MY OWN!)
- langs: de_DE.ISO8859-1, en_US, pl_PL.ISO8859-2, last ressort: ru_RU.KOI8-R