* [PATCH] ARM: dts: exynos4x12: Fix pull setting in sd4_width8 pin group
@ 2014-08-26 14:13 Tomasz Figa
2014-09-03 13:50 ` Kukjin Kim
0 siblings, 1 reply; 2+ messages in thread
From: Tomasz Figa @ 2014-08-26 14:13 UTC (permalink / raw)
To: linux-samsung-soc
Cc: linux-arm-kernel, linux-kernel, Kukjin Kim, Marek Szyprowski,
Tomasz Figa
The group has the samsung,pin-pud property set to 4, which is not a
correct value. This patch fixes this by replacing it with 3, which is
the correct value for pull-up.
Signed-off-by: Tomasz Figa <t.figa@samsung.com>
---
arch/arm/boot/dts/exynos4x12-pinctrl.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/exynos4x12-pinctrl.dtsi b/arch/arm/boot/dts/exynos4x12-pinctrl.dtsi
index 927fec6..c141931 100644
--- a/arch/arm/boot/dts/exynos4x12-pinctrl.dtsi
+++ b/arch/arm/boot/dts/exynos4x12-pinctrl.dtsi
@@ -691,7 +691,7 @@
sd4_bus8: sd4-bus-width8 {
samsung,pins = "gpk1-3", "gpk1-4", "gpk1-5", "gpk1-6";
samsung,pin-function = <4>;
- samsung,pin-pud = <4>;
+ samsung,pin-pud = <3>;
samsung,pin-drv = <3>;
};
--
2.0.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* RE: [PATCH] ARM: dts: exynos4x12: Fix pull setting in sd4_width8 pin group
2014-08-26 14:13 [PATCH] ARM: dts: exynos4x12: Fix pull setting in sd4_width8 pin group Tomasz Figa
@ 2014-09-03 13:50 ` Kukjin Kim
0 siblings, 0 replies; 2+ messages in thread
From: Kukjin Kim @ 2014-09-03 13:50 UTC (permalink / raw)
To: 'Tomasz Figa', linux-samsung-soc
Cc: linux-arm-kernel, linux-kernel, 'Marek Szyprowski'
Tomasz Figa wrote:
>
> The group has the samsung,pin-pud property set to 4, which is not a
> correct value. This patch fixes this by replacing it with 3, which is
> the correct value for pull-up.
>
Yes, I checked the value. You're right.
Will apply into fixes.
Thanks,
Kukjin
> Signed-off-by: Tomasz Figa <t.figa@samsung.com>
> ---
> arch/arm/boot/dts/exynos4x12-pinctrl.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/exynos4x12-pinctrl.dtsi b/arch/arm/boot/dts/exynos4x12-pinctrl.dtsi
> index 927fec6..c141931 100644
> --- a/arch/arm/boot/dts/exynos4x12-pinctrl.dtsi
> +++ b/arch/arm/boot/dts/exynos4x12-pinctrl.dtsi
> @@ -691,7 +691,7 @@
> sd4_bus8: sd4-bus-width8 {
> samsung,pins = "gpk1-3", "gpk1-4", "gpk1-5", "gpk1-6";
> samsung,pin-function = <4>;
> - samsung,pin-pud = <4>;
> + samsung,pin-pud = <3>;
> samsung,pin-drv = <3>;
> };
>
> --
> 2.0.4
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-09-03 13:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-26 14:13 [PATCH] ARM: dts: exynos4x12: Fix pull setting in sd4_width8 pin group Tomasz Figa
2014-09-03 13:50 ` Kukjin Kim
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox