From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CBEB43BB9F3 for ; Fri, 10 Apr 2026 11:59:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775822367; cv=none; b=FDE6pbcY9NvR/UYs65mO3xKkFB3Zuo6TYB/UlipXR6Dxk8llvNIRVPbOSmqtf0UZONJU1nEymdIO9Hq6OtYFtUFjyURqHuHRDgqh8nFi84ykROkwNQLRZWKY0HavkaGcp9IzYfPhIONHevFrcQPUL5PGofVus6a8xSzu5KNxPAc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775822367; c=relaxed/simple; bh=v5NSJZ8m+KjzHf0SXfqwYnT09yfmMTD4G2bhU8FttMQ=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=Mre+92nc7D5O0blwvxWr1S/+PYG0jSlkDHHEgSrsjnP2diziB+X4+jWWXOUjB81cgmol0YpMbQeJHPqhUqqjZZTLJ0V0UYDSsaX4QGtXrDGlBNs98atXHrxZDr6gFMGDXhd7LP9Flf4z2gEQs31lgC8myMIiDApTMKekL6O4PFg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=AccwqYpb; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="AccwqYpb" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-488a4bc360bso10948825e9.0 for ; Fri, 10 Apr 2026 04:59:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1775822364; x=1776427164; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=ARUmy3u+QOOrwwGq9+IgAFjaW2vQNODoG/89VhhLSEM=; b=AccwqYpbeQgzCEKfe1TVsHVqUhk1wHFgFco2+o1s9npaV/5k1Qe4Y2QrEt8FacJL3N 71ob2XWePKw6IUPcx1xtHLxSzskt2xuOvJQf2TEe6v0+pXnUk4qpJ7/zXMrCWMc1sGpp Q/OgQNGNeMiAeEehEanbnIdHVJflwjLYpEhhxgFPLb2xuJRTezj+N9G9Bb2y0TlRh4Q7 0V3YFZGV0Zl0uZYE7vMS+rJAA7r6gFEiDApUDMvp0PbE9sF/LHj4mlBYi8ClYKXuqVK2 U8m7XM8lbVgeZW68wEcufGeEHPgVWwoE1qLyHVn0B7mGHtdByYUU3RwtRUu9vnuC5xK4 ymEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775822364; x=1776427164; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ARUmy3u+QOOrwwGq9+IgAFjaW2vQNODoG/89VhhLSEM=; b=BNgOBN5ebyd2EXeVC0cvKh4FDgUR5a5EfuiCWba1dtIoCmHkRgnmcQK9nU6JOAWFJQ oiwJbWhk3N7pUA35PokwftKscZivpo90YCA4iqoqvzpdD5NNVSqt4biTsZskfiKVEJWF U76K4/9kFEXpEy5yq7l7eeeSL6ZnTiXV/1ChpF8Si7YLv1VnaGTkw3/hfDoQ9t6HUAZ3 /zIzWruLa+XvIaCw3Bvj/6jA/jRXmtBaHHT1w3thBSSIRIeCfgJRTfdZBwQlw+G1CQEh iJknB6rRwZDzvlU096huJOhtJ65nrM/gGMS7yiMfLkE7eAlq623u99exDQNSU+Nobxsf ubAw== X-Forwarded-Encrypted: i=1; AJvYcCUuh+GcZZo5c0QoR/rM3ChIhZ+l3CUJbhE+/sYvbog3RdJrItqeCXt8PfjKawJZm84qKWtqVzN209+mbno=@vger.kernel.org X-Gm-Message-State: AOJu0YyYhIpTWUlSeBb8P7yqwpBoN76T4xA7k80ATEtvm30q5RI/IHlW +i0055gZr0SNIGGvkRa5VIt7HdHbqaoPh8c3WgU/TrafovBNPGvNUe2Ot+B97XgBsJs= X-Gm-Gg: AeBDieuIgaTa8fKqKFMeBcEhovhm9ByCFtJxTVEEZrDD9pBSi7dXJ/mE60c3YFbttth kIjKQQm2GPFQgfBaPuPWD8+h+5Madq7u+cPHqtwGx4uHCXRlO9Jz33YMvU2BksnIZaOvyLgW2HJ tiqOXg1JTdMQjGjNeTazZPx82stt/7nhexb1Zh8/VAw/G54SIXj4WBF31/BnzHIBLHsb+XBndQ4 FrKjTIWojewJEjInNJc+v4mn8hk+HnSEtJ/EsjzScsIitgKkXvJJeXDg9rqfIxvRGlnB6tL3VVG SXZXCsE5F4F9qWtmdJUY+z+WCCCktdfJeB0LJCGYQKwOHzoLbCRz3Z2z0RKPC7+UOk/wPxsDq4o POM8gL+IN1RBmh6D9zYMkXxhe7lJVoSKJqXY1Pi3dXF6eUL88tPX1nRq7mRC7qzcdfl+AlE/Ult AA5SQact7lI0W+3ac0VExkVMYaYQDyGMZulcLWYfvlYQYRjpT78T6nFnEOkObFEeh1vAXlUJUd/ MXxyJKpn8iQshYqMg== X-Received: by 2002:a05:600c:8585:b0:486:fc5f:1ab9 with SMTP id 5b1f17b1804b1-488d68398femr25726335e9.14.1775822364089; Fri, 10 Apr 2026 04:59:24 -0700 (PDT) Received: from ?IPV6:2a01:e0a:106d:1080:66bc:1b4e:df7c:7dff? ([2a01:e0a:106d:1080:66bc:1b4e:df7c:7dff]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488d592db30sm60062585e9.10.2026.04.10.04.59.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Apr 2026 04:59:23 -0700 (PDT) Message-ID: <0301bf82-0859-44cd-99df-3de997e2cff4@linaro.org> Date: Fri, 10 Apr 2026 13:59:22 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Reply-To: Neil Armstrong Subject: Re: [PATCH RFC 4/7] media: qcom: iris: vdec: update size and stride calculations for 10bit formats To: Vishnu Reddy , Vikash Garodia , Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260408-topic-sm8x50-iris-10bit-decoding-v1-0-428c1ec2e3f3@linaro.org> <20260408-topic-sm8x50-iris-10bit-decoding-v1-4-428c1ec2e3f3@linaro.org> <99eb55a8-6370-bf7b-f9de-e88231454b0e@oss.qualcomm.com> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <99eb55a8-6370-bf7b-f9de-e88231454b0e@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 4/10/26 12:10, Vishnu Reddy wrote: > > On 4/8/2026 10:13 PM, Neil Armstrong wrote: >> Update the gen2 response and vdec s_fmt code to take in account >> the P010 and QC010 when calculating the width, height and stride. >> >> Signed-off-by: Neil Armstrong >> --- >>   .../platform/qcom/iris/iris_hfi_gen2_response.c     | 19 ++++++++++++++++--- >>   drivers/media/platform/qcom/iris/iris_vdec.c        | 21 ++++++++++++++++++--- >>   2 files changed, 34 insertions(+), 6 deletions(-) >> >> diff --git a/drivers/media/platform/qcom/iris/iris_hfi_gen2_response.c b/drivers/media/platform/qcom/iris/iris_hfi_gen2_response.c >> index 8e19f61bbbf9..d268149191ea 100644 >> --- a/drivers/media/platform/qcom/iris/iris_hfi_gen2_response.c >> +++ b/drivers/media/platform/qcom/iris/iris_hfi_gen2_response.c >> @@ -542,9 +542,22 @@ static void iris_hfi_gen2_read_input_subcr_params(struct iris_inst *inst) >>       pixmp_ip->width = width; >>       pixmp_ip->height = height; >> -    pixmp_op->width = ALIGN(width, 128); >> -    pixmp_op->height = ALIGN(height, 32); >> -    pixmp_op->plane_fmt[0].bytesperline = ALIGN(width, 128); >> +    pixmp_op->width = pixmp_op->pixelformat == V4L2_PIX_FMT_QC10C ? >> +        ALIGN(width, 192) : ALIGN(width, 128); >> +    pixmp_op->height = pixmp_op->pixelformat == V4L2_PIX_FMT_QC10C ? >> +        ALIGN(height, 16) : ALIGN(height, 32); >> +    switch (pixmp_op->pixelformat) { >> +    case V4L2_PIX_FMT_P010: >> +        pixmp_op->plane_fmt[0].bytesperline = ALIGN(width * 2, 256); >> +        break; >> +    case V4L2_PIX_FMT_QC10C: >> +        pixmp_op->plane_fmt[0].bytesperline = ALIGN(ALIGN(width, 192) * 4 / 3, 256); >> +        break; >> +    case V4L2_PIX_FMT_NV12: >> +    case V4L2_PIX_FMT_QC08C: >> +        pixmp_op->plane_fmt[0].bytesperline = ALIGN(width, 128); >> +        break; >> +    } >>       pixmp_op->plane_fmt[0].sizeimage = iris_get_buffer_size(inst, BUF_OUTPUT); >>       matrix_coeff = subsc_params.color_info & 0xFF; >> diff --git a/drivers/media/platform/qcom/iris/iris_vdec.c b/drivers/media/platform/qcom/iris/iris_vdec.c >> index 719217399a30..ca0518c27834 100644 >> --- a/drivers/media/platform/qcom/iris/iris_vdec.c >> +++ b/drivers/media/platform/qcom/iris/iris_vdec.c >> @@ -272,10 +272,25 @@ int iris_vdec_s_fmt(struct iris_inst *inst, struct v4l2_format *f) >>           fmt = inst->fmt_dst; >>           fmt->type = V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE; >>           fmt->fmt.pix_mp.pixelformat = f->fmt.pix_mp.pixelformat; >> -        fmt->fmt.pix_mp.width = ALIGN(f->fmt.pix_mp.width, 128); >> -        fmt->fmt.pix_mp.height = ALIGN(f->fmt.pix_mp.height, 32); >> +        codec_align = f->fmt.pix_mp.pixelformat == V4L2_PIX_FMT_QC10C ? 192 : 128; >> +        fmt->fmt.pix_mp.width = ALIGN(f->fmt.pix_mp.width, codec_align); >> +        codec_align = f->fmt.pix_mp.pixelformat == V4L2_PIX_FMT_QC10C ? 16 : 32; >> +        fmt->fmt.pix_mp.height = ALIGN(f->fmt.pix_mp.height, codec_align); >>           fmt->fmt.pix_mp.num_planes = 1; >> -        fmt->fmt.pix_mp.plane_fmt[0].bytesperline = ALIGN(f->fmt.pix_mp.width, 128); >> +        switch (f->fmt.pix_mp.pixelformat) { >> +        case V4L2_PIX_FMT_P010: >> +            fmt->fmt.pix_mp.plane_fmt[0].bytesperline = >> +                ALIGN(f->fmt.pix_mp.width * 2, 256); >> +            break; >> +        case V4L2_PIX_FMT_QC10C: >> +            fmt->fmt.pix_mp.plane_fmt[0].bytesperline = >> +                ALIGN(f->fmt.pix_mp.width * 4 / 3, 256); >> +            break; >> +        case V4L2_PIX_FMT_NV12: >> +        case V4L2_PIX_FMT_QC08C: >> +            fmt->fmt.pix_mp.plane_fmt[0].bytesperline = f->fmt.pix_mp.width; > In the removed code, bytesperline for NV12 and QC08C was aligned to 128 bytes. > In the new code, Is that alignment missed or not required? The alignment is done right before: codec_align = f->fmt.pix_mp.pixelformat == V4L2_PIX_FMT_QC10C ? 192 : 128; fmt->fmt.pix_mp.width = ALIGN(f->fmt.pix_mp.width, codec_align); calling ALIGN(f->fmt.pix_mp.width, 128) again is a no-op. Thanks, Neil >> +            break; >> +        } >>           fmt->fmt.pix_mp.plane_fmt[0].sizeimage = iris_get_buffer_size(inst, BUF_OUTPUT); >>           inst->buffers[BUF_OUTPUT].min_count = iris_vpu_buf_count(inst, BUF_OUTPUT); >>           inst->buffers[BUF_OUTPUT].size = fmt->fmt.pix_mp.plane_fmt[0].sizeimage; >>