Re: [PATCHv3 03/17] mm/ksm: Do not merge pages with different KeyIDs

Dave Hansen
2018-06-13T20:35:50Z

On 06/13/2018 01:31 PM, Kirill A. Shutemov wrote:
>> What actually happens without this patch in place?
>
> One of processes would get the page mapped with wrong KeyID and see
> garbage.

OK, but what about two pages with the same KeyID? It's actually totally
possible for KSM to determine that two pages have the same plaintext and
merge them. Why don't we do that?

> We setup mapping according to KeyID in vma->vm_page_prot.

Then why do we bother with page_keyid() and the page_ext stuff?