public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Nicolas Ferre <nicolas.ferre@microchip.com>
To: <linux-kernel@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>
Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>,
	Ludovic Desroches <ludovic.desroches@microchip.com>
Subject: Re: [PATCH] ARM: dts: at91: sama5d4_xplained: change the key code of the gpio key
Date: Tue, 27 Jul 2021 11:56:19 +0200	[thread overview]
Message-ID: <030d92ba-920a-4b8e-b48a-d722e8fbca90@microchip.com> (raw)
In-Reply-To: <20210727091351.44475-1-nicolas.ferre@microchip.com>

On 27/07/2021 at 11:13, nicolas.ferre@microchip.com wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> From: Ludovic Desroches <ludovic.desroches@microchip.com>
> 
> Having a button code and not a key code causes issues with libinput.
> udev won't set ID_INPUT_KEY. If it is forced, then it causes a bug
> within libinput.
> 
> Signed-off-by: Ludovic Desroches <ludovic.desroches@microchip.com>
> Signed-off-by: Nicolas Ferre <nicolas.ferre@microchip.com>

For the record: added to at91-dt for 5.15.

Regards,
   Nicolas

> ---
>   arch/arm/boot/dts/at91-sama5d4_xplained.dts | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/at91-sama5d4_xplained.dts b/arch/arm/boot/dts/at91-sama5d4_xplained.dts
> index 541779af049f..d241c24f0d83 100644
> --- a/arch/arm/boot/dts/at91-sama5d4_xplained.dts
> +++ b/arch/arm/boot/dts/at91-sama5d4_xplained.dts
> @@ -7,6 +7,7 @@
>    */
>   /dts-v1/;
>   #include "sama5d4.dtsi"
> +#include <dt-bindings/input/input.h>
> 
>   / {
>          model = "Atmel SAMA5D4 Xplained";
> @@ -250,7 +251,7 @@ gpio_keys {
>                  pb_user1 {
>                          label = "pb_user1";
>                          gpios = <&pioE 8 GPIO_ACTIVE_HIGH>;
> -                       linux,code = <0x100>;
> +                       linux,code = <KEY_PROG1>;
>                          wakeup-source;
>                  };
>          };
> --
> 2.32.0
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> 


-- 
Nicolas Ferre

      reply	other threads:[~2021-07-27  9:56 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-27  9:13 [PATCH] ARM: dts: at91: sama5d4_xplained: change the key code of the gpio key nicolas.ferre
2021-07-27  9:56 ` Nicolas Ferre [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=030d92ba-920a-4b8e-b48a-d722e8fbca90@microchip.com \
    --to=nicolas.ferre@microchip.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ludovic.desroches@microchip.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox