From: Vincent Whitchurch <Vincent.Whitchurch@axis.com>
To: "hch@lst.de" <hch@lst.de>
Cc: kernel <kernel@axis.com>,
"squashfs-devel@lists.sourceforge.net"
<squashfs-devel@lists.sourceforge.net>,
"pliard@google.com" <pliard@google.com>,
"phillip@squashfs.org.uk" <phillip@squashfs.org.uk>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] squashfs: cache partial compressed blocks
Date: Mon, 15 May 2023 12:31:49 +0000 [thread overview]
Message-ID: <031c4d99c2cd9870ca5ed0d7fef809d3f7c31381.camel@axis.com> (raw)
In-Reply-To: <20230515100352.GA24402@lst.de>
On Mon, 2023-05-15 at 12:03 +0200, Christoph Hellwig wrote:
> On Fri, May 12, 2023 at 03:18:05PM +0200, Vincent Whitchurch wrote:
> > static int squashfs_bio_read(struct super_block *sb, u64 index, int length,
> > struct bio **biop, int *block_offset)
> > {
> > struct squashfs_sb_info *msblk = sb->s_fs_info;
> > + struct inode *cache_inode = msblk->cache_inode;
> > + struct address_space *cache_mapping = cache_inode ? cache_inode->i_mapping : NULL;
>
> Unless I'm badly misreading the squashfs_fill_super changes,
> cache_inode can't ever be NULL here or anywhere else in the I/O
> code.
Hmm, in this patch, cache_inode is only created if devblksize is
PAGE_SIZE, so it could be NULL if CONFIG_SQUASHFS_4K_DEVBLK_SIZE is not
set (or if PAGE_SIZE is greater than 4 KiB), right?
I'll fix the rest of your comments in an upcoming v3. Thank you for the
review.
prev parent reply other threads:[~2023-05-15 12:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-12 13:18 [PATCH v2] squashfs: cache partial compressed blocks Vincent Whitchurch
2023-05-13 2:12 ` Phillip Lougher
2023-05-15 10:03 ` Christoph Hellwig
2023-05-15 12:31 ` Vincent Whitchurch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=031c4d99c2cd9870ca5ed0d7fef809d3f7c31381.camel@axis.com \
--to=vincent.whitchurch@axis.com \
--cc=akpm@linux-foundation.org \
--cc=hch@lst.de \
--cc=kernel@axis.com \
--cc=linux-kernel@vger.kernel.org \
--cc=phillip@squashfs.org.uk \
--cc=pliard@google.com \
--cc=squashfs-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox