public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Mikulas Patocka <mpatocka@redhat.com>
To: Mohammed Anees <pvmohammedanees2003@gmail.com>
Cc: snitzer@kernel.org, agk@redhat.com, dm-devel@lists.linux.dev,
	 linux-kernel@vger.kernel.org, zkabelac@redhat.com
Subject: Re: dm: Allow the use of escaped characters in str_field_delimit()
Date: Fri, 3 Jan 2025 17:21:13 +0100 (CET)	[thread overview]
Message-ID: <034eaa34-1737-6f75-2227-4e0dfbc753cf@redhat.com> (raw)
In-Reply-To: <20241215101336.1456-1-pvmohammedanees2003@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1141 bytes --]



On Sun, 15 Dec 2024, Mohammed Anees wrote:

> > It would seem Mohammed cared enough to write the patch, but not reply
> > to you with further clarification on why it needed...
> 
> I thought I had already replied to the concern, but it seems 
> the message didn’t get sent, apologies for that oversight!
> College academics kept me tied up, and I lost track of this,
> apologies once again.
> 
> > BUT, in this instance it follows that: if lvm2 is allowing weird names
> > which require escacped characters _and_ dm-init is used then dm-init
> > needs to support handling them (dm-init is all about _not_ using
> > normal initramfs with lvm2 in all its glory).
> 
> I completely agree with your point and am more than happy to 
> provide further details or make any additional updates to 
> the patch if needed, please let me know if anything else if needed. 
> Thank you for your time.
> 
> Regards
> Mohammed Anees

Hi

I don't want to bloat the code with the logic that no one uses. I would 
only accept the patch if there were some real scenario where you need to 
use escaped characters in device names or table parameters.

Mikulas

  reply	other threads:[~2025-01-03 16:21 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-12 17:57 [PATCH] dm: Allow the use of escaped characters in str_field_delimit() Mohammed Anees
2024-11-13 10:39 ` Zdenek Kabelac
2024-11-18 10:38 ` Mikulas Patocka
2024-12-10 16:25   ` Mike Snitzer
2024-12-15 10:13     ` Mohammed Anees
2025-01-03 16:21       ` Mikulas Patocka [this message]
2025-01-06 21:27         ` Mike Snitzer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=034eaa34-1737-6f75-2227-4e0dfbc753cf@redhat.com \
    --to=mpatocka@redhat.com \
    --cc=agk@redhat.com \
    --cc=dm-devel@lists.linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pvmohammedanees2003@gmail.com \
    --cc=snitzer@kernel.org \
    --cc=zkabelac@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox