From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8254F1FA8CF for ; Fri, 3 Jan 2025 16:21:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735921286; cv=none; b=F9FE0M3ZPHWIiHWi3JS8EojcYPszX6eyvP8Rpca/+X23D6Dr+oWuBV6wHbw7VJeI6kw51cVf1plcbv/j0Sln1lvToltN5lOiVfJ0mUPpJCB0KpbRH2Wcm3XKuwhw5UqqooiPGj4mXhZlqVAlov26s1Xleg3gWWxOAWJ0CABhIuI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735921286; c=relaxed/simple; bh=XtCxCsyFaT2aTAPEyVFYtq3CDfR/K9SGICq0OBCes0k=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References: MIME-Version:Content-Type; b=Rzr8suzg3o2kKcgEyxL9W4rPf9qxwMtJwYXKh5sZXK7LHVogjVfo82A/UUu9N7g928x2qi8L5FH6BDk66nYG9x8LKCc/jgOwYxOoIopYX5P2rVLmFZn71lrlbpyIkkgVSZ/en5ybOg4Zqn9d78+dr1nUi/UzojCCl8v+sRos/gw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=JeA2xLpq; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="JeA2xLpq" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1735921283; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=B8spL43ZQz2UCHW30ztMjR9tOsebXIHHpfJ2lMl5/sM=; b=JeA2xLpqIqvPOgOBNRQu/fRuMnyzU7+yj808SGxyMZ/JKgiGFvkQ0RNpkp5/3JsobkQY1x clEz5R1SrfNtZpGzxD7R7ii/91zoTxfoPXUep4w9r1a0B6/Yhzin0b/WI3BNixHJrWDZvH NSxgmg7ZUFu2gR5KYFc3Z2qAGOMFcBY= Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-661-7q5Sa6nQOFmzimpzQnZJ8g-1; Fri, 03 Jan 2025 11:21:19 -0500 X-MC-Unique: 7q5Sa6nQOFmzimpzQnZJ8g-1 X-Mimecast-MFC-AGG-ID: 7q5Sa6nQOFmzimpzQnZJ8g Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 3B42019560AE; Fri, 3 Jan 2025 16:21:18 +0000 (UTC) Received: from [10.45.224.27] (unknown [10.45.224.27]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 2F85B1955F41; Fri, 3 Jan 2025 16:21:15 +0000 (UTC) Date: Fri, 3 Jan 2025 17:21:13 +0100 (CET) From: Mikulas Patocka To: Mohammed Anees cc: snitzer@kernel.org, agk@redhat.com, dm-devel@lists.linux.dev, linux-kernel@vger.kernel.org, zkabelac@redhat.com Subject: Re: dm: Allow the use of escaped characters in str_field_delimit() In-Reply-To: <20241215101336.1456-1-pvmohammedanees2003@gmail.com> Message-ID: <034eaa34-1737-6f75-2227-4e0dfbc753cf@redhat.com> References: <20241215101336.1456-1-pvmohammedanees2003@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="-1463811712-1776060455-1735921277=:187354" X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. ---1463811712-1776060455-1735921277=:187354 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT On Sun, 15 Dec 2024, Mohammed Anees wrote: > > It would seem Mohammed cared enough to write the patch, but not reply > > to you with further clarification on why it needed... > > I thought I had already replied to the concern, but it seems > the message didn’t get sent, apologies for that oversight! > College academics kept me tied up, and I lost track of this, > apologies once again. > > > BUT, in this instance it follows that: if lvm2 is allowing weird names > > which require escacped characters _and_ dm-init is used then dm-init > > needs to support handling them (dm-init is all about _not_ using > > normal initramfs with lvm2 in all its glory). > > I completely agree with your point and am more than happy to > provide further details or make any additional updates to > the patch if needed, please let me know if anything else if needed. > Thank you for your time. > > Regards > Mohammed Anees Hi I don't want to bloat the code with the logic that no one uses. I would only accept the patch if there were some real scenario where you need to use escaped characters in device names or table parameters. Mikulas ---1463811712-1776060455-1735921277=:187354--