From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753242AbcIMMfi (ORCPT ); Tue, 13 Sep 2016 08:35:38 -0400 Received: from mx07-00178001.pphosted.com ([62.209.51.94]:24937 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750747AbcIMMff (ORCPT ); Tue, 13 Sep 2016 08:35:35 -0400 Subject: Re: [PATCH v5 5/9] Documentation: dt-bindings: Add IRQ related properties of STM32 pinctrl To: Linus Walleij References: <1473432124-6784-1-git-send-email-alexandre.torgue@st.com> <1473432124-6784-6-git-send-email-alexandre.torgue@st.com> CC: Maxime Coquelin , Thomas Gleixner , Jason Cooper , Marc Zyngier , Mark Rutland , Rob Herring , "linux-gpio@vger.kernel.org" , Arnd Bergmann , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , Daniel Thompson , Bruno Herrera , Lee Jones From: Alexandre Torgue Message-ID: <0359b2c7-cda5-b744-7051-4b19af0fcfcd@st.com> Date: Tue, 13 Sep 2016 14:34:48 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.48.0.2] X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-09-13_08:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Linus, On 09/13/2016 10:18 AM, Linus Walleij wrote: > On Fri, Sep 9, 2016 at 4:42 PM, Alexandre TORGUE > wrote: > >> Signed-off-by: Maxime Coquelin >> Acked-by: Rob Herring >> Signed-off-by: Alexandre TORGUE >> >> diff --git a/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.txt b/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.txt >> index 587bffb..a0eed99 100644 >> --- a/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.txt >> +++ b/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.txt >> @@ -14,6 +14,9 @@ Required properies: >> - #size-cells : The value of this property must be 1 >> - ranges : defines mapping between pin controller node (parent) to >> gpio-bank node (children). >> + - interrupt-parent: phandle of the interrupt parent to which the external >> + GPIO interrupts are forwarded to. >> + - st,syscfg: phandle of the syscfg node used for IRQ mux selection. > > Actually this doc is incomplete. > > This is a phandle + offset, not just a phandle. > > It is a small detail so I don't care much, either send a patch to > fix up this doc (I have already merged it) or patch the driver > to not retrieve the offset and instead use > #define SYSCFG_OFFSET 0x08 > or something... I'll send a patch for Documentation. Do I need to wait this series is officially released (4.9-rc1) or can I send it now ? Regards Alex > > Yours, > Linus Walleij >