From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-174.mta1.migadu.com (out-174.mta1.migadu.com [95.215.58.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1AE6F276049 for ; Mon, 23 Feb 2026 05:52:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771825929; cv=none; b=KGLBQs0zELGUqBCQip/BmfvbO9+l50k8hZLeiMXqf3e8Gu1HSpsddVIRfrhydcvv9yum00xiMzGNKTnYNkbTfB/7uAyf/UoP7D08KkIhW2pERtqpinRwmNRlIbdEBu6jgLoR2xr0zd/GgcPhEHOxyq33PpFo2/UTu+vz3Gt8fa0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771825929; c=relaxed/simple; bh=tsZGinYTxVCG2zJ3moSLeuEmyjM7gf3z0x3YYcIfbrA=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=TuPIRa+x1qnwF7k57JdlyI1i++l2WtGk4EgaK7VzpGzGiyGlIzo/CY6b1xW9QGPqLv1zgvQH3XloY+yc05KRh8nWHQzlv+ENvi2d7sRgmkicHiwDcGsnGqGwzLYif5LqU/v6gIFJSaraSR1IGOR/ja1HjAPZdxgwAuu8Hs2g/R0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=packett.cool; spf=pass smtp.mailfrom=packett.cool; dkim=pass (2048-bit key) header.d=packett.cool header.i=@packett.cool header.b=hwWpglky; arc=none smtp.client-ip=95.215.58.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=packett.cool Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=packett.cool Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=packett.cool header.i=@packett.cool header.b="hwWpglky" Message-ID: <0397c453-e1ec-44a2-bf8f-a64347882226@packett.cool> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=packett.cool; s=key1; t=1771825916; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+etr68lQ0tf0G/csmk5P+HHB4sPoSNbI0nyD3l2haC4=; b=hwWpglkygVTXhSltG6Fky+5cXje7fl/xTQU4EPRyZFaKwZ+gfHQ7CJ7XdnaY3IFu+iteyO PEnQbOX2wZ916Q5zlC6WAl7m/rW4Qp7OeD160O2BMbxreAzAKhXkadMuA5GGMPXdpIr1b2 2CfpLyS74zbxGiub6PKDrTu2P0VuyAvX7W5/5mFH5KlaKW0l80dHk1dwXQ+Tn/FDCDdAeJ B+SqeaQ6imww07TqAN3xnYZ/8Azk67Pndln5Ycfs9doJeHo3HSWhSiSo/0vCNoFvg0QI75 IXNwE6xupJxpebJaZT2ZnWsRRJ0DddNbEGYmnRxQWj8xQ7Z8FVVWqcUzoJsYUQ== Date: Mon, 23 Feb 2026 02:51:44 -0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Val Packett Subject: Re: [PATCH] arm64: dts: qcom: hamoa/x1: Fix TODO in system power domain node To: "Maulik Shah (mkshah)" , Daniel J Blueman , Konrad Dybcio Cc: Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, stable@kernel.org References: <20260221105245.19328-1-daniel@quora.org> <9defac59-ae8a-4658-ab38-dcb0559d9708@oss.qualcomm.com> Content-Language: en-US In-Reply-To: <9defac59-ae8a-4658-ab38-dcb0559d9708@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT On 2/23/26 1:11 AM, Maulik Shah (mkshah) wrote: > On 2/21/2026 4:21 PM, Daniel J Blueman wrote: [..] >> Fix this by using the CPU C4, cluster CL5 and system DRIPS parameters from the ACPI DSDT Windows uses, together with the Low Power Idle _LPI minimum residency of 9000us and wake latency of 5000us as exit latency. Finally, assume the entry latency is the difference of these two values. [..] >> Fixes: f33767e3cfa5 ("arm64: dts: qcom: x1e80100: Add missing system-wide PSCI power domain") > Using this fixes tag, can make the change back ported to stable kernels without dependencies and may break the GPIO IRQs. > > Background: > > PDC monitors the wakeup capable IRQs during system wide low power state, hitting the system low power mode can break to wake via GPIO IRQs. > The system-wide idle state was not added since the wakeup capable GPIO IRQs were not configured at PDC with 602cb14e310a > ("pinctrl: qcom: x1e80100: Bypass PDC wakeup parent for now"). > > So IMO this fixes tag should be used instead of above with the changes to configure PDC to monitor GPIO wake ups. > I have these changes to configure GPIO IRQs at PDC and enable back domain_ss3 idle state in my local tree, which i plan to > post this week or next. On a previous episode of L-K-M-L… :) https://lore.kernel.org/all/0c8735f9-eac0-449c-aa95-b82cec0e6cb2@oss.qualcomm.com/ FWIW I have just tested Konrad's patch from there that adds all three states (0x02000154, 0x02000254, and 0x0200c354): ❯ doas cat /sys/kernel/debug/pm_genpd/power-domain-system/idle_states State  Time(ms)       Usage      Rejected   Above      Below S2idle S0     367            330        9          315        9 0 S1     2719           2057       553        2520       71  0 S2     0              0          1          1          0 0 As of right now I don't see any improvement in idle power consumption from just this S1 thing, compared to not adding anything and having the implicitly-added-by-code S0 state only. It still only goes as low as 2.5W in screen-off idle, and that's with runtime PM enabled for 3 USB controllers out of 4 (enabling it on all 4 makes the system shut down), without doing that it's more like 2.75W. --- Maulik, since you seem to be the oss.qualcomm person familiar with power management — could you please shine some light onto the mystery of how Windows achieves ~0.5W battery consumption in screen-off idle (and only slightly higher in screen-on idle) i.e. what exactly could be wasting those extra 2W under Linux? Ever since people started daily driving X series based laptops this has been an eternal topic/question in aarch64-laptops… Is it just Windows doing something "extraordinary" like opportunistic full-system sleep (as deep as CX collapse), even with display on and in PSR? Or are we still missing something big in Linux? That issue with runtime-suspending all four USB controllers shutting the system down, does that mean there's some rail where USB ends up being the last load-bearing thing holding it up and we'd like to let it go down properly? Thanks ~val