From: "Stephen Hemminger" <stephen@networkplumber.org>
To: "'Joshua R. Poulson'" <jrp@pun.org>
Cc: "'K. Y. Srinivasan'" <kys@exchange.microsoft.com>,
"'KY Srinivasan'" <kys@microsoft.com>,
<gregkh@linuxfoundation.org>, <linux-kernel@vger.kernel.org>,
<devel@linuxdriverproject.org>, <olaf@aepfle.de>,
"'Andy Whitcroft'" <apw@canonical.com>,
"'Vitaly Kuznetsov'" <vkuznets@redhat.com>, <jasowang@redhat.com>,
"'Leann Ogasawara'" <leann.ogasawara@canonical.com>,
"'Marcelo Henrique Cerri'" <marcelo.cerri@canonical.com>,
"'Stephen Hemminger'" <sthemmin@microsoft.com>,
"'Michael Kelley'" <mhkelley@outlook.com>,
"'Stable'" <stable@vger.kernel.org>
Subject: RE: [PATCH 1/1] Drivers: hv: vmbus: Fix ring buffer signaling
Date: Wed, 28 Mar 2018 16:25:11 -0700 [thread overview]
Message-ID: <03e101d3c6ec$05828e20$1087aa60$@networkplumber.org> (raw)
In-Reply-To: <CABHrTi+pMjYX4jqaaXS=X02o7CbWBqdMMwcyrxo=BywV18n7WQ@mail.gmail.com>
Thanks, I hadn't updated to rc7 yet
-----Original Message-----
From: Joshua R. Poulson <jrp@pun.org>
Sent: Wednesday, March 28, 2018 12:18 PM
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: K. Y. Srinivasan <kys@exchange.microsoft.com>; KY Srinivasan <kys@microsoft.com>; gregkh@linuxfoundation.org; linux-kernel@vger.kernel.org; devel@linuxdriverproject.org; olaf@aepfle.de; Andy Whitcroft <apw@canonical.com>; Vitaly Kuznetsov <vkuznets@redhat.com>; jasowang@redhat.com; Leann Ogasawara <leann.ogasawara@canonical.com>; Marcelo Henrique Cerri <marcelo.cerri@canonical.com>; Stephen Hemminger <sthemmin@microsoft.com>; Michael Kelley <mhkelley@outlook.com>; Stable <stable@vger.kernel.org>
Subject: Re: [PATCH 1/1] Drivers: hv: vmbus: Fix ring buffer signaling
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?h=v4.16-rc7&id=655296c8bbeffcf020558c4455305d597a73bde1
On Wed, Mar 28, 2018 at 12:01 PM, Stephen Hemminger
<stephen@networkplumber.org> wrote:
> On Sun, 4 Mar 2018 22:24:08 -0700
> kys@exchange.microsoft.com wrote:
>
>> From: Michael Kelley <mhkelley@outlook.com>
>>
>> Fix bugs in signaling the Hyper-V host when freeing space in the
>> host->guest ring buffer:
>>
>> 1. The interrupt_mask must not be used to determine whether to signal
>> on the host->guest ring buffer
>> 2. The ring buffer write_index must be read (via hv_get_bytes_to_write)
>> *after* pending_send_sz is read in order to avoid a race condition
>> 3. Comparisons with pending_send_sz must treat the "equals" case as
>> not-enough-space
>> 4. Don't signal if the pending_send_sz feature is not present. Older
>> versions of Hyper-V that don't implement this feature will poll.
>>
>> Fixes: 03bad714a161 ("vmbus: more host signalling avoidance")
>>
>> Cc: Stable <stable@vger.kernel.org> # 4.14 and above
>> Signed-off-by: Michael Kelley <mhkelley@outlook.com>
>> Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
>
> What ever happened to this patch? It doesn't seem to be in char-misc, upstream,
> or stable kernel tree yet.
>
>
next prev parent reply other threads:[~2018-03-28 23:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-05 5:24 [PATCH 1/1] Drivers: hv: vmbus: Fix ring buffer signaling kys
2018-03-28 19:01 ` Stephen Hemminger
2018-03-28 19:18 ` Joshua R. Poulson
2018-03-28 23:25 ` Stephen Hemminger [this message]
2018-03-29 7:24 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='03e101d3c6ec$05828e20$1087aa60$@networkplumber.org' \
--to=stephen@networkplumber.org \
--cc=apw@canonical.com \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=jasowang@redhat.com \
--cc=jrp@pun.org \
--cc=kys@exchange.microsoft.com \
--cc=kys@microsoft.com \
--cc=leann.ogasawara@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.cerri@canonical.com \
--cc=mhkelley@outlook.com \
--cc=olaf@aepfle.de \
--cc=stable@vger.kernel.org \
--cc=sthemmin@microsoft.com \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox