Re: [PATCH v2 19/22] rv: Add rtapp_pagefault monitor

Nam Cao
2025-04-15T12:38:12Z

On Tue, Apr 15, 2025 at 02:31:43PM +0200, Gabriele Monaco wrote:
> On Fri, 2025-04-11 at 09:37 +0200, Nam Cao wrote:
> > +static int __init register_pagefault(void)
> > +{
> > + rv_register_monitor(&rv_pagefault, &rv_rtapp);
> > + return 0;
>
> Any reason why you aren't returning the error value from the monitor
> registration?

Copy-paste from dot2k :P

> Other than that, the monitor seems neat and reasonably easy to
> generate.
>
> May not be necessary in this series, but try to keep compatibility with
> the userspace RV tool as well, you need to have some special case in
> its tracing components because fields are not matching:
> # rv mon sleep -t
> rcuc/11-108 [011] event <CANT FIND FIELD final_state>
> (null) x (null) -> (null) Y
> rcuc/11-108 [011] event <CANT FIND FIELD final_state>
> (null) x (null) -> (null) Y
> ktimers/11-109 [011] event <CANT FIND FIELD final_state>
> (null) x (null) -> (null) Y

I have this userspace RV tool in my "later" TODO list, if that's okay.

Honestly, I haven't looked at what it does yet. perf already does what I
need.

Best regards,
Nam