From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934216AbdERP3V convert rfc822-to-8bit (ORCPT ); Thu, 18 May 2017 11:29:21 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50228 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933992AbdERP3S (ORCPT ); Thu, 18 May 2017 11:29:18 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 870E8C04B92C Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=longman@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 870E8C04B92C Subject: Re: [RFC PATCH v2 08/17] cgroup: Move debug cgroup to its own file To: Tejun Heo References: <1494855256-12558-1-git-send-email-longman@redhat.com> <1494855256-12558-9-git-send-email-longman@redhat.com> <20170517213603.GE942@htj.duckdns.org> Cc: Li Zefan , Johannes Weiner , Peter Zijlstra , Ingo Molnar , cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, kernel-team@fb.com, pjt@google.com, luto@amacapital.net, efault@gmx.de From: Waiman Long Organization: Red Hat Message-ID: <03fe182f-92d5-0996-2d9c-d92c878dce35@redhat.com> Date: Thu, 18 May 2017 11:29:10 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170517213603.GE942@htj.duckdns.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8BIT X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Thu, 18 May 2017 15:29:13 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/17/2017 05:36 PM, Tejun Heo wrote: > Hello, Waiman. > > On Mon, May 15, 2017 at 09:34:07AM -0400, Waiman Long wrote: >> The debug cgroup currently resides within cgroup-v1.c and is enabled >> only for v1 cgroup. To enable the debug cgroup also for v2, it >> makes sense to put the code into its own file as it will no longer >> be v1 specific. The only change in this patch is the expansion of >> cgroup_task_count() within the debug_taskcount_read() function. >> >> Signed-off-by: Waiman Long > I don't mind enabling the debug controller for v2 but let's please > hide it behind an unwieldy boot param / controller name so that it's > clear that its interface isn't expected to be stable. > > Thanks. > The controller name is "debug". So it is pretty obvious what it is for. However, the config prompt of "Example controller" is indeed a bit vague. So I think we can make the prompt more descriptive here. As for boot param, are you saying something like "cgroup_debug" has to be specified in the command line also to have this controller activated even if the CGROUP_DEBUG config parameter is specified? I am fine with that if you think it is necessary. Regards, Longman