Re: [PATCH v5 0/2] sched/numa: introduce numa locality

王贇
2019-12-10T02:22:05Z

Hi Peter, Ingo

We have reformed the implementation for several times, now it's very
simple and easy to use, there are also a document to guide admin on
how to use not only the NUMA locality, but also other per-cgroup NUMA
statistics, we hope this could make things easier for other NUMA users.

As now there are no more comments, would you please take a look at this
patch set, see if it's good enough to be picked?

Regards,
Michael Wang

On 2019/12/5 下午2:53, 王贇 wrote:
> Since v4:
> * improved documentation
> Since v3:
> * fix comments and improved documentation
> Since v2:
> * simplified the locality concept & implementation
> Since v1:
> * improved documentation
>
> Modern production environment could use hundreds of cgroup to control
> the resources for different workloads, along with the complicated
> resource binding.
>
> On NUMA platforms where we have multiple nodes, things become even more
> complicated, we hope there are more local memory access to improve the
> performance, and NUMA Balancing keep working hard to achieve that,
> however, wrong memory policy or node binding could easily waste the
> effort, result a lot of remote page accessing.
>
> We need to notice such problems, then we got chance to fix it before
> there are too much damages, however, there are no good monitoring
> approach yet to help catch the mouse who introduced the remote access.
>
> This patch set is trying to fill in the missing pieces， by introduce
> the per-cgroup NUMA locality info, with this new statistics, we could
> achieve the daily monitoring on NUMA efficiency, to give warning when
> things going too wrong.
>
> Please check the second patch for more details.
>
> Michael Wang (2):
> sched/numa: introduce per-cgroup NUMA locality info
> sched/numa: documentation for per-cgroup numa statistics
>
> Documentation/admin-guide/cg-numa-stat.rst | 178 ++++++++++++++++++++++++
> Documentation/admin-guide/index.rst | 1 +
> Documentation/admin-guide/kernel-parameters.txt | 4 +
> Documentation/admin-guide/sysctl/kernel.rst | 9 ++
> include/linux/sched.h | 15 ++
> include/linux/sched/sysctl.h | 6 +
> init/Kconfig | 11 ++
> kernel/sched/core.c | 75 ++++++++++
> kernel/sched/fair.c | 62 +++++++++
> kernel/sched/sched.h | 12 ++
> kernel/sysctl.c | 11 ++
> 11 files changed, 384 insertions(+)
> create mode 100644 Documentation/admin-guide/cg-numa-stat.rst
>