Re: [PATCH v4 1/2] sched/numa: introduce per-cgroup NUMA locality info

Randy Dunlap
2019-12-05T03:29:52Z

On 12/4/19 7:28 PM, Randy Dunlap wrote:
> Hi,
>
> It seems that you missed my previous comments...
>
>
> On 12/3/19 11:59 PM, 王贇 wrote:
>> diff --git a/init/Kconfig b/init/Kconfig
>> index 4d8d145c41d2..fb7182a0d017 100644
>> --- a/init/Kconfig
>> +++ b/init/Kconfig
>> @@ -817,6 +817,15 @@ config NUMA_BALANCING_DEFAULT_ENABLED
>> If set, automatic NUMA balancing will be enabled if running on a NUMA
>> machine.
>>
>> +config CGROUP_NUMA_LOCALITY
>> + bool "The per-cgroup NUMA Locality"
>
> Drop "The"
>
>> + default n
>> + depends on CGROUP_SCHED && NUMA_BALANCING
>> + help
>> + This option enable the collection of per-cgroup NUMA locality info,
>
> enables
>
>> + to tell whether NUMA Balancing is working well for a particular
>> + workload, also imply the NUMA efficiency.
>> +
>> menuconfig CGROUPS
>> bool "Control Group support"
>> select KERNFS
>
>
> thanks.
>

Ah, the changes are in patch 2/2/ for some reason. OK, thanks.

--
~Randy