From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6F89C43387 for ; Fri, 4 Jan 2019 16:58:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7B2AC21872 for ; Fri, 4 Jan 2019 16:58:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728090AbfADQ6l (ORCPT ); Fri, 4 Jan 2019 11:58:41 -0500 Received: from gateway23.websitewelcome.com ([192.185.49.60]:31900 "EHLO gateway23.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726303AbfADQ6l (ORCPT ); Fri, 4 Jan 2019 11:58:41 -0500 Received: from cm17.websitewelcome.com (cm17.websitewelcome.com [100.42.49.20]) by gateway23.websitewelcome.com (Postfix) with ESMTP id 4740FCA24 for ; Fri, 4 Jan 2019 10:58:40 -0600 (CST) Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with SMTP id fSnwgSYo290onfSnwgxWId; Fri, 04 Jan 2019 10:58:40 -0600 X-Authority-Reason: nr=8 Received: from [189.250.130.205] (port=43414 helo=[192.168.43.131]) by gator4166.hostgator.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.91) (envelope-from ) id 1gfSnv-0004fh-EQ; Fri, 04 Jan 2019 10:58:39 -0600 Subject: Re: [PATCH v2] drm/amdgpu_vm: fix boolean expressions To: Ezequiel Garcia Cc: Felix Kuehling , Harish Kasiviswanathan , Alex Deucher , =?UTF-8?Q?Christian_K=c3=b6nig?= , "David (ChunMing) Zhou" , David Airlie , Daniel Vetter , amd-gfx@lists.freedesktop.org, dri-devel , Linux Kernel Mailing List References: <20190103200146.GA26442@embeddedor> From: "Gustavo A. R. Silva" Message-ID: <040f2122-cd83-effb-3f1e-2c5755aece2a@embeddedor.com> Date: Fri, 4 Jan 2019 10:58:28 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 189.250.130.205 X-Source-L: No X-Exim-ID: 1gfSnv-0004fh-EQ X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: ([192.168.43.131]) [189.250.130.205]:43414 X-Source-Auth: gustavo@embeddedor.com X-Email-Count: 15 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Ezequiel, On 1/4/19 10:40 AM, Ezequiel Garcia wrote: > Hey Gustavo, > > On Thu, 3 Jan 2019 at 17:25, Gustavo A. R. Silva wrote: >> >> Fix boolean expressions by using logical AND operator '&&' >> instead of bitwise operator '&'. >> >> This issue was detected with the help of Coccinelle. >> >> Fixes: 9a4b7d4c769e ("drm/amdgpu: Add vm context module param") >> Cc: stable@vger.kernel.org >> Reviewed-by: Felix Kuehling >> Signed-off-by: Gustavo A. R. Silva >> --- >> Changes in v2: >> - Update Fixes tag. >> > > This just fixes a user warning that would be wrongly reported, but > doesn't fix any other issue. > > Why stable? > Yeah. In this case the tag can be removed. Happy new year. Thanks -- Gustavo