* [PATCH 01/22] IB/sa : Remove deprecated create_singlethread_workqueue
2016-08-15 17:57 [PATCH 00/22] Remove deprecated create_workqueue instances Bhaktipriya Shridhar
@ 2016-08-15 17:57 ` Bhaktipriya Shridhar
2016-08-15 17:58 ` [PATCH 02/22] IB/mad: " Bhaktipriya Shridhar
` (23 subsequent siblings)
24 siblings, 0 replies; 38+ messages in thread
From: Bhaktipriya Shridhar @ 2016-08-15 17:57 UTC (permalink / raw)
To: Yishai Hadas, Doug Ledford, Sean Hefty, Hal Rosenstock,
Jason Gunthorpe, Leon Romanovsky, Chuck Lever, Mark Bloch,
Hans Westgaard Ry, Christoph Lameter, Erez Shitrit, Haggai Eran,
Florian Westphal, Guy Shapiro, Eli Cohen, Or Gerlitz,
Faisal Latif, Matan Barak, Chien Tin Tung, Mustafa Ismail,
Shiraz Saleem, Tatyana Nikolova, Steve Wise, Mike Marciniszyn,
Bart Van Assche, Yotam Kenneth, Somnath Kotur, Moni Shoua,
Shachar Raindel, Parav Pandit, Sagi Grimberg, Christoph Hellwig,
Dean Luick, Ira Weiny, Kaike Wan
Cc: linux-rdma, linux-kernel, Tejun Heo
alloc_ordered_workqueue() with WQ_MEM_RECLAIM set, replaces
deprecated create_singlethread_workqueue(). This is the identity
conversion.
The workqueue "ib_nl" queues work item &ib_nl_timed_work. It has been
identity converted.
WQ_MEM_RECLAIM has been set to ensure forward progress under memory
pressure.
Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
---
drivers/infiniband/core/sa_query.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/infiniband/core/sa_query.c b/drivers/infiniband/core/sa_query.c
index e955386..6559199 100644
--- a/drivers/infiniband/core/sa_query.c
+++ b/drivers/infiniband/core/sa_query.c
@@ -1974,7 +1974,7 @@ int ib_sa_init(void)
goto err2;
}
- ib_nl_wq = create_singlethread_workqueue("ib_nl_sa_wq");
+ ib_nl_wq = alloc_ordered_workqueue("ib_nl_sa_wq", WQ_MEM_RECLAIM);
if (!ib_nl_wq) {
ret = -ENOMEM;
goto err3;
--
2.1.4
^ permalink raw reply related [flat|nested] 38+ messages in thread* [PATCH 02/22] IB/mad: Remove deprecated create_singlethread_workqueue
2016-08-15 17:57 [PATCH 00/22] Remove deprecated create_workqueue instances Bhaktipriya Shridhar
2016-08-15 17:57 ` [PATCH 01/22] IB/sa : Remove deprecated create_singlethread_workqueue Bhaktipriya Shridhar
@ 2016-08-15 17:58 ` Bhaktipriya Shridhar
2016-08-15 17:58 ` [PATCH 03/22] IB/multicast: " Bhaktipriya Shridhar
` (22 subsequent siblings)
24 siblings, 0 replies; 38+ messages in thread
From: Bhaktipriya Shridhar @ 2016-08-15 17:58 UTC (permalink / raw)
To: Yishai Hadas, Doug Ledford, Sean Hefty, Hal Rosenstock,
Jason Gunthorpe, Leon Romanovsky, Chuck Lever, Mark Bloch,
Hans Westgaard Ry, Christoph Lameter, Erez Shitrit, Haggai Eran,
Florian Westphal, Guy Shapiro, Eli Cohen, Or Gerlitz,
Faisal Latif, Matan Barak, Chien Tin Tung, Mustafa Ismail,
Shiraz Saleem, Tatyana Nikolova, Steve Wise, Mike Marciniszyn,
Bart Van Assche, Yotam Kenneth, Somnath Kotur, Moni Shoua,
Shachar Raindel, Parav Pandit, Sagi Grimberg, Christoph Hellwig,
Dean Luick, Ira Weiny, Kaike Wan
Cc: linux-rdma, linux-kernel, Tejun Heo
The workqueue "ib_nl" queues work items &ib_nl_timed_work and
&mad_agent_priv->local_work. It has been identity converted.
WQ_MEM_RECLAIM has been set to ensure forward progress under
memory pressure.
Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
---
drivers/infiniband/core/mad.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/infiniband/core/mad.c b/drivers/infiniband/core/mad.c
index 2d49228..d882868 100644
--- a/drivers/infiniband/core/mad.c
+++ b/drivers/infiniband/core/mad.c
@@ -3177,7 +3177,7 @@ static int ib_mad_port_open(struct ib_device *device,
goto error7;
snprintf(name, sizeof name, "ib_mad%d", port_num);
- port_priv->wq = create_singlethread_workqueue(name);
+ port_priv->wq = alloc_ordered_workqueue(name, WQ_MEM_RECLAIM);
if (!port_priv->wq) {
ret = -ENOMEM;
goto error8;
--
2.1.4
^ permalink raw reply related [flat|nested] 38+ messages in thread* [PATCH 03/22] IB/multicast: Remove deprecated create_singlethread_workqueue
2016-08-15 17:57 [PATCH 00/22] Remove deprecated create_workqueue instances Bhaktipriya Shridhar
2016-08-15 17:57 ` [PATCH 01/22] IB/sa : Remove deprecated create_singlethread_workqueue Bhaktipriya Shridhar
2016-08-15 17:58 ` [PATCH 02/22] IB/mad: " Bhaktipriya Shridhar
@ 2016-08-15 17:58 ` Bhaktipriya Shridhar
2016-08-15 17:59 ` [PATCH 04/22] IB/ucma: " Bhaktipriya Shridhar
` (21 subsequent siblings)
24 siblings, 0 replies; 38+ messages in thread
From: Bhaktipriya Shridhar @ 2016-08-15 17:58 UTC (permalink / raw)
To: Yishai Hadas, Doug Ledford, Sean Hefty, Hal Rosenstock,
Jason Gunthorpe, Leon Romanovsky, Chuck Lever, Mark Bloch,
Hans Westgaard Ry, Christoph Lameter, Erez Shitrit, Haggai Eran,
Florian Westphal, Guy Shapiro, Eli Cohen, Or Gerlitz,
Faisal Latif, Matan Barak, Chien Tin Tung, Mustafa Ismail,
Shiraz Saleem, Tatyana Nikolova, Steve Wise, Mike Marciniszyn,
Bart Van Assche, Yotam Kenneth, Somnath Kotur, Moni Shoua,
Shachar Raindel, Parav Pandit, Sagi Grimberg, Christoph Hellwig,
Dean Luick, Ira Weiny, Kaike Wan
Cc: linux-rdma, linux-kernel, Tejun Heo
alloc_ordered_workqueue() with WQ_MEM_RECLAIM set, replaces
deprecated create_singlethread_workqueue(). This is the identity
conversion.
The workqueue "mcast_wq" queues work item &group->work. It has been
identity converted.
WQ_MEM_RECLAIM has been set to ensure forward progress under
memory pressure.
Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
---
drivers/infiniband/core/multicast.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/infiniband/core/multicast.c b/drivers/infiniband/core/multicast.c
index a83ec28..002a85c 100644
--- a/drivers/infiniband/core/multicast.c
+++ b/drivers/infiniband/core/multicast.c
@@ -894,7 +894,7 @@ int mcast_init(void)
{
int ret;
- mcast_wq = create_singlethread_workqueue("ib_mcast");
+ mcast_wq = alloc_ordered_workqueue("ib_mcast", WQ_MEM_RECLAIM);
if (!mcast_wq)
return -ENOMEM;
--
2.1.4
^ permalink raw reply related [flat|nested] 38+ messages in thread* [PATCH 04/22] IB/ucma: Remove deprecated create_singlethread_workqueue
2016-08-15 17:57 [PATCH 00/22] Remove deprecated create_workqueue instances Bhaktipriya Shridhar
` (2 preceding siblings ...)
2016-08-15 17:58 ` [PATCH 03/22] IB/multicast: " Bhaktipriya Shridhar
@ 2016-08-15 17:59 ` Bhaktipriya Shridhar
2016-08-15 17:59 ` [PATCH 05/22] IB/cma: " Bhaktipriya Shridhar
` (20 subsequent siblings)
24 siblings, 0 replies; 38+ messages in thread
From: Bhaktipriya Shridhar @ 2016-08-15 17:59 UTC (permalink / raw)
To: Yishai Hadas, Doug Ledford, Sean Hefty, Hal Rosenstock,
Jason Gunthorpe, Leon Romanovsky, Chuck Lever, Mark Bloch,
Hans Westgaard Ry, Christoph Lameter, Erez Shitrit, Haggai Eran,
Florian Westphal, Guy Shapiro, Eli Cohen, Or Gerlitz,
Faisal Latif, Matan Barak, Chien Tin Tung, Mustafa Ismail,
Shiraz Saleem, Tatyana Nikolova, Steve Wise, Mike Marciniszyn,
Bart Van Assche, Yotam Kenneth, Somnath Kotur, Moni Shoua,
Shachar Raindel, Parav Pandit, Sagi Grimberg, Christoph Hellwig,
Dean Luick, Ira Weiny, Kaike Wan
Cc: linux-rdma, linux-kernel, Tejun Heo
alloc_ordered_workqueue() with WQ_MEM_RECLAIM set, replaces
deprecated create_singlethread_workqueue(). This is the identity
conversion.
The workqueue "close_wq" queues work items &ctx->close_work (maps to
ucma_close_id) and &con_req_eve->close_work (maps to
ucma_close_event_id). It has been identity converted.
WQ_MEM_RECLAIM has been set to ensure forward progress under
memory pressure.
Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
---
drivers/infiniband/core/ucma.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/infiniband/core/ucma.c b/drivers/infiniband/core/ucma.c
index c0f3826..9045387 100644
--- a/drivers/infiniband/core/ucma.c
+++ b/drivers/infiniband/core/ucma.c
@@ -1628,7 +1628,8 @@ static int ucma_open(struct inode *inode, struct file *filp)
if (!file)
return -ENOMEM;
- file->close_wq = create_singlethread_workqueue("ucma_close_id");
+ file->close_wq = alloc_ordered_workqueue("ucma_close_id",
+ WQ_MEM_RECLAIM);
if (!file->close_wq) {
kfree(file);
return -ENOMEM;
--
2.1.4
^ permalink raw reply related [flat|nested] 38+ messages in thread* [PATCH 05/22] IB/cma: Remove deprecated create_singlethread_workqueue
2016-08-15 17:57 [PATCH 00/22] Remove deprecated create_workqueue instances Bhaktipriya Shridhar
` (3 preceding siblings ...)
2016-08-15 17:59 ` [PATCH 04/22] IB/ucma: " Bhaktipriya Shridhar
@ 2016-08-15 17:59 ` Bhaktipriya Shridhar
2016-08-16 18:21 ` Steve Wise
2016-08-15 18:00 ` [PATCH 06/22] IB/addr: " Bhaktipriya Shridhar
` (19 subsequent siblings)
24 siblings, 1 reply; 38+ messages in thread
From: Bhaktipriya Shridhar @ 2016-08-15 17:59 UTC (permalink / raw)
To: Yishai Hadas, Doug Ledford, Sean Hefty, Hal Rosenstock,
Jason Gunthorpe, Leon Romanovsky, Chuck Lever, Mark Bloch,
Hans Westgaard Ry, Christoph Lameter, Erez Shitrit, Haggai Eran,
Florian Westphal, Guy Shapiro, Eli Cohen, Or Gerlitz,
Faisal Latif, Matan Barak, Chien Tin Tung, Mustafa Ismail,
Shiraz Saleem, Tatyana Nikolova, Steve Wise, Mike Marciniszyn,
Bart Van Assche, Yotam Kenneth, Somnath Kotur, Moni Shoua,
Shachar Raindel, Parav Pandit, Sagi Grimberg, Christoph Hellwig,
Dean Luick, Ira Weiny, Kaike Wan
Cc: linux-rdma, linux-kernel, Tejun Heo
alloc_ordered_workqueue() with WQ_MEM_RECLAIM set, replaces
deprecated create_singlethread_workqueue(). This is the identity
conversion.
The workqueue "cma_wq" queues work item cma_work_handler. It has been
identity converted.
WQ_MEM_RECLAIM has been set to ensure forward progress under
memory pressure.
Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
---
drivers/infiniband/core/cma.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/infiniband/core/cma.c b/drivers/infiniband/core/cma.c
index ad1b1ad..a262fdc 100644
--- a/drivers/infiniband/core/cma.c
+++ b/drivers/infiniband/core/cma.c
@@ -4277,7 +4277,7 @@ static int __init cma_init(void)
{
int ret;
- cma_wq = create_singlethread_workqueue("rdma_cm");
+ cma_wq = alloc_ordered_workqueue("rdma_cm", WQ_MEM_RECLAIM);
if (!cma_wq)
return -ENOMEM;
--
2.1.4
^ permalink raw reply related [flat|nested] 38+ messages in thread* RE: [PATCH 05/22] IB/cma: Remove deprecated create_singlethread_workqueue
2016-08-15 17:59 ` [PATCH 05/22] IB/cma: " Bhaktipriya Shridhar
@ 2016-08-16 18:21 ` Steve Wise
0 siblings, 0 replies; 38+ messages in thread
From: Steve Wise @ 2016-08-16 18:21 UTC (permalink / raw)
To: 'Bhaktipriya Shridhar', 'Yishai Hadas',
'Doug Ledford', 'Sean Hefty',
'Hal Rosenstock', 'Jason Gunthorpe',
'Leon Romanovsky', 'Chuck Lever',
'Mark Bloch', 'Hans Westgaard Ry',
'Christoph Lameter', 'Erez Shitrit',
'Haggai Eran', 'Florian Westphal',
'Guy Shapiro', 'Eli Cohen', 'Or Gerlitz',
'Faisal Latif', 'Matan Barak',
'Chien Tin Tung', 'Mustafa Ismail',
'Shiraz Saleem', 'Tatyana Nikolova',
'Steve Wise', 'Mike Marciniszyn',
'Bart Van Assche', 'Yotam Kenneth',
'Somnath Kotur', 'Moni Shoua',
'Shachar Raindel', 'Parav Pandit',
'Sagi Grimberg', 'Christoph Hellwig',
'Dean Luick', 'Ira Weiny', 'Kaike Wan'
Cc: linux-rdma, linux-kernel, 'Tejun Heo'
> alloc_ordered_workqueue() with WQ_MEM_RECLAIM set, replaces
> deprecated create_singlethread_workqueue(). This is the identity
> conversion.
>
> The workqueue "cma_wq" queues work item cma_work_handler. It has been
> identity converted.
>
> WQ_MEM_RECLAIM has been set to ensure forward progress under
> memory pressure.
>
> Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
Looks fine.
Reviewed-by: Steve Wise <swise@opengridcomputing.com>
^ permalink raw reply [flat|nested] 38+ messages in thread
* [PATCH 06/22] IB/addr: Remove deprecated create_singlethread_workqueue
2016-08-15 17:57 [PATCH 00/22] Remove deprecated create_workqueue instances Bhaktipriya Shridhar
` (4 preceding siblings ...)
2016-08-15 17:59 ` [PATCH 05/22] IB/cma: " Bhaktipriya Shridhar
@ 2016-08-15 18:00 ` Bhaktipriya Shridhar
2016-08-15 18:07 ` [PATCH 07/22] IB/iwcm: " Bhaktipriya Shridhar
` (18 subsequent siblings)
24 siblings, 0 replies; 38+ messages in thread
From: Bhaktipriya Shridhar @ 2016-08-15 18:00 UTC (permalink / raw)
To: Yishai Hadas, Doug Ledford, Sean Hefty, Hal Rosenstock,
Jason Gunthorpe, Leon Romanovsky, Chuck Lever, Mark Bloch,
Hans Westgaard Ry, Christoph Lameter, Erez Shitrit, Haggai Eran,
Florian Westphal, Guy Shapiro, Eli Cohen, Or Gerlitz,
Faisal Latif, Matan Barak, Chien Tin Tung, Mustafa Ismail,
Shiraz Saleem, Tatyana Nikolova, Steve Wise, Mike Marciniszyn,
Bart Van Assche, Yotam Kenneth, Somnath Kotur, Moni Shoua,
Shachar Raindel, Parav Pandit, Sagi Grimberg, Christoph Hellwig,
Dean Luick, Ira Weiny, Kaike Wan
Cc: linux-rdma, linux-kernel, Tejun Heo
The workqueue "addr_wq" queues a single work item &work and hence
doesn't require ordering. Also, it is being used on a memory reclaim
path. Hence, it has been converted to use alloc_workqueue with
WQ_MEM_RECLAIM set.
WQ_MEM_RECLAIM has been set to ensure forward progress under
memory pressure.
Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
---
drivers/infiniband/core/addr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/infiniband/core/addr.c b/drivers/infiniband/core/addr.c
index 1374541..b136d3a 100644
--- a/drivers/infiniband/core/addr.c
+++ b/drivers/infiniband/core/addr.c
@@ -800,7 +800,7 @@ static struct notifier_block nb = {
int addr_init(void)
{
- addr_wq = create_singlethread_workqueue("ib_addr");
+ addr_wq = alloc_workqueue("ib_addr", WQ_MEM_RECLAIM, 0);
if (!addr_wq)
return -ENOMEM;
--
2.1.4
^ permalink raw reply related [flat|nested] 38+ messages in thread* [PATCH 07/22] IB/iwcm: Remove deprecated create_singlethread_workqueue
2016-08-15 17:57 [PATCH 00/22] Remove deprecated create_workqueue instances Bhaktipriya Shridhar
` (5 preceding siblings ...)
2016-08-15 18:00 ` [PATCH 06/22] IB/addr: " Bhaktipriya Shridhar
@ 2016-08-15 18:07 ` Bhaktipriya Shridhar
2016-08-16 18:20 ` Steve Wise
2016-08-15 18:08 ` [PATCH 08/22] iw_cxgb3: " Bhaktipriya Shridhar
` (17 subsequent siblings)
24 siblings, 1 reply; 38+ messages in thread
From: Bhaktipriya Shridhar @ 2016-08-15 18:07 UTC (permalink / raw)
To: Yishai Hadas, Doug Ledford, Sean Hefty, Hal Rosenstock,
Jason Gunthorpe, Leon Romanovsky, Chuck Lever, Mark Bloch,
Hans Westgaard Ry, Christoph Lameter, Erez Shitrit, Haggai Eran,
Florian Westphal, Guy Shapiro, Eli Cohen, Or Gerlitz,
Faisal Latif, Matan Barak, Chien Tin Tung, Mustafa Ismail,
Shiraz Saleem, Tatyana Nikolova, Steve Wise, Mike Marciniszyn,
Bart Van Assche, Yotam Kenneth, Somnath Kotur, Moni Shoua,
Shachar Raindel, Parav Pandit, Sagi Grimberg, Christoph Hellwig,
Dean Luick, Ira Weiny, Kaike Wan
Cc: linux-rdma, linux-kernel, Tejun Heo
alloc_ordered_workqueue() with WQ_MEM_RECLAIM set, replaces
deprecated create_singlethread_workqueue(). This is the identity
conversion.
The workqueue "iwcm_wq" queues work item &work(maps to cm_work_handler).
It has been identity converted.
WQ_MEM_RECLAIM has been set to ensure forward progress under
memory pressure.
Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
---
drivers/infiniband/core/iwcm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/infiniband/core/iwcm.c b/drivers/infiniband/core/iwcm.c
index f057204..d6b5224 100644
--- a/drivers/infiniband/core/iwcm.c
+++ b/drivers/infiniband/core/iwcm.c
@@ -1180,7 +1180,7 @@ static int __init iw_cm_init(void)
if (ret)
pr_err("iw_cm: couldn't register netlink callbacks\n");
- iwcm_wq = create_singlethread_workqueue("iw_cm_wq");
+ iwcm_wq = alloc_ordered_workqueue("iw_cm_wq", WQ_MEM_RECLAIM);
if (!iwcm_wq)
return -ENOMEM;
--
2.1.4
^ permalink raw reply related [flat|nested] 38+ messages in thread* RE: [PATCH 07/22] IB/iwcm: Remove deprecated create_singlethread_workqueue
2016-08-15 18:07 ` [PATCH 07/22] IB/iwcm: " Bhaktipriya Shridhar
@ 2016-08-16 18:20 ` Steve Wise
0 siblings, 0 replies; 38+ messages in thread
From: Steve Wise @ 2016-08-16 18:20 UTC (permalink / raw)
To: 'Bhaktipriya Shridhar', 'Yishai Hadas',
'Doug Ledford', 'Sean Hefty',
'Hal Rosenstock', 'Jason Gunthorpe',
'Leon Romanovsky', 'Chuck Lever',
'Mark Bloch', 'Hans Westgaard Ry',
'Christoph Lameter', 'Erez Shitrit',
'Haggai Eran', 'Florian Westphal',
'Guy Shapiro', 'Eli Cohen', 'Or Gerlitz',
'Faisal Latif', 'Matan Barak',
'Chien Tin Tung', 'Mustafa Ismail',
'Shiraz Saleem', 'Tatyana Nikolova',
'Steve Wise', 'Mike Marciniszyn',
'Bart Van Assche', 'Yotam Kenneth',
'Somnath Kotur', 'Moni Shoua',
'Shachar Raindel', 'Parav Pandit',
'Sagi Grimberg', 'Christoph Hellwig',
'Dean Luick', 'Ira Weiny', 'Kaike Wan'
Cc: linux-rdma, linux-kernel, 'Tejun Heo'
> alloc_ordered_workqueue() with WQ_MEM_RECLAIM set, replaces
> deprecated create_singlethread_workqueue(). This is the identity
> conversion.
>
> The workqueue "iwcm_wq" queues work item &work(maps to cm_work_handler).
> It has been identity converted.
>
> WQ_MEM_RECLAIM has been set to ensure forward progress under
> memory pressure.
>
> Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
Looks fine.
Reviewed-by: Steve Wise <swise@opengridcomputing.com>
^ permalink raw reply [flat|nested] 38+ messages in thread
* [PATCH 08/22] iw_cxgb3: Remove deprecated create_singlethread_workqueue
2016-08-15 17:57 [PATCH 00/22] Remove deprecated create_workqueue instances Bhaktipriya Shridhar
` (6 preceding siblings ...)
2016-08-15 18:07 ` [PATCH 07/22] IB/iwcm: " Bhaktipriya Shridhar
@ 2016-08-15 18:08 ` Bhaktipriya Shridhar
2016-08-16 18:19 ` Steve Wise
2016-08-15 18:08 ` [PATCH 09/22] IB/qib: " Bhaktipriya Shridhar
` (16 subsequent siblings)
24 siblings, 1 reply; 38+ messages in thread
From: Bhaktipriya Shridhar @ 2016-08-15 18:08 UTC (permalink / raw)
To: Yishai Hadas, Doug Ledford, Sean Hefty, Hal Rosenstock,
Jason Gunthorpe, Leon Romanovsky, Chuck Lever, Mark Bloch,
Hans Westgaard Ry, Christoph Lameter, Erez Shitrit, Haggai Eran,
Florian Westphal, Guy Shapiro, Eli Cohen, Or Gerlitz,
Faisal Latif, Matan Barak, Chien Tin Tung, Mustafa Ismail,
Shiraz Saleem, Tatyana Nikolova, Steve Wise, Mike Marciniszyn,
Bart Van Assche, Yotam Kenneth, Somnath Kotur, Moni Shoua,
Shachar Raindel, Parav Pandit, Sagi Grimberg, Christoph Hellwig,
Dean Luick, Ira Weiny, Kaike Wan
Cc: linux-rdma, linux-kernel, Tejun Heo
alloc_ordered_workqueue() with WQ_MEM_RECLAIM set, replaces
deprecated create_singlethread_workqueue(). This is the identity
conversion.
The workqueue "workq" queues work item &skb_work. It has been
identity converted.
WQ_MEM_RECLAIM has been set to ensure forward progress under
memory pressure.
Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
---
drivers/infiniband/hw/cxgb3/iwch_cm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/infiniband/hw/cxgb3/iwch_cm.c b/drivers/infiniband/hw/cxgb3/iwch_cm.c
index 3e8431b..1ce4e6b 100644
--- a/drivers/infiniband/hw/cxgb3/iwch_cm.c
+++ b/drivers/infiniband/hw/cxgb3/iwch_cm.c
@@ -2258,7 +2258,7 @@ int __init iwch_cm_init(void)
{
skb_queue_head_init(&rxq);
- workq = create_singlethread_workqueue("iw_cxgb3");
+ workq = alloc_ordered_workqueue("iw_cxgb3", WQ_MEM_RECLAIM);
if (!workq)
return -ENOMEM;
--
2.1.4
^ permalink raw reply related [flat|nested] 38+ messages in thread* RE: [PATCH 08/22] iw_cxgb3: Remove deprecated create_singlethread_workqueue
2016-08-15 18:08 ` [PATCH 08/22] iw_cxgb3: " Bhaktipriya Shridhar
@ 2016-08-16 18:19 ` Steve Wise
0 siblings, 0 replies; 38+ messages in thread
From: Steve Wise @ 2016-08-16 18:19 UTC (permalink / raw)
To: 'Bhaktipriya Shridhar', 'Yishai Hadas',
'Doug Ledford', 'Sean Hefty',
'Hal Rosenstock', 'Jason Gunthorpe',
'Leon Romanovsky', 'Chuck Lever',
'Mark Bloch', 'Hans Westgaard Ry',
'Christoph Lameter', 'Erez Shitrit',
'Haggai Eran', 'Florian Westphal',
'Guy Shapiro', 'Eli Cohen', 'Or Gerlitz',
'Faisal Latif', 'Matan Barak',
'Chien Tin Tung', 'Mustafa Ismail',
'Shiraz Saleem', 'Tatyana Nikolova',
'Steve Wise', 'Mike Marciniszyn',
'Bart Van Assche', 'Yotam Kenneth',
'Somnath Kotur', 'Moni Shoua',
'Shachar Raindel', 'Parav Pandit',
'Sagi Grimberg', 'Christoph Hellwig',
'Dean Luick', 'Ira Weiny', 'Kaike Wan'
Cc: linux-rdma, linux-kernel, 'Tejun Heo'
>
> alloc_ordered_workqueue() with WQ_MEM_RECLAIM set, replaces
> deprecated create_singlethread_workqueue(). This is the identity
> conversion.
>
> The workqueue "workq" queues work item &skb_work. It has been
> identity converted.
>
> WQ_MEM_RECLAIM has been set to ensure forward progress under
> memory pressure.
>
> Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
Acked-by: Steve Wise <swise@opengridcomputing.com>
^ permalink raw reply [flat|nested] 38+ messages in thread
* [PATCH 09/22] IB/qib: Remove deprecated create_singlethread_workqueue
2016-08-15 17:57 [PATCH 00/22] Remove deprecated create_workqueue instances Bhaktipriya Shridhar
` (7 preceding siblings ...)
2016-08-15 18:08 ` [PATCH 08/22] iw_cxgb3: " Bhaktipriya Shridhar
@ 2016-08-15 18:08 ` Bhaktipriya Shridhar
2016-08-16 17:32 ` Marciniszyn, Mike
2016-08-15 18:09 ` [PATCH 10/22] iw_cxgb4: " Bhaktipriya Shridhar
` (15 subsequent siblings)
24 siblings, 1 reply; 38+ messages in thread
From: Bhaktipriya Shridhar @ 2016-08-15 18:08 UTC (permalink / raw)
To: Yishai Hadas, Doug Ledford, Sean Hefty, Hal Rosenstock,
Jason Gunthorpe, Leon Romanovsky, Chuck Lever, Mark Bloch,
Hans Westgaard Ry, Christoph Lameter, Erez Shitrit, Haggai Eran,
Florian Westphal, Guy Shapiro, Eli Cohen, Or Gerlitz,
Faisal Latif, Matan Barak, Chien Tin Tung, Mustafa Ismail,
Shiraz Saleem, Tatyana Nikolova, Steve Wise, Mike Marciniszyn,
Bart Van Assche, Yotam Kenneth, Somnath Kotur, Moni Shoua,
Shachar Raindel, Parav Pandit, Sagi Grimberg, Christoph Hellwig,
Dean Luick, Ira Weiny, Kaike Wan
Cc: linux-rdma, linux-kernel, Tejun Heo
alloc_ordered_workqueue() with WQ_MEM_RECLAIM set, replaces
deprecated create_singlethread_workqueue(). This is the identity
conversion.
The workqueue "qib" queues work item &priv->s_work. It has been
identity converted.
WQ_MEM_RECLAIM has been set to ensure forward progress under
memory pressure.
Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
---
drivers/infiniband/hw/qib/qib_init.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/infiniband/hw/qib/qib_init.c b/drivers/infiniband/hw/qib/qib_init.c
index f253111..1730aa8 100644
--- a/drivers/infiniband/hw/qib/qib_init.c
+++ b/drivers/infiniband/hw/qib/qib_init.c
@@ -614,8 +614,8 @@ static int qib_create_workqueues(struct qib_devdata *dd)
snprintf(wq_name, sizeof(wq_name), "qib%d_%d",
dd->unit, pidx);
- ppd->qib_wq =
- create_singlethread_workqueue(wq_name);
+ ppd->qib_wq = alloc_ordered_workqueue(wq_name,
+ WQ_MEM_RECLAIM);
if (!ppd->qib_wq)
goto wq_error;
}
--
2.1.4
^ permalink raw reply related [flat|nested] 38+ messages in thread* RE: [PATCH 09/22] IB/qib: Remove deprecated create_singlethread_workqueue
2016-08-15 18:08 ` [PATCH 09/22] IB/qib: " Bhaktipriya Shridhar
@ 2016-08-16 17:32 ` Marciniszyn, Mike
0 siblings, 0 replies; 38+ messages in thread
From: Marciniszyn, Mike @ 2016-08-16 17:32 UTC (permalink / raw)
To: Bhaktipriya Shridhar, Yishai Hadas, Doug Ledford, Hefty, Sean,
Hal Rosenstock, Jason Gunthorpe, Leon Romanovsky, Chuck Lever,
Mark Bloch, Hans Westgaard Ry, Christoph Lameter, Erez Shitrit,
Haggai Eran, Florian Westphal, Guy Shapiro, Eli Cohen, Or Gerlitz,
Latif, Faisal, Matan Barak, Tung, Chien Tin, Ismail, Mustafa,
Saleem, Shiraz, Nikolova, Tatyana E, Steve Wise, infinipath,
Bart Van Assche, Yotam Kenneth, Somnath Kotur, Moni Shoua,
Shachar Raindel, Parav Pandit, Sagi Grimberg, Christoph Hellwig,
Luick, Dean, Weiny, Ira, Wan, Kaike
Cc: linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
Tejun Heo
> Subject: [PATCH 09/22] IB/qib: Remove deprecated
> create_singlethread_workqueue
>
Looks and tests good!
Tested-by: Mike Marciniszyn <mike.marciniszyn@intel.com>
Acked-by: Mike Marciniszyn <mike.marciniszyn@intel.com>
^ permalink raw reply [flat|nested] 38+ messages in thread
* [PATCH 10/22] iw_cxgb4: Remove deprecated create_singlethread_workqueue
2016-08-15 17:57 [PATCH 00/22] Remove deprecated create_workqueue instances Bhaktipriya Shridhar
` (8 preceding siblings ...)
2016-08-15 18:08 ` [PATCH 09/22] IB/qib: " Bhaktipriya Shridhar
@ 2016-08-15 18:09 ` Bhaktipriya Shridhar
2016-08-16 18:19 ` Steve Wise
2016-08-15 18:09 ` [PATCH 11/22] IB/mthca: " Bhaktipriya Shridhar
` (14 subsequent siblings)
24 siblings, 1 reply; 38+ messages in thread
From: Bhaktipriya Shridhar @ 2016-08-15 18:09 UTC (permalink / raw)
To: Yishai Hadas, Doug Ledford, Sean Hefty, Hal Rosenstock,
Jason Gunthorpe, Leon Romanovsky, Chuck Lever, Mark Bloch,
Hans Westgaard Ry, Christoph Lameter, Erez Shitrit, Haggai Eran,
Florian Westphal, Guy Shapiro, Eli Cohen, Or Gerlitz,
Faisal Latif, Matan Barak, Chien Tin Tung, Mustafa Ismail,
Shiraz Saleem, Tatyana Nikolova, Steve Wise, Mike Marciniszyn,
Bart Van Assche, Yotam Kenneth, Somnath Kotur, Moni Shoua,
Shachar Raindel, Parav Pandit, Sagi Grimberg, Christoph Hellwig,
Dean Luick, Ira Weiny, Kaike Wan
Cc: linux-rdma, linux-kernel, Tejun Heo
alloc_ordered_workqueue() with WQ_MEM_RECLAIM set, replaces
deprecated create_singlethread_workqueue(). This is the identity
conversion.
The workqueue "workq" queues work item &skb_work. It has been
identity converted.
WQ_MEM_RECLAIM has been set to ensure forward progress under
memory pressure.
Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
---
drivers/infiniband/hw/cxgb4/cm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/infiniband/hw/cxgb4/cm.c b/drivers/infiniband/hw/cxgb4/cm.c
index a3a6721..6438b4c 100644
--- a/drivers/infiniband/hw/cxgb4/cm.c
+++ b/drivers/infiniband/hw/cxgb4/cm.c
@@ -4282,7 +4282,7 @@ int __init c4iw_cm_init(void)
spin_lock_init(&timeout_lock);
skb_queue_head_init(&rxq);
- workq = create_singlethread_workqueue("iw_cxgb4");
+ workq = alloc_ordered_workqueue("iw_cxgb4", WQ_MEM_RECLAIM);
if (!workq)
return -ENOMEM;
--
2.1.4
^ permalink raw reply related [flat|nested] 38+ messages in thread* RE: [PATCH 10/22] iw_cxgb4: Remove deprecated create_singlethread_workqueue
2016-08-15 18:09 ` [PATCH 10/22] iw_cxgb4: " Bhaktipriya Shridhar
@ 2016-08-16 18:19 ` Steve Wise
0 siblings, 0 replies; 38+ messages in thread
From: Steve Wise @ 2016-08-16 18:19 UTC (permalink / raw)
To: 'Bhaktipriya Shridhar', 'Yishai Hadas',
'Doug Ledford', 'Sean Hefty',
'Hal Rosenstock', 'Jason Gunthorpe',
'Leon Romanovsky', 'Chuck Lever',
'Mark Bloch', 'Hans Westgaard Ry',
'Christoph Lameter', 'Erez Shitrit',
'Haggai Eran', 'Florian Westphal',
'Guy Shapiro', 'Eli Cohen', 'Or Gerlitz',
'Faisal Latif', 'Matan Barak',
'Chien Tin Tung', 'Mustafa Ismail',
'Shiraz Saleem', 'Tatyana Nikolova',
'Steve Wise', 'Mike Marciniszyn',
'Bart Van Assche', 'Yotam Kenneth',
'Somnath Kotur', 'Moni Shoua',
'Shachar Raindel', 'Parav Pandit',
'Sagi Grimberg', 'Christoph Hellwig',
'Dean Luick', 'Ira Weiny', 'Kaike Wan'
Cc: linux-rdma, linux-kernel, 'Tejun Heo'
> alloc_ordered_workqueue() with WQ_MEM_RECLAIM set, replaces
> deprecated create_singlethread_workqueue(). This is the identity
> conversion.
>
> The workqueue "workq" queues work item &skb_work. It has been
> identity converted.
>
> WQ_MEM_RECLAIM has been set to ensure forward progress under
> memory pressure.
>
> Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
Acked-by: Steve Wise <swise@opengridcomputing.com>
^ permalink raw reply [flat|nested] 38+ messages in thread
* [PATCH 11/22] IB/mthca: Remove deprecated create_singlethread_workqueue
2016-08-15 17:57 [PATCH 00/22] Remove deprecated create_workqueue instances Bhaktipriya Shridhar
` (9 preceding siblings ...)
2016-08-15 18:09 ` [PATCH 10/22] iw_cxgb4: " Bhaktipriya Shridhar
@ 2016-08-15 18:09 ` Bhaktipriya Shridhar
2016-08-15 18:10 ` [PATCH 12/22] i40iw_main: " Bhaktipriya Shridhar
` (13 subsequent siblings)
24 siblings, 0 replies; 38+ messages in thread
From: Bhaktipriya Shridhar @ 2016-08-15 18:09 UTC (permalink / raw)
To: Yishai Hadas, Doug Ledford, Sean Hefty, Hal Rosenstock,
Jason Gunthorpe, Leon Romanovsky, Chuck Lever, Mark Bloch,
Hans Westgaard Ry, Christoph Lameter, Erez Shitrit, Haggai Eran,
Florian Westphal, Guy Shapiro, Eli Cohen, Or Gerlitz,
Faisal Latif, Matan Barak, Chien Tin Tung, Mustafa Ismail,
Shiraz Saleem, Tatyana Nikolova, Steve Wise, Mike Marciniszyn,
Bart Van Assche, Yotam Kenneth, Somnath Kotur, Moni Shoua,
Shachar Raindel, Parav Pandit, Sagi Grimberg, Christoph Hellwig,
Dean Luick, Ira Weiny, Kaike Wan
Cc: linux-rdma, linux-kernel, Tejun Heo
alloc_ordered_workqueue() with WQ_MEM_RECLAIM set, replaces
deprecated create_singlethread_workqueue(). This is the identity
conversion.
The workqueue "catas_wq" in triggering a device remove and causing a
device reset when a catastrophic error occurs. It has been identity
converted.
WQ_MEM_RECLAIM has been set to ensure forward progress under memory
pressure.
Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
---
drivers/infiniband/hw/mthca/mthca_catas.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/infiniband/hw/mthca/mthca_catas.c b/drivers/infiniband/hw/mthca/mthca_catas.c
index 712d2a3..f6474c2 100644
--- a/drivers/infiniband/hw/mthca/mthca_catas.c
+++ b/drivers/infiniband/hw/mthca/mthca_catas.c
@@ -187,7 +187,7 @@ int __init mthca_catas_init(void)
{
INIT_WORK(&catas_work, catas_reset);
- catas_wq = create_singlethread_workqueue("mthca_catas");
+ catas_wq = alloc_ordered_workqueue("mthca_catas", WQ_MEM_RECLAIM);
if (!catas_wq)
return -ENOMEM;
--
2.1.4
^ permalink raw reply related [flat|nested] 38+ messages in thread* [PATCH 12/22] i40iw_main: Remove deprecated create_singlethread_workqueue
2016-08-15 17:57 [PATCH 00/22] Remove deprecated create_workqueue instances Bhaktipriya Shridhar
` (10 preceding siblings ...)
2016-08-15 18:09 ` [PATCH 11/22] IB/mthca: " Bhaktipriya Shridhar
@ 2016-08-15 18:10 ` Bhaktipriya Shridhar
2016-08-15 18:10 ` [PATCH 13/22] i40iw_cm: " Bhaktipriya Shridhar
` (12 subsequent siblings)
24 siblings, 0 replies; 38+ messages in thread
From: Bhaktipriya Shridhar @ 2016-08-15 18:10 UTC (permalink / raw)
To: Yishai Hadas, Doug Ledford, Sean Hefty, Hal Rosenstock,
Jason Gunthorpe, Leon Romanovsky, Chuck Lever, Mark Bloch,
Hans Westgaard Ry, Christoph Lameter, Erez Shitrit, Haggai Eran,
Florian Westphal, Guy Shapiro, Eli Cohen, Or Gerlitz,
Faisal Latif, Matan Barak, Chien Tin Tung, Mustafa Ismail,
Shiraz Saleem, Tatyana Nikolova, Steve Wise, Mike Marciniszyn,
Bart Van Assche, Yotam Kenneth, Somnath Kotur, Moni Shoua,
Shachar Raindel, Parav Pandit, Sagi Grimberg, Christoph Hellwig,
Dean Luick, Ira Weiny, Kaike Wan
Cc: linux-rdma, linux-kernel, Tejun Heo
alloc_ordered_workqueue() with WQ_MEM_RECLAIM set, replaces
deprecated create_singlethread_workqueue(). This is the identity
conversion.
The workqueue "virtchnl_wq" queues work items i40iw_cqp_generic_worker
and i40iw_cqp_manage_hmc_fcn_worker. It has been identity converted.
WQ_MEM_RECLAIM has been set to ensure forward progress under memory
pressure.
Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
---
drivers/infiniband/hw/i40iw/i40iw_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/infiniband/hw/i40iw/i40iw_main.c b/drivers/infiniband/hw/i40iw/i40iw_main.c
index 6e90813..798335f 100644
--- a/drivers/infiniband/hw/i40iw/i40iw_main.c
+++ b/drivers/infiniband/hw/i40iw/i40iw_main.c
@@ -1613,7 +1613,7 @@ static int i40iw_open(struct i40e_info *ldev, struct i40e_client *client)
status = i40iw_hmc_init_pble(&iwdev->sc_dev, iwdev->pble_rsrc);
if (status)
break;
- iwdev->virtchnl_wq = create_singlethread_workqueue("iwvch");
+ iwdev->virtchnl_wq = alloc_ordered_workqueue("iwvch", WQ_MEM_RECLAIM);
i40iw_register_notifiers();
iwdev->init_state = INET_NOTIFIER;
status = i40iw_add_mac_ip(iwdev);
--
2.1.4
^ permalink raw reply related [flat|nested] 38+ messages in thread* [PATCH 13/22] i40iw_cm: Remove deprecated create_singlethread_workqueue
2016-08-15 17:57 [PATCH 00/22] Remove deprecated create_workqueue instances Bhaktipriya Shridhar
` (11 preceding siblings ...)
2016-08-15 18:10 ` [PATCH 12/22] i40iw_main: " Bhaktipriya Shridhar
@ 2016-08-15 18:10 ` Bhaktipriya Shridhar
2016-08-15 18:11 ` [PATCH 14/22] IB/mlx5: " Bhaktipriya Shridhar
` (11 subsequent siblings)
24 siblings, 0 replies; 38+ messages in thread
From: Bhaktipriya Shridhar @ 2016-08-15 18:10 UTC (permalink / raw)
To: Yishai Hadas, Doug Ledford, Sean Hefty, Hal Rosenstock,
Jason Gunthorpe, Leon Romanovsky, Chuck Lever, Mark Bloch,
Hans Westgaard Ry, Christoph Lameter, Erez Shitrit, Haggai Eran,
Florian Westphal, Guy Shapiro, Eli Cohen, Or Gerlitz,
Faisal Latif, Matan Barak, Chien Tin Tung, Mustafa Ismail,
Shiraz Saleem, Tatyana Nikolova, Steve Wise, Mike Marciniszyn,
Bart Van Assche, Yotam Kenneth, Somnath Kotur, Moni Shoua,
Shachar Raindel, Parav Pandit, Sagi Grimberg, Christoph Hellwig,
Dean Luick, Ira Weiny, Kaike Wan
Cc: linux-rdma, linux-kernel, Tejun Heo
alloc_ordered_workqueue() with WQ_MEM_RECLAIM set, replaces
deprecated create_singlethread_workqueue(). This is the identity
conversion.
The workqueue "event_wq" is involved in event handling and queues
i40iw_cm_event_handler.
The workqueue "disconn_wq" is involved in closing connection and queues
i40iw_disconnect_worker.
Both workqueues have been identity converted.
WQ_MEM_RECLAIM has been set to ensure forward progress under memory
pressure.
Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
---
drivers/infiniband/hw/i40iw/i40iw_cm.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/infiniband/hw/i40iw/i40iw_cm.c b/drivers/infiniband/hw/i40iw/i40iw_cm.c
index d2fa725..76082b3 100644
--- a/drivers/infiniband/hw/i40iw/i40iw_cm.c
+++ b/drivers/infiniband/hw/i40iw/i40iw_cm.c
@@ -3166,8 +3166,11 @@ void i40iw_setup_cm_core(struct i40iw_device *iwdev)
spin_lock_init(&cm_core->ht_lock);
spin_lock_init(&cm_core->listen_list_lock);
- cm_core->event_wq = create_singlethread_workqueue("iwewq");
- cm_core->disconn_wq = create_singlethread_workqueue("iwdwq");
+ cm_core->event_wq = alloc_ordered_workqueue("iwewq",
+ WQ_MEM_RECLAIM);
+
+ cm_core->disconn_wq = alloc_ordered_workqueue("iwdwq",
+ WQ_MEM_RECLAIM);
}
/**
--
2.1.4
^ permalink raw reply related [flat|nested] 38+ messages in thread* [PATCH 14/22] IB/mlx5: Remove deprecated create_singlethread_workqueue
2016-08-15 17:57 [PATCH 00/22] Remove deprecated create_workqueue instances Bhaktipriya Shridhar
` (12 preceding siblings ...)
2016-08-15 18:10 ` [PATCH 13/22] i40iw_cm: " Bhaktipriya Shridhar
@ 2016-08-15 18:11 ` Bhaktipriya Shridhar
2016-08-19 15:44 ` Leon Romanovsky
2016-08-19 15:46 ` Leon Romanovsky
2016-08-15 18:12 ` [PATCH 15/22] IB/mlx5/odp: " Bhaktipriya Shridhar
` (10 subsequent siblings)
24 siblings, 2 replies; 38+ messages in thread
From: Bhaktipriya Shridhar @ 2016-08-15 18:11 UTC (permalink / raw)
To: Yishai Hadas, Doug Ledford, Sean Hefty, Hal Rosenstock,
Jason Gunthorpe, Leon Romanovsky, Chuck Lever, Mark Bloch,
Hans Westgaard Ry, Christoph Lameter, Erez Shitrit, Haggai Eran,
Florian Westphal, Guy Shapiro, Eli Cohen, Or Gerlitz,
Faisal Latif, Matan Barak, Chien Tin Tung, Mustafa Ismail,
Shiraz Saleem, Tatyana Nikolova, Steve Wise, Mike Marciniszyn,
Bart Van Assche, Yotam Kenneth, Somnath Kotur, Moni Shoua,
Shachar Raindel, Parav Pandit, Sagi Grimberg, Christoph Hellwig,
Dean Luick, Ira Weiny, Kaike Wan
Cc: linux-rdma, linux-kernel, Tejun Heo
alloc_ordered_workqueue() with WQ_MEM_RECLAIM set, replaces
deprecated create_singlethread_workqueue(). This is the identity
conversion.
The workqueue "cache->wq" queues work items &ent->work (maps to
cache_work_func) and &ent->dwork(maps to delayed_cache_work_func).
It has been identity converted.
WQ_MEM_RECLAIM has been set to ensure forward progress under
memory pressure.
Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
---
drivers/infiniband/hw/mlx5/mr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/infiniband/hw/mlx5/mr.c b/drivers/infiniband/hw/mlx5/mr.c
index 8cf2ce5..fb0194d 100644
--- a/drivers/infiniband/hw/mlx5/mr.c
+++ b/drivers/infiniband/hw/mlx5/mr.c
@@ -614,7 +614,7 @@ int mlx5_mr_cache_init(struct mlx5_ib_dev *dev)
int err;
int i;
- cache->wq = create_singlethread_workqueue("mkey_cache");
+ cache->wq = alloc_ordered_workqueue("mkey_cache", WQ_MEM_RECLAIM);
if (!cache->wq) {
mlx5_ib_warn(dev, "failed to create work queue\n");
return -ENOMEM;
--
2.1.4
^ permalink raw reply related [flat|nested] 38+ messages in thread* Re: [PATCH 14/22] IB/mlx5: Remove deprecated create_singlethread_workqueue
2016-08-15 18:11 ` [PATCH 14/22] IB/mlx5: " Bhaktipriya Shridhar
@ 2016-08-19 15:44 ` Leon Romanovsky
2016-08-19 15:46 ` Leon Romanovsky
1 sibling, 0 replies; 38+ messages in thread
From: Leon Romanovsky @ 2016-08-19 15:44 UTC (permalink / raw)
To: Bhaktipriya Shridhar
Cc: Yishai Hadas, Doug Ledford, Sean Hefty, Hal Rosenstock,
Jason Gunthorpe, Chuck Lever, Mark Bloch, Hans Westgaard Ry,
Christoph Lameter, Erez Shitrit, Haggai Eran, Florian Westphal,
Guy Shapiro, Eli Cohen, Or Gerlitz, Faisal Latif, Matan Barak,
Chien Tin Tung, Mustafa Ismail, Shiraz Saleem, Tatyana Nikolova,
Steve Wise, Mike Marciniszyn, Bart Van Assche, Yotam Kenneth,
Somnath Kotur, Moni Shoua, Shachar Raindel, Parav Pandit,
Sagi Grimberg, Christoph Hellwig, Dean Luick, Ira Weiny,
Kaike Wan, linux-rdma, linux-kernel, Tejun Heo
[-- Attachment #1: Type: text/plain, Size: 1476 bytes --]
On Mon, Aug 15, 2016 at 11:41:18PM +0530, Bhaktipriya Shridhar wrote:
> alloc_ordered_workqueue() with WQ_MEM_RECLAIM set, replaces
> deprecated create_singlethread_workqueue(). This is the identity
> conversion.
>
> The workqueue "cache->wq" queues work items &ent->work (maps to
> cache_work_func) and &ent->dwork(maps to delayed_cache_work_func).
> It has been identity converted.
>
> WQ_MEM_RECLAIM has been set to ensure forward progress under
> memory pressure.
>
> Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
> ---
> drivers/infiniband/hw/mlx5/mr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Thanks,
Acked-by: Leon Romanovsky <leonro@mellanox.com>
>
> diff --git a/drivers/infiniband/hw/mlx5/mr.c b/drivers/infiniband/hw/mlx5/mr.c
> index 8cf2ce5..fb0194d 100644
> --- a/drivers/infiniband/hw/mlx5/mr.c
> +++ b/drivers/infiniband/hw/mlx5/mr.c
> @@ -614,7 +614,7 @@ int mlx5_mr_cache_init(struct mlx5_ib_dev *dev)
> int err;
> int i;
>
> - cache->wq = create_singlethread_workqueue("mkey_cache");
> + cache->wq = alloc_ordered_workqueue("mkey_cache", WQ_MEM_RECLAIM);
> if (!cache->wq) {
> mlx5_ib_warn(dev, "failed to create work queue\n");
> return -ENOMEM;
> --
> 2.1.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 38+ messages in thread* Re: [PATCH 14/22] IB/mlx5: Remove deprecated create_singlethread_workqueue
2016-08-15 18:11 ` [PATCH 14/22] IB/mlx5: " Bhaktipriya Shridhar
2016-08-19 15:44 ` Leon Romanovsky
@ 2016-08-19 15:46 ` Leon Romanovsky
1 sibling, 0 replies; 38+ messages in thread
From: Leon Romanovsky @ 2016-08-19 15:46 UTC (permalink / raw)
To: Bhaktipriya Shridhar
Cc: Yishai Hadas, Doug Ledford, Sean Hefty, Hal Rosenstock,
Jason Gunthorpe, Chuck Lever, Mark Bloch, Hans Westgaard Ry,
Christoph Lameter, Erez Shitrit, Haggai Eran, Florian Westphal,
Guy Shapiro, Eli Cohen, Or Gerlitz, Faisal Latif, Matan Barak,
Chien Tin Tung, Mustafa Ismail, Shiraz Saleem, Tatyana Nikolova,
Steve Wise, Mike Marciniszyn, Bart Van Assche, Yotam Kenneth,
Somnath Kotur, Moni Shoua, Shachar Raindel, Parav Pandit,
Sagi Grimberg, Christoph Hellwig, Dean Luick, Ira Weiny,
Kaike Wan, linux-rdma, linux-kernel, Tejun Heo
[-- Attachment #1: Type: text/plain, Size: 1476 bytes --]
On Mon, Aug 15, 2016 at 11:41:18PM +0530, Bhaktipriya Shridhar wrote:
> alloc_ordered_workqueue() with WQ_MEM_RECLAIM set, replaces
> deprecated create_singlethread_workqueue(). This is the identity
> conversion.
>
> The workqueue "cache->wq" queues work items &ent->work (maps to
> cache_work_func) and &ent->dwork(maps to delayed_cache_work_func).
> It has been identity converted.
>
> WQ_MEM_RECLAIM has been set to ensure forward progress under
> memory pressure.
>
> Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
Thanks,
Acked-by: Leon Romanovsky <leonro@mellanox.com>
> ---
> drivers/infiniband/hw/mlx5/mr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/infiniband/hw/mlx5/mr.c b/drivers/infiniband/hw/mlx5/mr.c
> index 8cf2ce5..fb0194d 100644
> --- a/drivers/infiniband/hw/mlx5/mr.c
> +++ b/drivers/infiniband/hw/mlx5/mr.c
> @@ -614,7 +614,7 @@ int mlx5_mr_cache_init(struct mlx5_ib_dev *dev)
> int err;
> int i;
>
> - cache->wq = create_singlethread_workqueue("mkey_cache");
> + cache->wq = alloc_ordered_workqueue("mkey_cache", WQ_MEM_RECLAIM);
> if (!cache->wq) {
> mlx5_ib_warn(dev, "failed to create work queue\n");
> return -ENOMEM;
> --
> 2.1.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 38+ messages in thread
* [PATCH 15/22] IB/mlx5/odp: Remove deprecated create_singlethread_workqueue
2016-08-15 17:57 [PATCH 00/22] Remove deprecated create_workqueue instances Bhaktipriya Shridhar
` (13 preceding siblings ...)
2016-08-15 18:11 ` [PATCH 14/22] IB/mlx5: " Bhaktipriya Shridhar
@ 2016-08-15 18:12 ` Bhaktipriya Shridhar
2016-08-19 15:49 ` Leon Romanovsky
2016-08-15 18:12 ` [PATCH 16/22] IB/mlx4: " Bhaktipriya Shridhar
` (9 subsequent siblings)
24 siblings, 1 reply; 38+ messages in thread
From: Bhaktipriya Shridhar @ 2016-08-15 18:12 UTC (permalink / raw)
To: Yishai Hadas, Doug Ledford, Sean Hefty, Hal Rosenstock,
Jason Gunthorpe, Leon Romanovsky, Chuck Lever, Mark Bloch,
Hans Westgaard Ry, Christoph Lameter, Erez Shitrit, Haggai Eran,
Florian Westphal, Guy Shapiro, Eli Cohen, Or Gerlitz,
Faisal Latif, Matan Barak, Chien Tin Tung, Mustafa Ismail,
Shiraz Saleem, Tatyana Nikolova, Steve Wise, Mike Marciniszyn,
Bart Van Assche, Yotam Kenneth, Somnath Kotur, Moni Shoua,
Shachar Raindel, Parav Pandit, Sagi Grimberg, Christoph Hellwig,
Dean Luick, Ira Weiny, Kaike Wan
Cc: linux-rdma, linux-kernel, Tejun Heo
alloc_ordered_workqueue() with WQ_MEM_RECLAIM set, replaces
deprecated create_singlethread_workqueue(). This is the identity
conversion.
The workqueue "mlx5_ib_page_fault_wq" queues work item &qp_pfault->work.
It has been identity converted.
WQ_MEM_RECLAIM has been set to ensure forward progress under
memory pressure.
Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
---
drivers/infiniband/hw/mlx5/odp.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/infiniband/hw/mlx5/odp.c b/drivers/infiniband/hw/mlx5/odp.c
index 34e79e7..cacb631 100644
--- a/drivers/infiniband/hw/mlx5/odp.c
+++ b/drivers/infiniband/hw/mlx5/odp.c
@@ -782,8 +782,8 @@ void mlx5_ib_odp_remove_one(struct mlx5_ib_dev *ibdev)
int __init mlx5_ib_odp_init(void)
{
- mlx5_ib_page_fault_wq =
- create_singlethread_workqueue("mlx5_ib_page_faults");
+ mlx5_ib_page_fault_wq = alloc_ordered_workqueue("mlx5_ib_page_faults",
+ WQ_MEM_RECLAIM);
if (!mlx5_ib_page_fault_wq)
return -ENOMEM;
--
2.1.4
^ permalink raw reply related [flat|nested] 38+ messages in thread* Re: [PATCH 15/22] IB/mlx5/odp: Remove deprecated create_singlethread_workqueue
2016-08-15 18:12 ` [PATCH 15/22] IB/mlx5/odp: " Bhaktipriya Shridhar
@ 2016-08-19 15:49 ` Leon Romanovsky
0 siblings, 0 replies; 38+ messages in thread
From: Leon Romanovsky @ 2016-08-19 15:49 UTC (permalink / raw)
To: Bhaktipriya Shridhar
Cc: Yishai Hadas, Doug Ledford, Sean Hefty, Hal Rosenstock,
Jason Gunthorpe, Chuck Lever, Mark Bloch, Hans Westgaard Ry,
Christoph Lameter, Erez Shitrit, Haggai Eran, Florian Westphal,
Guy Shapiro, Eli Cohen, Or Gerlitz, Faisal Latif, Matan Barak,
Chien Tin Tung, Mustafa Ismail, Shiraz Saleem, Tatyana Nikolova,
Steve Wise, Mike Marciniszyn, Bart Van Assche, Yotam Kenneth,
Somnath Kotur, Moni Shoua, Shachar Raindel, Parav Pandit,
Sagi Grimberg, Christoph Hellwig, Dean Luick, Ira Weiny,
Kaike Wan, linux-rdma, linux-kernel, Tejun Heo
[-- Attachment #1: Type: text/plain, Size: 1464 bytes --]
On Mon, Aug 15, 2016 at 11:42:19PM +0530, Bhaktipriya Shridhar wrote:
> alloc_ordered_workqueue() with WQ_MEM_RECLAIM set, replaces
> deprecated create_singlethread_workqueue(). This is the identity
> conversion.
>
> The workqueue "mlx5_ib_page_fault_wq" queues work item &qp_pfault->work.
> It has been identity converted.
>
> WQ_MEM_RECLAIM has been set to ensure forward progress under
> memory pressure.
>
> Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
Thanks,
Acked-by: Leon Romanovsky <leonro@mellanox.com>
> ---
> drivers/infiniband/hw/mlx5/odp.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/infiniband/hw/mlx5/odp.c b/drivers/infiniband/hw/mlx5/odp.c
> index 34e79e7..cacb631 100644
> --- a/drivers/infiniband/hw/mlx5/odp.c
> +++ b/drivers/infiniband/hw/mlx5/odp.c
> @@ -782,8 +782,8 @@ void mlx5_ib_odp_remove_one(struct mlx5_ib_dev *ibdev)
>
> int __init mlx5_ib_odp_init(void)
> {
> - mlx5_ib_page_fault_wq =
> - create_singlethread_workqueue("mlx5_ib_page_faults");
> + mlx5_ib_page_fault_wq = alloc_ordered_workqueue("mlx5_ib_page_faults",
> + WQ_MEM_RECLAIM);
> if (!mlx5_ib_page_fault_wq)
> return -ENOMEM;
>
> --
> 2.1.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 38+ messages in thread
* [PATCH 16/22] IB/mlx4: Remove deprecated create_singlethread_workqueue
2016-08-15 17:57 [PATCH 00/22] Remove deprecated create_workqueue instances Bhaktipriya Shridhar
` (14 preceding siblings ...)
2016-08-15 18:12 ` [PATCH 15/22] IB/mlx5/odp: " Bhaktipriya Shridhar
@ 2016-08-15 18:12 ` Bhaktipriya Shridhar
2016-08-19 15:43 ` Leon Romanovsky
2016-08-15 18:13 ` [PATCH 17/22] IB/mlx4/mad: " Bhaktipriya Shridhar
` (8 subsequent siblings)
24 siblings, 1 reply; 38+ messages in thread
From: Bhaktipriya Shridhar @ 2016-08-15 18:12 UTC (permalink / raw)
To: Yishai Hadas, Doug Ledford, Sean Hefty, Hal Rosenstock,
Jason Gunthorpe, Leon Romanovsky, Chuck Lever, Mark Bloch,
Hans Westgaard Ry, Christoph Lameter, Erez Shitrit, Haggai Eran,
Florian Westphal, Guy Shapiro, Eli Cohen, Or Gerlitz,
Faisal Latif, Matan Barak, Chien Tin Tung, Mustafa Ismail,
Shiraz Saleem, Tatyana Nikolova, Steve Wise, Mike Marciniszyn,
Bart Van Assche, Yotam Kenneth, Somnath Kotur, Moni Shoua,
Shachar Raindel, Parav Pandit, Sagi Grimberg, Christoph Hellwig,
Dean Luick, Ira Weiny, Kaike Wan
Cc: linux-rdma, linux-kernel, Tejun Heo
alloc_ordered_workqueue() with WQ_MEM_RECLAIM set, replaces
deprecated create_singlethread_workqueue(). This is the identity
conversion.
The workqueue "wq" queues work items &dm[i]->work, &ew->work.
It has been identity converted.
WQ_MEM_RECLAIM has been set to ensure forward progress under
memory pressure.
Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
---
drivers/infiniband/hw/mlx4/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/infiniband/hw/mlx4/main.c b/drivers/infiniband/hw/mlx4/main.c
index 42a4607..f3876b79 100644
--- a/drivers/infiniband/hw/mlx4/main.c
+++ b/drivers/infiniband/hw/mlx4/main.c
@@ -3023,7 +3023,7 @@ static int __init mlx4_ib_init(void)
{
int err;
- wq = create_singlethread_workqueue("mlx4_ib");
+ wq = alloc_ordered_workqueue("mlx4_ib", WQ_MEM_RECLAIM);
if (!wq)
return -ENOMEM;
--
2.1.4
^ permalink raw reply related [flat|nested] 38+ messages in thread* Re: [PATCH 16/22] IB/mlx4: Remove deprecated create_singlethread_workqueue
2016-08-15 18:12 ` [PATCH 16/22] IB/mlx4: " Bhaktipriya Shridhar
@ 2016-08-19 15:43 ` Leon Romanovsky
0 siblings, 0 replies; 38+ messages in thread
From: Leon Romanovsky @ 2016-08-19 15:43 UTC (permalink / raw)
To: Bhaktipriya Shridhar
Cc: Yishai Hadas, Doug Ledford, Sean Hefty, Hal Rosenstock,
Jason Gunthorpe, Chuck Lever, Mark Bloch, Hans Westgaard Ry,
Christoph Lameter, Erez Shitrit, Haggai Eran, Florian Westphal,
Guy Shapiro, Eli Cohen, Or Gerlitz, Faisal Latif, Matan Barak,
Chien Tin Tung, Mustafa Ismail, Shiraz Saleem, Tatyana Nikolova,
Steve Wise, Mike Marciniszyn, Bart Van Assche, Yotam Kenneth,
Somnath Kotur, Moni Shoua, Shachar Raindel, Parav Pandit,
Sagi Grimberg, Christoph Hellwig, Dean Luick, Ira Weiny,
Kaike Wan, linux-rdma, linux-kernel, Tejun Heo
[-- Attachment #1: Type: text/plain, Size: 643 bytes --]
On Mon, Aug 15, 2016 at 11:42:48PM +0530, Bhaktipriya Shridhar wrote:
> alloc_ordered_workqueue() with WQ_MEM_RECLAIM set, replaces
> deprecated create_singlethread_workqueue(). This is the identity
> conversion.
>
> The workqueue "wq" queues work items &dm[i]->work, &ew->work.
> It has been identity converted.
>
> WQ_MEM_RECLAIM has been set to ensure forward progress under
> memory pressure.
>
> Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
> ---
> drivers/infiniband/hw/mlx4/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Thanks,
Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 38+ messages in thread
* [PATCH 17/22] IB/mlx4/mad: Remove deprecated create_singlethread_workqueue
2016-08-15 17:57 [PATCH 00/22] Remove deprecated create_workqueue instances Bhaktipriya Shridhar
` (15 preceding siblings ...)
2016-08-15 18:12 ` [PATCH 16/22] IB/mlx4: " Bhaktipriya Shridhar
@ 2016-08-15 18:13 ` Bhaktipriya Shridhar
2016-08-19 15:50 ` Leon Romanovsky
2016-08-15 18:13 ` [PATCH 18/22] IB/mlx4/mcg: " Bhaktipriya Shridhar
` (7 subsequent siblings)
24 siblings, 1 reply; 38+ messages in thread
From: Bhaktipriya Shridhar @ 2016-08-15 18:13 UTC (permalink / raw)
To: Yishai Hadas, Doug Ledford, Sean Hefty, Hal Rosenstock,
Jason Gunthorpe, Leon Romanovsky, Chuck Lever, Mark Bloch,
Hans Westgaard Ry, Christoph Lameter, Erez Shitrit, Haggai Eran,
Florian Westphal, Guy Shapiro, Eli Cohen, Or Gerlitz,
Faisal Latif, Matan Barak, Chien Tin Tung, Mustafa Ismail,
Shiraz Saleem, Tatyana Nikolova, Steve Wise, Mike Marciniszyn,
Bart Van Assche, Yotam Kenneth, Somnath Kotur, Moni Shoua,
Shachar Raindel, Parav Pandit, Sagi Grimberg, Christoph Hellwig,
Dean Luick, Ira Weiny, Kaike Wan
Cc: linux-rdma, linux-kernel, Tejun Heo
alloc_ordered_workqueue() with WQ_MEM_RECLAIM set, replaces
deprecated create_singlethread_workqueue(). This is the identity
conversion.
The workqueue "wq" queues work item &ctx->work and the workqueue "ud_wq"
queues work item &dm[i]->work.
Both the workqueues have been identity converted.
WQ_MEM_RECLAIM has been set to ensure forward progress under
memory pressure.
Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
---
drivers/infiniband/hw/mlx4/mad.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/infiniband/hw/mlx4/mad.c b/drivers/infiniband/hw/mlx4/mad.c
index 9c2e53d..35b1260 100644
--- a/drivers/infiniband/hw/mlx4/mad.c
+++ b/drivers/infiniband/hw/mlx4/mad.c
@@ -2070,7 +2070,7 @@ static int mlx4_ib_alloc_demux_ctx(struct mlx4_ib_dev *dev,
}
snprintf(name, sizeof name, "mlx4_ibt%d", port);
- ctx->wq = create_singlethread_workqueue(name);
+ ctx->wq = alloc_ordered_workqueue(name, WQ_MEM_RECLAIM);
if (!ctx->wq) {
pr_err("Failed to create tunnelling WQ for port %d\n", port);
ret = -ENOMEM;
@@ -2078,7 +2078,7 @@ static int mlx4_ib_alloc_demux_ctx(struct mlx4_ib_dev *dev,
}
snprintf(name, sizeof name, "mlx4_ibud%d", port);
- ctx->ud_wq = create_singlethread_workqueue(name);
+ ctx->ud_wq = alloc_ordered_workqueue(name, WQ_MEM_RECLAIM);
if (!ctx->ud_wq) {
pr_err("Failed to create up/down WQ for port %d\n", port);
ret = -ENOMEM;
--
2.1.4
^ permalink raw reply related [flat|nested] 38+ messages in thread* Re: [PATCH 17/22] IB/mlx4/mad: Remove deprecated create_singlethread_workqueue
2016-08-15 18:13 ` [PATCH 17/22] IB/mlx4/mad: " Bhaktipriya Shridhar
@ 2016-08-19 15:50 ` Leon Romanovsky
0 siblings, 0 replies; 38+ messages in thread
From: Leon Romanovsky @ 2016-08-19 15:50 UTC (permalink / raw)
To: Bhaktipriya Shridhar
Cc: Yishai Hadas, Doug Ledford, Sean Hefty, Hal Rosenstock,
Jason Gunthorpe, Chuck Lever, Mark Bloch, Hans Westgaard Ry,
Christoph Lameter, Erez Shitrit, Haggai Eran, Florian Westphal,
Guy Shapiro, Eli Cohen, Or Gerlitz, Faisal Latif, Matan Barak,
Chien Tin Tung, Mustafa Ismail, Shiraz Saleem, Tatyana Nikolova,
Steve Wise, Mike Marciniszyn, Bart Van Assche, Yotam Kenneth,
Somnath Kotur, Moni Shoua, Shachar Raindel, Parav Pandit,
Sagi Grimberg, Christoph Hellwig, Dean Luick, Ira Weiny,
Kaike Wan, linux-rdma, linux-kernel, Tejun Heo
[-- Attachment #1: Type: text/plain, Size: 1900 bytes --]
On Mon, Aug 15, 2016 at 11:43:10PM +0530, Bhaktipriya Shridhar wrote:
> alloc_ordered_workqueue() with WQ_MEM_RECLAIM set, replaces
> deprecated create_singlethread_workqueue(). This is the identity
> conversion.
>
> The workqueue "wq" queues work item &ctx->work and the workqueue "ud_wq"
> queues work item &dm[i]->work.
>
> Both the workqueues have been identity converted.
>
> WQ_MEM_RECLAIM has been set to ensure forward progress under
> memory pressure.
>
> Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
Thanks,
Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
> ---
> drivers/infiniband/hw/mlx4/mad.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/infiniband/hw/mlx4/mad.c b/drivers/infiniband/hw/mlx4/mad.c
> index 9c2e53d..35b1260 100644
> --- a/drivers/infiniband/hw/mlx4/mad.c
> +++ b/drivers/infiniband/hw/mlx4/mad.c
> @@ -2070,7 +2070,7 @@ static int mlx4_ib_alloc_demux_ctx(struct mlx4_ib_dev *dev,
> }
>
> snprintf(name, sizeof name, "mlx4_ibt%d", port);
> - ctx->wq = create_singlethread_workqueue(name);
> + ctx->wq = alloc_ordered_workqueue(name, WQ_MEM_RECLAIM);
> if (!ctx->wq) {
> pr_err("Failed to create tunnelling WQ for port %d\n", port);
> ret = -ENOMEM;
> @@ -2078,7 +2078,7 @@ static int mlx4_ib_alloc_demux_ctx(struct mlx4_ib_dev *dev,
> }
>
> snprintf(name, sizeof name, "mlx4_ibud%d", port);
> - ctx->ud_wq = create_singlethread_workqueue(name);
> + ctx->ud_wq = alloc_ordered_workqueue(name, WQ_MEM_RECLAIM);
> if (!ctx->ud_wq) {
> pr_err("Failed to create up/down WQ for port %d\n", port);
> ret = -ENOMEM;
> --
> 2.1.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 38+ messages in thread
* [PATCH 18/22] IB/mlx4/mcg: Remove deprecated create_singlethread_workqueue
2016-08-15 17:57 [PATCH 00/22] Remove deprecated create_workqueue instances Bhaktipriya Shridhar
` (16 preceding siblings ...)
2016-08-15 18:13 ` [PATCH 17/22] IB/mlx4/mad: " Bhaktipriya Shridhar
@ 2016-08-15 18:13 ` Bhaktipriya Shridhar
2016-08-19 15:50 ` Leon Romanovsky
2016-08-15 18:14 ` [PATCH 19/22] IB/nes: " Bhaktipriya Shridhar
` (6 subsequent siblings)
24 siblings, 1 reply; 38+ messages in thread
From: Bhaktipriya Shridhar @ 2016-08-15 18:13 UTC (permalink / raw)
To: Yishai Hadas, Doug Ledford, Sean Hefty, Hal Rosenstock,
Jason Gunthorpe, Leon Romanovsky, Chuck Lever, Mark Bloch,
Hans Westgaard Ry, Christoph Lameter, Erez Shitrit, Haggai Eran,
Florian Westphal, Guy Shapiro, Eli Cohen, Or Gerlitz,
Faisal Latif, Matan Barak, Chien Tin Tung, Mustafa Ismail,
Shiraz Saleem, Tatyana Nikolova, Steve Wise, Mike Marciniszyn,
Bart Van Assche, Yotam Kenneth, Somnath Kotur, Moni Shoua,
Shachar Raindel, Parav Pandit, Sagi Grimberg, Christoph Hellwig,
Dean Luick, Ira Weiny, Kaike Wan
Cc: linux-rdma, linux-kernel, Tejun Heo
alloc_ordered_workqueue() with WQ_MEM_RECLAIM set, replaces
deprecated create_singlethread_workqueue(). This is the identity
conversion.
The workqueue "mcg_wq" queues work items &group->work
and &group->timeout_work.
The workqueue "clean_wq" queues work item mcg_clean_task.
Both have been identity converted.
WQ_MEM_RECLAIM has been set to ensure forward progress under
memory pressure.
Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
---
drivers/infiniband/hw/mlx4/mcg.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/infiniband/hw/mlx4/mcg.c b/drivers/infiniband/hw/mlx4/mcg.c
index 8f7ad07..7d30be0 100644
--- a/drivers/infiniband/hw/mlx4/mcg.c
+++ b/drivers/infiniband/hw/mlx4/mcg.c
@@ -1045,7 +1045,7 @@ int mlx4_ib_mcg_port_init(struct mlx4_ib_demux_ctx *ctx)
atomic_set(&ctx->tid, 0);
sprintf(name, "mlx4_ib_mcg%d", ctx->port);
- ctx->mcg_wq = create_singlethread_workqueue(name);
+ ctx->mcg_wq = alloc_ordered_workqueue(name, WQ_MEM_RECLAIM);
if (!ctx->mcg_wq)
return -ENOMEM;
@@ -1246,7 +1246,7 @@ void clean_vf_mcast(struct mlx4_ib_demux_ctx *ctx, int slave)
int mlx4_ib_mcg_init(void)
{
- clean_wq = create_singlethread_workqueue("mlx4_ib_mcg");
+ clean_wq = alloc_ordered_workqueue("mlx4_ib_mcg", WQ_MEM_RECLAIM);
if (!clean_wq)
return -ENOMEM;
--
2.1.4
^ permalink raw reply related [flat|nested] 38+ messages in thread* Re: [PATCH 18/22] IB/mlx4/mcg: Remove deprecated create_singlethread_workqueue
2016-08-15 18:13 ` [PATCH 18/22] IB/mlx4/mcg: " Bhaktipriya Shridhar
@ 2016-08-19 15:50 ` Leon Romanovsky
0 siblings, 0 replies; 38+ messages in thread
From: Leon Romanovsky @ 2016-08-19 15:50 UTC (permalink / raw)
To: Bhaktipriya Shridhar
Cc: Yishai Hadas, Doug Ledford, Sean Hefty, Hal Rosenstock,
Jason Gunthorpe, Chuck Lever, Mark Bloch, Hans Westgaard Ry,
Christoph Lameter, Erez Shitrit, Haggai Eran, Florian Westphal,
Guy Shapiro, Eli Cohen, Or Gerlitz, Faisal Latif, Matan Barak,
Chien Tin Tung, Mustafa Ismail, Shiraz Saleem, Tatyana Nikolova,
Steve Wise, Mike Marciniszyn, Bart Van Assche, Yotam Kenneth,
Somnath Kotur, Moni Shoua, Shachar Raindel, Parav Pandit,
Sagi Grimberg, Christoph Hellwig, Dean Luick, Ira Weiny,
Kaike Wan, linux-rdma, linux-kernel, Tejun Heo
[-- Attachment #1: Type: text/plain, Size: 1815 bytes --]
On Mon, Aug 15, 2016 at 11:43:35PM +0530, Bhaktipriya Shridhar wrote:
> alloc_ordered_workqueue() with WQ_MEM_RECLAIM set, replaces
> deprecated create_singlethread_workqueue(). This is the identity
> conversion.
>
> The workqueue "mcg_wq" queues work items &group->work
> and &group->timeout_work.
>
> The workqueue "clean_wq" queues work item mcg_clean_task.
>
> Both have been identity converted.
>
> WQ_MEM_RECLAIM has been set to ensure forward progress under
> memory pressure.
>
> Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
> ---
Thanks,
Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
> drivers/infiniband/hw/mlx4/mcg.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/infiniband/hw/mlx4/mcg.c b/drivers/infiniband/hw/mlx4/mcg.c
> index 8f7ad07..7d30be0 100644
> --- a/drivers/infiniband/hw/mlx4/mcg.c
> +++ b/drivers/infiniband/hw/mlx4/mcg.c
> @@ -1045,7 +1045,7 @@ int mlx4_ib_mcg_port_init(struct mlx4_ib_demux_ctx *ctx)
>
> atomic_set(&ctx->tid, 0);
> sprintf(name, "mlx4_ib_mcg%d", ctx->port);
> - ctx->mcg_wq = create_singlethread_workqueue(name);
> + ctx->mcg_wq = alloc_ordered_workqueue(name, WQ_MEM_RECLAIM);
> if (!ctx->mcg_wq)
> return -ENOMEM;
>
> @@ -1246,7 +1246,7 @@ void clean_vf_mcast(struct mlx4_ib_demux_ctx *ctx, int slave)
>
> int mlx4_ib_mcg_init(void)
> {
> - clean_wq = create_singlethread_workqueue("mlx4_ib_mcg");
> + clean_wq = alloc_ordered_workqueue("mlx4_ib_mcg", WQ_MEM_RECLAIM);
> if (!clean_wq)
> return -ENOMEM;
>
> --
> 2.1.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 38+ messages in thread
* [PATCH 19/22] IB/nes: Remove deprecated create_singlethread_workqueue
2016-08-15 17:57 [PATCH 00/22] Remove deprecated create_workqueue instances Bhaktipriya Shridhar
` (17 preceding siblings ...)
2016-08-15 18:13 ` [PATCH 18/22] IB/mlx4/mcg: " Bhaktipriya Shridhar
@ 2016-08-15 18:14 ` Bhaktipriya Shridhar
2016-08-15 18:14 ` [PATCH 20/22] IB/ipoib: " Bhaktipriya Shridhar
` (5 subsequent siblings)
24 siblings, 0 replies; 38+ messages in thread
From: Bhaktipriya Shridhar @ 2016-08-15 18:14 UTC (permalink / raw)
To: Yishai Hadas, Doug Ledford, Sean Hefty, Hal Rosenstock,
Jason Gunthorpe, Leon Romanovsky, Chuck Lever, Mark Bloch,
Hans Westgaard Ry, Christoph Lameter, Erez Shitrit, Haggai Eran,
Florian Westphal, Guy Shapiro, Eli Cohen, Or Gerlitz,
Faisal Latif, Matan Barak, Chien Tin Tung, Mustafa Ismail,
Shiraz Saleem, Tatyana Nikolova, Steve Wise, Mike Marciniszyn,
Bart Van Assche, Yotam Kenneth, Somnath Kotur, Moni Shoua,
Shachar Raindel, Parav Pandit, Sagi Grimberg, Christoph Hellwig,
Dean Luick, Ira Weiny, Kaike Wan
Cc: linux-rdma, linux-kernel, Tejun Heo
alloc_ordered_workqueue() replaces deprecated
create_singlethread_workqueue().
The workqueue "event_wq" queues work item &event->event_work and the
workqueue "disconn_wq" queues work item work (maps to
g_cm_core->disconn_wq).
WQ_MEM_RECLAIM has not been set since the workqueues are not being used
on a memory reclaim path.
Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
---
drivers/infiniband/hw/nes/nes_cm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/infiniband/hw/nes/nes_cm.c b/drivers/infiniband/hw/nes/nes_cm.c
index 7f0aa23..57db9b3 100644
--- a/drivers/infiniband/hw/nes/nes_cm.c
+++ b/drivers/infiniband/hw/nes/nes_cm.c
@@ -2692,12 +2692,12 @@ static struct nes_cm_core *nes_cm_alloc_core(void)
nes_debug(NES_DBG_CM, "Init CM Core completed -- cm_core=%p\n", cm_core);
nes_debug(NES_DBG_CM, "Enable QUEUE EVENTS\n");
- cm_core->event_wq = create_singlethread_workqueue("nesewq");
+ cm_core->event_wq = alloc_ordered_workqueue("nesewq", 0);
if (!cm_core->event_wq)
goto out_free_cmcore;
cm_core->post_event = nes_cm_post_event;
nes_debug(NES_DBG_CM, "Enable QUEUE DISCONNECTS\n");
- cm_core->disconn_wq = create_singlethread_workqueue("nesdwq");
+ cm_core->disconn_wq = alloc_ordered_workqueue("nesdwq", 0);
if (!cm_core->disconn_wq)
goto out_free_wq;
--
2.1.4
^ permalink raw reply related [flat|nested] 38+ messages in thread* [PATCH 20/22] IB/ipoib: Remove deprecated create_singlethread_workqueue
2016-08-15 17:57 [PATCH 00/22] Remove deprecated create_workqueue instances Bhaktipriya Shridhar
` (18 preceding siblings ...)
2016-08-15 18:14 ` [PATCH 19/22] IB/nes: " Bhaktipriya Shridhar
@ 2016-08-15 18:14 ` Bhaktipriya Shridhar
2016-08-15 18:14 ` [PATCH 21/22] IB/ipoib_verbs: " Bhaktipriya Shridhar
` (4 subsequent siblings)
24 siblings, 0 replies; 38+ messages in thread
From: Bhaktipriya Shridhar @ 2016-08-15 18:14 UTC (permalink / raw)
To: Yishai Hadas, Doug Ledford, Sean Hefty, Hal Rosenstock,
Jason Gunthorpe, Leon Romanovsky, Chuck Lever, Mark Bloch,
Hans Westgaard Ry, Christoph Lameter, Erez Shitrit, Haggai Eran,
Florian Westphal, Guy Shapiro, Eli Cohen, Or Gerlitz,
Faisal Latif, Matan Barak, Chien Tin Tung, Mustafa Ismail,
Shiraz Saleem, Tatyana Nikolova, Steve Wise, Mike Marciniszyn,
Bart Van Assche, Yotam Kenneth, Somnath Kotur, Moni Shoua,
Shachar Raindel, Parav Pandit, Sagi Grimberg, Christoph Hellwig,
Dean Luick, Ira Weiny, Kaike Wan
Cc: linux-rdma, linux-kernel, Tejun Heo
alloc_ordered_workqueue() replaces deprecated
create_singlethread_workqueue().
The workqueue "ipoib_workqueue" that is used for all flush operstions
for the device.
WQ_MEM_RECLAIM has not been set since it is not being used on a memory
reclaim path.
Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
---
drivers/infiniband/ulp/ipoib/ipoib_main.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/infiniband/ulp/ipoib/ipoib_main.c b/drivers/infiniband/ulp/ipoib/ipoib_main.c
index 5f58c41..a8043a3 100644
--- a/drivers/infiniband/ulp/ipoib/ipoib_main.c
+++ b/drivers/infiniband/ulp/ipoib/ipoib_main.c
@@ -2197,7 +2197,8 @@ static int __init ipoib_init_module(void)
* its private workqueue, and we only queue up flush events
* on our global flush workqueue. This avoids the deadlocks.
*/
- ipoib_workqueue = create_singlethread_workqueue("ipoib_flush");
+ ipoib_workqueue = alloc_ordered_workqueue("ipoib_flush",
+ WQ_MEM_RECLAIM);
if (!ipoib_workqueue) {
ret = -ENOMEM;
goto err_fs;
--
2.1.4
^ permalink raw reply related [flat|nested] 38+ messages in thread* [PATCH 21/22] IB/ipoib_verbs: Remove deprecated create_singlethread_workqueue
2016-08-15 17:57 [PATCH 00/22] Remove deprecated create_workqueue instances Bhaktipriya Shridhar
` (19 preceding siblings ...)
2016-08-15 18:14 ` [PATCH 20/22] IB/ipoib: " Bhaktipriya Shridhar
@ 2016-08-15 18:14 ` Bhaktipriya Shridhar
2016-08-15 18:15 ` [PATCH 22/22] IB/mlx4/alias_GUID: " Bhaktipriya Shridhar
` (3 subsequent siblings)
24 siblings, 0 replies; 38+ messages in thread
From: Bhaktipriya Shridhar @ 2016-08-15 18:14 UTC (permalink / raw)
To: Yishai Hadas, Doug Ledford, Sean Hefty, Hal Rosenstock,
Jason Gunthorpe, Leon Romanovsky, Chuck Lever, Mark Bloch,
Hans Westgaard Ry, Christoph Lameter, Erez Shitrit, Haggai Eran,
Florian Westphal, Guy Shapiro, Eli Cohen, Or Gerlitz,
Faisal Latif, Matan Barak, Chien Tin Tung, Mustafa Ismail,
Shiraz Saleem, Tatyana Nikolova, Steve Wise, Mike Marciniszyn,
Bart Van Assche, Yotam Kenneth, Somnath Kotur, Moni Shoua,
Shachar Raindel, Parav Pandit, Sagi Grimberg, Christoph Hellwig,
Dean Luick, Ira Weiny, Kaike Wan
Cc: linux-rdma, linux-kernel, Tejun Heo
alloc_ordered_workqueue() with WQ_MEM_RECLAIM set, replaces
deprecated create_singlethread_workqueue(). This is the identity
conversion.
The workqueue "wq" queues mulitple work items viz &priv->restart_task,
&priv->cm.rx_reap_task, &priv->cm.skb_task, &priv->neigh_reap_task,
&priv->ah_reap_task, &priv->mcast_task and &priv->carrier_on_task.
The work items require strict execution ordering.
Hence, an ordered dedicated workqueue has been used.
WQ_MEM_RECLAIM has been set to ensure forward progress under
memory pressure.
Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
---
drivers/infiniband/ulp/ipoib/ipoib_verbs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/infiniband/ulp/ipoib/ipoib_verbs.c b/drivers/infiniband/ulp/ipoib/ipoib_verbs.c
index 1e7cbba..5737652 100644
--- a/drivers/infiniband/ulp/ipoib/ipoib_verbs.c
+++ b/drivers/infiniband/ulp/ipoib/ipoib_verbs.c
@@ -156,7 +156,7 @@ int ipoib_transport_dev_init(struct net_device *dev, struct ib_device *ca)
* the various IPoIB tasks assume they will never race against
* themselves, so always use a single thread workqueue
*/
- priv->wq = create_singlethread_workqueue("ipoib_wq");
+ priv->wq = alloc_ordered_workqueue("ipoib_wq", WQ_MEM_RECLAIM);
if (!priv->wq) {
printk(KERN_WARNING "ipoib: failed to allocate device WQ\n");
goto out_free_pd;
--
2.1.4
^ permalink raw reply related [flat|nested] 38+ messages in thread* [PATCH 22/22] IB/mlx4/alias_GUID: Remove deprecated create_singlethread_workqueue
2016-08-15 17:57 [PATCH 00/22] Remove deprecated create_workqueue instances Bhaktipriya Shridhar
` (20 preceding siblings ...)
2016-08-15 18:14 ` [PATCH 21/22] IB/ipoib_verbs: " Bhaktipriya Shridhar
@ 2016-08-15 18:15 ` Bhaktipriya Shridhar
2016-08-19 15:51 ` Leon Romanovsky
2016-08-15 23:11 ` [PATCH 00/22] Remove deprecated create_workqueue instances Tejun Heo
` (2 subsequent siblings)
24 siblings, 1 reply; 38+ messages in thread
From: Bhaktipriya Shridhar @ 2016-08-15 18:15 UTC (permalink / raw)
To: Yishai Hadas, Doug Ledford, Sean Hefty, Hal Rosenstock,
Jason Gunthorpe, Leon Romanovsky, Chuck Lever, Mark Bloch,
Hans Westgaard Ry, Christoph Lameter, Erez Shitrit, Haggai Eran,
Florian Westphal, Guy Shapiro, Eli Cohen, Or Gerlitz,
Faisal Latif, Matan Barak, Chien Tin Tung, Mustafa Ismail,
Shiraz Saleem, Tatyana Nikolova, Steve Wise, Mike Marciniszyn,
Bart Van Assche, Yotam Kenneth, Somnath Kotur, Moni Shoua,
Shachar Raindel, Parav Pandit, Sagi Grimberg, Christoph Hellwig,
Dean Luick, Ira Weiny, Kaike Wan
Cc: linux-rdma, linux-kernel, Tejun Heo
alloc_ordered_workqueue() with WQ_MEM_RECLAIM set, replaces
deprecated create_singlethread_workqueue(). This is the identity
conversion.
The workqueue "wq" queues work item that maps to alias_guid_work.
It has been identity converted.
WQ_MEM_RECLAIM has been set to ensure forward progress under
memory pressure.
Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
---
drivers/infiniband/hw/mlx4/alias_GUID.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/infiniband/hw/mlx4/alias_GUID.c b/drivers/infiniband/hw/mlx4/alias_GUID.c
index c74ef26..5e99390 100644
--- a/drivers/infiniband/hw/mlx4/alias_GUID.c
+++ b/drivers/infiniband/hw/mlx4/alias_GUID.c
@@ -881,7 +881,7 @@ int mlx4_ib_init_alias_guid_service(struct mlx4_ib_dev *dev)
snprintf(alias_wq_name, sizeof alias_wq_name, "alias_guid%d", i);
dev->sriov.alias_guid.ports_guid[i].wq =
- create_singlethread_workqueue(alias_wq_name);
+ alloc_ordered_workqueue(alias_wq_name, WQ_MEM_RECLAIM);
if (!dev->sriov.alias_guid.ports_guid[i].wq) {
ret = -ENOMEM;
goto err_thread;
--
2.1.4
^ permalink raw reply related [flat|nested] 38+ messages in thread* Re: [PATCH 22/22] IB/mlx4/alias_GUID: Remove deprecated create_singlethread_workqueue
2016-08-15 18:15 ` [PATCH 22/22] IB/mlx4/alias_GUID: " Bhaktipriya Shridhar
@ 2016-08-19 15:51 ` Leon Romanovsky
0 siblings, 0 replies; 38+ messages in thread
From: Leon Romanovsky @ 2016-08-19 15:51 UTC (permalink / raw)
To: Bhaktipriya Shridhar
Cc: Yishai Hadas, Doug Ledford, Sean Hefty, Hal Rosenstock,
Jason Gunthorpe, Chuck Lever, Mark Bloch, Hans Westgaard Ry,
Christoph Lameter, Erez Shitrit, Haggai Eran, Florian Westphal,
Guy Shapiro, Eli Cohen, Or Gerlitz, Faisal Latif, Matan Barak,
Chien Tin Tung, Mustafa Ismail, Shiraz Saleem, Tatyana Nikolova,
Steve Wise, Mike Marciniszyn, Bart Van Assche, Yotam Kenneth,
Somnath Kotur, Moni Shoua, Shachar Raindel, Parav Pandit,
Sagi Grimberg, Christoph Hellwig, Dean Luick, Ira Weiny,
Kaike Wan, linux-rdma, linux-kernel, Tejun Heo
[-- Attachment #1: Type: text/plain, Size: 1535 bytes --]
On Mon, Aug 15, 2016 at 11:45:06PM +0530, Bhaktipriya Shridhar wrote:
> alloc_ordered_workqueue() with WQ_MEM_RECLAIM set, replaces
> deprecated create_singlethread_workqueue(). This is the identity
> conversion.
>
> The workqueue "wq" queues work item that maps to alias_guid_work.
> It has been identity converted.
>
> WQ_MEM_RECLAIM has been set to ensure forward progress under
> memory pressure.
>
> Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
Thanks,
Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
> ---
> drivers/infiniband/hw/mlx4/alias_GUID.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/infiniband/hw/mlx4/alias_GUID.c b/drivers/infiniband/hw/mlx4/alias_GUID.c
> index c74ef26..5e99390 100644
> --- a/drivers/infiniband/hw/mlx4/alias_GUID.c
> +++ b/drivers/infiniband/hw/mlx4/alias_GUID.c
> @@ -881,7 +881,7 @@ int mlx4_ib_init_alias_guid_service(struct mlx4_ib_dev *dev)
>
> snprintf(alias_wq_name, sizeof alias_wq_name, "alias_guid%d", i);
> dev->sriov.alias_guid.ports_guid[i].wq =
> - create_singlethread_workqueue(alias_wq_name);
> + alloc_ordered_workqueue(alias_wq_name, WQ_MEM_RECLAIM);
> if (!dev->sriov.alias_guid.ports_guid[i].wq) {
> ret = -ENOMEM;
> goto err_thread;
> --
> 2.1.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 38+ messages in thread
* Re: [PATCH 00/22] Remove deprecated create_workqueue instances
2016-08-15 17:57 [PATCH 00/22] Remove deprecated create_workqueue instances Bhaktipriya Shridhar
` (21 preceding siblings ...)
2016-08-15 18:15 ` [PATCH 22/22] IB/mlx4/alias_GUID: " Bhaktipriya Shridhar
@ 2016-08-15 23:11 ` Tejun Heo
2016-08-19 15:48 ` Leon Romanovsky
2016-09-16 17:26 ` Doug Ledford
24 siblings, 0 replies; 38+ messages in thread
From: Tejun Heo @ 2016-08-15 23:11 UTC (permalink / raw)
To: Bhaktipriya Shridhar
Cc: Yishai Hadas, Doug Ledford, Sean Hefty, Hal Rosenstock,
Jason Gunthorpe, Leon Romanovsky, Chuck Lever, Mark Bloch,
Hans Westgaard Ry, Christoph Lameter, Erez Shitrit, Haggai Eran,
Florian Westphal, Guy Shapiro, Eli Cohen, Or Gerlitz,
Faisal Latif, Matan Barak, Chien Tin Tung, Mustafa Ismail,
Shiraz Saleem, Tatyana Nikolova, Steve Wise, Mike Marciniszyn,
Bart Van Assche, Yotam Kenneth, Somnath Kotur, Moni Shoua,
Shachar Raindel, Parav Pandit, Sagi Grimberg, Christoph Hellwig,
Dean Luick, Ira Weiny, Kaike Wan, linux-rdma, linux-kernel
Hello,
On Mon, Aug 15, 2016 at 11:27:01PM +0530, Bhaktipriya Shridhar wrote:
> This patch set removes the instances of deprecated
> create_singlethread_workqueue (scheduled for removal) in
> drivers/infiniband by making the appropriate conversions.
Patches generally look good to me. The only thing is that there seem
to be several patches where ordering doesn't seem necessary, at least
judging from the patch descriptions. It'd be great to clarify those.
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 38+ messages in thread* Re: [PATCH 00/22] Remove deprecated create_workqueue instances
2016-08-15 17:57 [PATCH 00/22] Remove deprecated create_workqueue instances Bhaktipriya Shridhar
` (22 preceding siblings ...)
2016-08-15 23:11 ` [PATCH 00/22] Remove deprecated create_workqueue instances Tejun Heo
@ 2016-08-19 15:48 ` Leon Romanovsky
2016-09-16 17:26 ` Doug Ledford
24 siblings, 0 replies; 38+ messages in thread
From: Leon Romanovsky @ 2016-08-19 15:48 UTC (permalink / raw)
To: Bhaktipriya Shridhar
Cc: Yishai Hadas, Doug Ledford, Sean Hefty, Hal Rosenstock,
Jason Gunthorpe, Chuck Lever, Mark Bloch, Hans Westgaard Ry,
Christoph Lameter, Erez Shitrit, Haggai Eran, Florian Westphal,
Guy Shapiro, Eli Cohen, Or Gerlitz, Faisal Latif, Matan Barak,
Chien Tin Tung, Mustafa Ismail, Shiraz Saleem, Tatyana Nikolova,
Steve Wise, Mike Marciniszyn, Bart Van Assche, Yotam Kenneth,
Somnath Kotur, Moni Shoua, Shachar Raindel, Parav Pandit,
Sagi Grimberg, Christoph Hellwig, Dean Luick, Ira Weiny,
Kaike Wan, linux-rdma, linux-kernel, Tejun Heo
[-- Attachment #1: Type: text/plain, Size: 1755 bytes --]
On Mon, Aug 15, 2016 at 11:27:01PM +0530, Bhaktipriya Shridhar wrote:
> This patch set removes the instances of deprecated
> create_singlethread_workqueue (scheduled for removal) in
> drivers/infiniband by making the appropriate conversions.
>
> Bhaktipriya Shridhar (22):
> IB/sa : Remove deprecated create_singlethread_workqueue
> IB/mad: Remove deprecated create_singlethread_workqueue
> IB/multicast: Remove deprecated create_singlethread_workqueue
> IB/ucma: Remove deprecated create_singlethread_workqueue
> IB/cma: Remove deprecated create_singlethread_workqueue
> IB/addr: Remove deprecated create_singlethread_workqueue
> IB/iwcm: Remove deprecated create_singlethread_workqueue
> iw_cxgb3: Remove deprecated create_singlethread_workqueue
> IB/qib: Remove deprecated create_singlethread_workqueue
> iw_cxgb4: Remove deprecated create_singlethread_workqueue
> IB/mthca: Remove deprecated create_singlethread_workqueue
> i40iw_main: Remove deprecated create_singlethread_workqueue
> i40iw_cm: Remove deprecated create_singlethread_workqueue
> IB/mlx5: Remove deprecated create_singlethread_workqueue
> IB/mlx5/odp: Remove deprecated create_singlethread_workqueue
> IB/mlx4: Remove deprecated create_singlethread_workqueue
> IB/mlx4/mad: Remove deprecated create_singlethread_workqueue
> IB/mlx4/mcg: Remove deprecated create_singlethread_workqueue
> IB/nes: Remove deprecated create_singlethread_workqueue
> IB/ipoib: Remove deprecated create_singlethread_workqueue
> IB/ipoib_verbs: Remove deprecated create_singlethread_workqueue
> IB/mlx4/alias_GUID: Remove deprecated create_singlethread_workqueue
Thank you for doing it in one patch set, it is much easier to review.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 38+ messages in thread* Re: [PATCH 00/22] Remove deprecated create_workqueue instances
2016-08-15 17:57 [PATCH 00/22] Remove deprecated create_workqueue instances Bhaktipriya Shridhar
` (23 preceding siblings ...)
2016-08-19 15:48 ` Leon Romanovsky
@ 2016-09-16 17:26 ` Doug Ledford
24 siblings, 0 replies; 38+ messages in thread
From: Doug Ledford @ 2016-09-16 17:26 UTC (permalink / raw)
To: Bhaktipriya Shridhar, Yishai Hadas, Sean Hefty, Hal Rosenstock,
Jason Gunthorpe, Leon Romanovsky, Chuck Lever, Mark Bloch,
Hans Westgaard Ry, Christoph Lameter, Erez Shitrit, Haggai Eran,
Florian Westphal, Guy Shapiro, Eli Cohen, Or Gerlitz,
Faisal Latif, Matan Barak, Chien Tin Tung, Mustafa Ismail,
Shiraz Saleem, Tatyana Nikolova, Steve Wise, Mike Marciniszyn,
Bart Van Assche, Yotam Kenneth, Somnath Kotur, Moni Shoua,
Shachar Raindel, Parav Pandit, Sagi Grimberg, Christoph Hellwig,
Dean Luick, Ira Weiny, Kaike Wan
Cc: linux-rdma, linux-kernel, Tejun Heo
[-- Attachment #1.1: Type: text/plain, Size: 3181 bytes --]
On 8/15/2016 1:57 PM, Bhaktipriya Shridhar wrote:
> This patch set removes the instances of deprecated
> create_singlethread_workqueue (scheduled for removal) in
> drivers/infiniband by making the appropriate conversions.
>
> Bhaktipriya Shridhar (22):
> IB/sa : Remove deprecated create_singlethread_workqueue
> IB/mad: Remove deprecated create_singlethread_workqueue
> IB/multicast: Remove deprecated create_singlethread_workqueue
> IB/ucma: Remove deprecated create_singlethread_workqueue
> IB/cma: Remove deprecated create_singlethread_workqueue
> IB/addr: Remove deprecated create_singlethread_workqueue
> IB/iwcm: Remove deprecated create_singlethread_workqueue
> iw_cxgb3: Remove deprecated create_singlethread_workqueue
> IB/qib: Remove deprecated create_singlethread_workqueue
> iw_cxgb4: Remove deprecated create_singlethread_workqueue
> IB/mthca: Remove deprecated create_singlethread_workqueue
> i40iw_main: Remove deprecated create_singlethread_workqueue
> i40iw_cm: Remove deprecated create_singlethread_workqueue
> IB/mlx5: Remove deprecated create_singlethread_workqueue
> IB/mlx5/odp: Remove deprecated create_singlethread_workqueue
> IB/mlx4: Remove deprecated create_singlethread_workqueue
> IB/mlx4/mad: Remove deprecated create_singlethread_workqueue
> IB/mlx4/mcg: Remove deprecated create_singlethread_workqueue
> IB/nes: Remove deprecated create_singlethread_workqueue
> IB/ipoib: Remove deprecated create_singlethread_workqueue
> IB/ipoib_verbs: Remove deprecated create_singlethread_workqueue
> IB/mlx4/alias_GUID: Remove deprecated create_singlethread_workqueue
>
> drivers/infiniband/core/addr.c | 2 +-
> drivers/infiniband/core/cma.c | 2 +-
> drivers/infiniband/core/iwcm.c | 2 +-
> drivers/infiniband/core/mad.c | 2 +-
> drivers/infiniband/core/multicast.c | 2 +-
> drivers/infiniband/core/sa_query.c | 2 +-
> drivers/infiniband/core/ucma.c | 3 ++-
> drivers/infiniband/hw/cxgb3/iwch_cm.c | 2 +-
> drivers/infiniband/hw/cxgb4/cm.c | 2 +-
> drivers/infiniband/hw/i40iw/i40iw_cm.c | 7 +++++--
> drivers/infiniband/hw/i40iw/i40iw_main.c | 2 +-
> drivers/infiniband/hw/mlx4/alias_GUID.c | 2 +-
> drivers/infiniband/hw/mlx4/mad.c | 4 ++--
> drivers/infiniband/hw/mlx4/main.c | 2 +-
> drivers/infiniband/hw/mlx4/mcg.c | 4 ++--
> drivers/infiniband/hw/mlx5/mr.c | 2 +-
> drivers/infiniband/hw/mlx5/odp.c | 4 ++--
> drivers/infiniband/hw/mthca/mthca_catas.c | 2 +-
> drivers/infiniband/hw/nes/nes_cm.c | 4 ++--
> drivers/infiniband/hw/qib/qib_init.c | 4 ++--
> drivers/infiniband/ulp/ipoib/ipoib_main.c | 3 ++-
> drivers/infiniband/ulp/ipoib/ipoib_verbs.c | 2 +-
> 22 files changed, 33 insertions(+), 28 deletions(-)
>
> --
> 2.1.4
>
The commit message of patch 20/22 was not matching what you actually
did. I fixed that up (the commit message, the patch was right), then
series applied.
--
Doug Ledford <dledford@redhat.com>
GPG Key ID: 0E572FDD
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 884 bytes --]
^ permalink raw reply [flat|nested] 38+ messages in thread