[PATCH 1/30] ACPI-processor: Use kmalloc_array() in acpi_processor_get_performance_states()

SF Markus Elfring
2016-09-10T09:36:51Z

Date: Tue, 6 Sep 2016 10:20:10 +0200

* A multiplication for the size determination of a memory allocation
indicated that an array data structure should be processed.
Thus reuse the corresponding function "kmalloc_array".

This issue was detected by using the Coccinelle software.

* Replace the specification of a data structure by a pointer dereference
to make the corresponding size determination a bit safer according to
the Linux coding style convention.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/acpi/processor_perflib.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/acpi/processor_perflib.c b/drivers/acpi/processor_perflib.c
index bb01dea..78f9025 100644
--- a/drivers/acpi/processor_perflib.c
+++ b/drivers/acpi/processor_perflib.c
@@ -346,9 +346,9 @@ static int acpi_processor_get_performance_states(struct acpi_processor *pr)
pss->package.count));

pr->performance->state_count = pss->package.count;
- pr->performance->states =
- kmalloc(sizeof(struct acpi_processor_px) * pss->package.count,
- GFP_KERNEL);
+ pr->performance->states = kmalloc_array(pss->package.count,
+ sizeof(*pr->performance->states),
+ GFP_KERNEL);
if (!pr->performance->states) {
result = -ENOMEM;
goto end;
--
2.10.0