[PATCH 2/30] ACPI-processor: Improve two size determinations in acpi_processor_get_performance_states()

SF Markus Elfring
2016-09-10T09:36:57Z

Date: Tue, 6 Sep 2016 11:11:12 +0200

Replace the specification of a data structure by pointer dereferences
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/acpi/processor_perflib.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/acpi/processor_perflib.c b/drivers/acpi/processor_perflib.c
index 78f9025..004e24c 100644
--- a/drivers/acpi/processor_perflib.c
+++ b/drivers/acpi/processor_perflib.c
@@ -358,7 +358,7 @@ static int acpi_processor_get_performance_states(struct acpi_processor *pr)

struct acpi_processor_px *px = &(pr->performance->states[i]);

- state.length = sizeof(struct acpi_processor_px);
+ state.length = sizeof(*px);
state.pointer = px;

ACPI_DEBUG_PRINT((ACPI_DB_INFO, "Extracting state %d\n", i));
@@ -400,7 +400,8 @@ static int acpi_processor_get_performance_states(struct acpi_processor *pr)
* Copy this valid entry over last_invalid entry
*/
memcpy(&(pr->performance->states[last_invalid]),
- px, sizeof(struct acpi_processor_px));
+ px,
+ sizeof(*px));
++last_invalid;
}
}
--
2.10.0