From: Jiri Slaby <jirislaby@kernel.org>
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>
Subject: Re: [PATCH] serial: Convert serial_rs485 to kernel doc
Date: Tue, 27 Sep 2022 07:16:25 +0200 [thread overview]
Message-ID: <0432cfc3-88e2-5d36-539a-757017b3089d@kernel.org> (raw)
In-Reply-To: <20220926123735.50804-1-ilpo.jarvinen@linux.intel.com>
On 26. 09. 22, 14:37, Ilpo Järvinen wrote:
> Convert struct serial_rs485 comments to kernel doc format.
It'd be nice if you referenced the struct from Documentation/, so that
it is: 1) checked, and 2) rendered somewhere.
> Suggested-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
>
> ---
> include/uapi/linux/serial.h | 61 +++++++++++++++++++++++++++++----------------
> 1 file changed, 40 insertions(+), 21 deletions(-)
>
> diff --git a/include/uapi/linux/serial.h b/include/uapi/linux/serial.h
> index cea06924b295..67d4bc663521 100644
> --- a/include/uapi/linux/serial.h
> +++ b/include/uapi/linux/serial.h
> @@ -107,37 +107,56 @@ struct serial_icounter_struct {
> int reserved[9];
> };
>
> -/*
> +/**
> + * struct serial_rs485 - serial interface for controlling RS485 settings.
...
thanks,
--
js
suse labs
prev parent reply other threads:[~2022-09-27 5:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-26 12:37 [PATCH] serial: Convert serial_rs485 to kernel doc Ilpo Järvinen
2022-09-27 5:16 ` Jiri Slaby [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0432cfc3-88e2-5d36-539a-757017b3089d@kernel.org \
--to=jirislaby@kernel.org \
--cc=andy.shevchenko@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox