From: "Suthikulpanit, Suravee" <suravee.suthikulpanit@amd.com>
To: Weinan Liu <wnliu@google.com>
Cc: chriscli@google.com, dantuluris@google.com,
iommu@lists.linux.dev, jay.chen@amd.com, jgg@nvidia.com,
jon.grimm@amd.com, joro@8bytes.org, kevin.tian@intel.com,
kpsingh@google.com, linux-kernel@vger.kernel.org,
nicolinc@nvidia.com, sairaj.arunkodilkar@amd.com,
santosh.shukla@amd.com, vasant.hegde@amd.com, wvw@google.com,
yi.l.liu@intel.com
Subject: Re: [PATCH 4/22] iommu/amd: Introduce IOMMUFD vIOMMU support for AMD
Date: Tue, 12 May 2026 22:14:29 +0700 [thread overview]
Message-ID: <0433004e-b0d2-4ef4-b382-0d2b577362a7@amd.com> (raw)
In-Reply-To: <20260407064607.611771-1-wnliu@google.com>
On 4/7/2026 1:46 PM, Weinan Liu wrote:
> On Mon, Mar 30, 2026 at 1:43 AM Suravee Suthikulpanit <suravee.suthikulpanit@amd.com> wrote:
>
>> diff --git a/drivers/iommu/amd/iommufd.c b/drivers/iommu/amd/iommufd.c
>> index ad627fd5ccc7..e7ffa7e8915b 100644
>> --- a/drivers/iommu/amd/iommufd.c
>> +++ b/drivers/iommu/amd/iommufd.c
>> @@ -34,6 +34,9 @@ void *amd_iommufd_hw_info(struct device *dev, u32 *length, u32 *type)
>>
>> size_t amd_iommufd_get_viommu_size(struct device *dev, enum iommu_viommu_type viommu_type)
>> {
>> + if (viommu_type != IOMMU_VIOMMU_TYPE_AMD)
>> + return 0;
>> +
>
> It should also return 0 here if amd_viommu_init() fails or if amd_iommu_viommu is false.
I'll fix this in V2.
Thanks,
Suravee
parent reply other threads:[~2026-05-12 15:14 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20260407064607.611771-1-wnliu@google.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0433004e-b0d2-4ef4-b382-0d2b577362a7@amd.com \
--to=suravee.suthikulpanit@amd.com \
--cc=chriscli@google.com \
--cc=dantuluris@google.com \
--cc=iommu@lists.linux.dev \
--cc=jay.chen@amd.com \
--cc=jgg@nvidia.com \
--cc=jon.grimm@amd.com \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=kpsingh@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolinc@nvidia.com \
--cc=sairaj.arunkodilkar@amd.com \
--cc=santosh.shukla@amd.com \
--cc=vasant.hegde@amd.com \
--cc=wnliu@google.com \
--cc=wvw@google.com \
--cc=yi.l.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox