From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2F1493C4578 for ; Wed, 25 Mar 2026 15:23:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774452182; cv=none; b=P6tOb2Q5U8S++ymFzSYfPoi+MwSC5ouMk65uAyTFRzwqLnrp1ftSUaW0JtQWP9v133M8qip+njLJgEv4k46tfY+R8kqfF2HuhL0aGnGe1DQ3eXn9jmVwbPp5JMiA7fNX6SNcztLwpMJqAV47fClVZL9oGGzYvKfA/SFIKgoaWmg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774452182; c=relaxed/simple; bh=oTwKPZot8IGlH5BDcbmz4Mk8U0uoED5BNZV7Zy8YYDI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=gC20WcW4rW5zBjPWTZ0I9siTomOOlCXl/oHHo7fRQ9P3sOw75TBwhlmv4iOkRtUviXoTPMB0FPcxRU/6l6POm5JEprDScnyknMy3JPGA5qwquAmL9dXarcIgUikgK1SBnSltdUdAWypqKrkLWx4HzX9WVvzZoc5syyJZX3vjSm8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=eVYOI9lb; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="eVYOI9lb" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 65D4BC4CEF7; Wed, 25 Mar 2026 15:22:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1774452181; bh=oTwKPZot8IGlH5BDcbmz4Mk8U0uoED5BNZV7Zy8YYDI=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=eVYOI9lbLQellrI0qrShwRe7VmWibuaTbMIOGD8J5a5QoCHSEOkiM6Mt3S93TjKRu uFujU2H+zsMO5NfUQ6bmyUhvYzhp6R0QEwJeN2fZrUIIhzeDu+dXFgtib6JahKYprk 3UHh8iONJyWa3QI/Oqno7C5JqKLkLRZf9El3tWK9G2XPR4Cf2xg6qpJpKhxh8VCyHp /PtVBXfvttM0pZXsPVa3eLwdilnWj6jo837amr3WBuVB/mmcV91J8PWuUqXiJcSKZB /7fuwexWaXULVK6+Lwq6wYy+RiFeaTm1DmtcCS86ToDji3ZwbuwrfJp9NoXfX/rxFZ AHz4YP7EqPFEw== Message-ID: <0437ad42-612e-461f-906d-6757eb19a8de@kernel.org> Date: Wed, 25 Mar 2026 16:22:55 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH mm-new v8 2/4] mm: khugepaged: refine scan progress number To: "Lorenzo Stoakes (Oracle)" Cc: Andrew Morton , Vernon Yang , Wei Yang , lorenzo.stoakes@oracle.com, ziy@nvidia.com, dev.jain@arm.com, baohua@kernel.org, lance.yang@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Vernon Yang References: <20260221093918.1456187-3-vernon2gm@gmail.com> <20260224035247.r6mxsfcpiev4wnce@master> <1da56bbb-9211-42d7-9b08-3ee56d2b538d@kernel.org> <8a5277e0-d70e-4849-9763-ed90e350a118@kernel.org> <22dccc17-787c-448e-a571-23c7a9afeaff@lucifer.local> <20260325080930.a205fca9e7e61c4a793f5228@linux-foundation.org> <3cf94628-3c6a-43ed-9fc1-29bd5a911497@kernel.org> <8d2e809c-e4c8-4d35-a2ae-62777b6dfbcc@lucifer.local> From: "David Hildenbrand (Arm)" Content-Language: en-US Autocrypt: addr=david@kernel.org; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzS5EYXZpZCBIaWxk ZW5icmFuZCAoQ3VycmVudCkgPGRhdmlkQGtlcm5lbC5vcmc+wsGQBBMBCAA6AhsDBQkmWAik AgsJBBUKCQgCFgICHgUCF4AWIQQb2cqtc1xMOkYN/MpN3hD3AP+DWgUCaYJt/AIZAQAKCRBN 3hD3AP+DWriiD/9BLGEKG+N8L2AXhikJg6YmXom9ytRwPqDgpHpVg2xdhopoWdMRXjzOrIKD g4LSnFaKneQD0hZhoArEeamG5tyo32xoRsPwkbpIzL0OKSZ8G6mVbFGpjmyDLQCAxteXCLXz ZI0VbsuJKelYnKcXWOIndOrNRvE5eoOfTt2XfBnAapxMYY2IsV+qaUXlO63GgfIOg8RBaj7x 3NxkI3rV0SHhI4GU9K6jCvGghxeS1QX6L/XI9mfAYaIwGy5B68kF26piAVYv/QZDEVIpo3t7 /fjSpxKT8plJH6rhhR0epy8dWRHk3qT5tk2P85twasdloWtkMZ7FsCJRKWscm1BLpsDn6EQ4 jeMHECiY9kGKKi8dQpv3FRyo2QApZ49NNDbwcR0ZndK0XFo15iH708H5Qja/8TuXCwnPWAcJ DQoNIDFyaxe26Rx3ZwUkRALa3iPcVjE0//TrQ4KnFf+lMBSrS33xDDBfevW9+Dk6IISmDH1R HFq2jpkN+FX/PE8eVhV68B2DsAPZ5rUwyCKUXPTJ/irrCCmAAb5Jpv11S7hUSpqtM/6oVESC 3z/7CzrVtRODzLtNgV4r5EI+wAv/3PgJLlMwgJM90Fb3CB2IgbxhjvmB1WNdvXACVydx55V7 LPPKodSTF29rlnQAf9HLgCphuuSrrPn5VQDaYZl4N/7zc2wcWM7BTQRVy5+RARAA59fefSDR 9nMGCb9LbMX+TFAoIQo/wgP5XPyzLYakO+94GrgfZjfhdaxPXMsl2+o8jhp/hlIzG56taNdt VZtPp3ih1AgbR8rHgXw1xwOpuAd5lE1qNd54ndHuADO9a9A0vPimIes78Hi1/yy+ZEEvRkHk /kDa6F3AtTc1m4rbbOk2fiKzzsE9YXweFjQvl9p+AMw6qd/iC4lUk9g0+FQXNdRs+o4o6Qvy iOQJfGQ4UcBuOy1IrkJrd8qq5jet1fcM2j4QvsW8CLDWZS1L7kZ5gT5EycMKxUWb8LuRjxzZ 3QY1aQH2kkzn6acigU3HLtgFyV1gBNV44ehjgvJpRY2cC8VhanTx0dZ9mj1YKIky5N+C0f21 zvntBqcxV0+3p8MrxRRcgEtDZNav+xAoT3G0W4SahAaUTWXpsZoOecwtxi74CyneQNPTDjNg azHmvpdBVEfj7k3p4dmJp5i0U66Onmf6mMFpArvBRSMOKU9DlAzMi4IvhiNWjKVaIE2Se9BY FdKVAJaZq85P2y20ZBd08ILnKcj7XKZkLU5FkoA0udEBvQ0f9QLNyyy3DZMCQWcwRuj1m73D sq8DEFBdZ5eEkj1dCyx+t/ga6x2rHyc8Sl86oK1tvAkwBNsfKou3v+jP/l14a7DGBvrmlYjO 59o3t6inu6H7pt7OL6u6BQj7DoMAEQEAAcLBfAQYAQgAJgIbDBYhBBvZyq1zXEw6Rg38yk3e EPcA/4NaBQJonNqrBQkmWAihAAoJEE3eEPcA/4NaKtMQALAJ8PzprBEXbXcEXwDKQu+P/vts IfUb1UNMfMV76BicGa5NCZnJNQASDP/+bFg6O3gx5NbhHHPeaWz/VxlOmYHokHodOvtL0WCC 8A5PEP8tOk6029Z+J+xUcMrJClNVFpzVvOpb1lCbhjwAV465Hy+NUSbbUiRxdzNQtLtgZzOV Zw7jxUCs4UUZLQTCuBpFgb15bBxYZ/BL9MbzxPxvfUQIPbnzQMcqtpUs21CMK2PdfCh5c4gS sDci6D5/ZIBw94UQWmGpM/O1ilGXde2ZzzGYl64glmccD8e87OnEgKnH3FbnJnT4iJchtSvx yJNi1+t0+qDti4m88+/9IuPqCKb6Stl+s2dnLtJNrjXBGJtsQG/sRpqsJz5x1/2nPJSRMsx9 5YfqbdrJSOFXDzZ8/r82HgQEtUvlSXNaXCa95ez0UkOG7+bDm2b3s0XahBQeLVCH0mw3RAQg r7xDAYKIrAwfHHmMTnBQDPJwVqxJjVNr7yBic4yfzVWGCGNE4DnOW0vcIeoyhy9vnIa3w1uZ 3iyY2Nsd7JxfKu1PRhCGwXzRw5TlfEsoRI7V9A8isUCoqE2Dzh3FvYHVeX4Us+bRL/oqareJ CIFqgYMyvHj7Q06kTKmauOe4Nf0l0qEkIuIzfoLJ3qr5UyXc2hLtWyT9Ir+lYlX9efqh7mOY qIws/H2t In-Reply-To: <8d2e809c-e4c8-4d35-a2ae-62777b6dfbcc@lucifer.local> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 3/25/26 16:20, Lorenzo Stoakes (Oracle) wrote: > On Wed, Mar 25, 2026 at 04:17:21PM +0100, David Hildenbrand (Arm) wrote: >> On 3/25/26 16:09, Andrew Morton wrote: >>> >> >> +1, I could have sworn we brought that up before. :) >> >>> >>> Oh. I've never really received that message, at least not at all >>> clearly. >>> >>> I've been hoping that the -fix patches are actually pro-reviewer, for >>> those reviewers who have looked at the previous version. A full resend >>> of something you've already looked at is quite annoying! >>> >>> I try to mitigate that by sending the >>> heres-what-you-changed-since-last-time replies. It's a little more >>> work at this end, but that's not at all a problem. >>> >>> I see a couple of options here >>> >>> a) I can fold the -fix into the base patch then send out the >>> resulting diff as a reply-to-all. >>> >>> b) We can just deprecate the -fix things and ask people for full >>> resends. >>> >>> It depends on what people prefer. How do we determine that? >> >> I like "fix" for smaller "obvious" stuff where a resend is really just >> noise. >> >> But for bigger stuff I prefer a full resend (we can still have these >> temporary fixups, but for reviewers a follow-up resend is better). > > Yeah, it's really about being able to come to a series later and be able to > comment line-by-line. > > Really larger stuff should be resent I think, esp. if there's multiple > fixes in the series. > > A reply with the same-patch-but-with-fix-applied would definitely be > useful! Right, for completeness, this is what we had in an off-list thread: " Not sure if that's a problem for others, but I got the feeling that this escalated a bit lately. I know, that we prefer fixups to sort out smaller stuff. So far so good. In the last time there were some series where I was seriously completely lost which state of the patches would go upstream, or what I should even review, because there were just fixups over fixups. Fixups are nice, but for someone reviewing a series, too many fixups (either as inline patch or even worse, as independent patches) just causes a mess. It also gives the impression of "this is mostly done, so don't waste your time reviewing it anymore." --- "just the finishing touches" --- "don't jump in late and cause trouble". " -- Cheers, David