From: Maximilian Luz <luzmaximilian@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Blaž Hrastnik" <blaz@mxxn.io>,
"Dorian Stoll" <dorian.stoll@tmsp.io>
Subject: Re: [RFC PATCH 8/9] surface_aggregator: Add DebugFS interface
Date: Thu, 24 Sep 2020 20:44:20 +0200 [thread overview]
Message-ID: <043f9a77-784d-e887-19e0-57e42ff6bddc@gmail.com> (raw)
In-Reply-To: <CAK8P3a3HWjyaxwN3gyFEcJ9P=iHPvYXsL=C2kEg1hDmJvNm1tQ@mail.gmail.com>
On 9/24/20 9:41 AM, Arnd Bergmann wrote:
> On Thu, Sep 24, 2020 at 12:23 AM Maximilian Luz <luzmaximilian@gmail.com> wrote:
>> On 9/23/20 8:51 PM, Arnd Bergmann wrote:
>>> On Wed, Sep 23, 2020 at 8:29 PM Maximilian Luz <luzmaximilian@gmail.com> wrote:
>>>> On 9/23/20 6:48 PM, Arnd Bergmann wrote:
>>>
>>> The version I showed avoids the pointers and is compatible with
>>> 32-bit user space.
>>
>> I'm not completely convinced yet that the read/write approach is the way
>> I want to do it, especially with Greg suggesting a misc device, but I'll
>> keep your solution in mind.
>
> In case of a character device, I'd go with an ioctl to keep it extensible.
>
> The read/write based interface is what I'd use in debugfs.
Perfect, thanks!
I'll follow Greg's suggestion and create a misc device, and then go for
the IOCTL interface as you suggest.
Thanks again,
Max
next prev parent reply other threads:[~2020-09-24 18:44 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-23 15:15 [RFC PATCH 0/9] Add support for Microsoft Surface System Aggregator Module Maximilian Luz
2020-09-23 15:15 ` [RFC PATCH 1/9] misc: Add Surface Aggregator subsystem Maximilian Luz
2020-09-23 16:57 ` Greg Kroah-Hartman
2020-09-23 20:34 ` Maximilian Luz
2020-09-24 6:48 ` Greg Kroah-Hartman
2020-09-24 18:16 ` Maximilian Luz
2020-09-23 15:15 ` [RFC PATCH 2/9] surface_aggregator: Add control packet allocation chaching Maximilian Luz
2020-09-23 15:15 ` [RFC PATCH 3/9] surface_aggregator: Add event item " Maximilian Luz
2020-09-23 15:15 ` [RFC PATCH 4/9] surface_aggregator: Add trace points Maximilian Luz
2020-09-23 20:07 ` Steven Rostedt
2020-09-23 23:43 ` Maximilian Luz
2020-09-23 15:15 ` [RFC PATCH 5/9] surface_aggregator: Add error injection capabilities Maximilian Luz
2020-09-23 17:45 ` Greg Kroah-Hartman
2020-09-23 21:28 ` Maximilian Luz
2020-09-23 15:15 ` [RFC PATCH 6/9] surface_aggregator: Add dedicated bus and device type Maximilian Luz
2020-09-23 17:33 ` Greg Kroah-Hartman
2020-09-23 21:12 ` Maximilian Luz
2020-09-24 7:12 ` Greg Kroah-Hartman
2020-09-24 18:15 ` Maximilian Luz
2020-09-23 15:15 ` [RFC PATCH 7/9] docs: driver-api: Add Surface Aggregator subsystem documentation Maximilian Luz
2020-09-23 15:15 ` [RFC PATCH 8/9] surface_aggregator: Add DebugFS interface Maximilian Luz
2020-09-23 16:14 ` Greg Kroah-Hartman
2020-09-23 18:03 ` Maximilian Luz
2020-09-23 18:29 ` Greg Kroah-Hartman
2020-09-23 22:06 ` Maximilian Luz
2020-09-24 6:46 ` Greg Kroah-Hartman
2020-09-24 18:40 ` Maximilian Luz
2020-09-23 16:48 ` Arnd Bergmann
2020-09-23 18:29 ` Maximilian Luz
2020-09-23 18:51 ` Arnd Bergmann
2020-09-23 22:23 ` Maximilian Luz
2020-09-24 7:41 ` Arnd Bergmann
2020-09-24 18:44 ` Maximilian Luz [this message]
2020-09-23 15:15 ` [RFC PATCH 9/9] surface_aggregator: Add Surface ACPI Notify client driver Maximilian Luz
2020-09-23 15:30 ` [RFC PATCH 0/9] Add support for Microsoft Surface System Aggregator Module Arnd Bergmann
2020-09-23 15:43 ` Maximilian Luz
2020-09-23 19:43 ` Arnd Bergmann
2020-09-23 23:28 ` Maximilian Luz
2020-09-24 8:26 ` Arnd Bergmann
2020-09-24 18:59 ` Maximilian Luz
2020-09-24 19:38 ` Arnd Bergmann
2020-09-24 21:07 ` Maximilian Luz
2020-09-25 14:53 ` Andy Shevchenko
2020-09-24 8:30 ` Andy Shevchenko
2020-09-24 19:17 ` Maximilian Luz
2020-09-25 14:58 ` Andy Shevchenko
2020-09-25 15:41 ` Maximilian Luz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=043f9a77-784d-e887-19e0-57e42ff6bddc@gmail.com \
--to=luzmaximilian@gmail.com \
--cc=arnd@arndb.de \
--cc=blaz@mxxn.io \
--cc=dorian.stoll@tmsp.io \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox