From: Tom Lendacky <thomas.lendacky@amd.com>
To: Dionna Amalie Glaze <dionnaglaze@google.com>
Cc: linux-kernel@vger.kernel.org, x86@kernel.org,
Paolo Bonzini <pbonzini@redhat.com>,
Joerg Roedel <jroedel@suse.de>, Peter Gonda <pgonda@google.com>,
Thomas Gleixner <tglx@linutronix.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
Ingo Molnar <mingo@redhat.com>,
Borislav Petkov <Borislav.Petkov@amd.com>,
"H. Peter Anvin" <hpa@zytor.com>,
Venu Busireddy <venu.busireddy@oracle.com>,
Michael Roth <michael.roth@amd.com>,
"Kirill A. Shutemov" <kirill@shutemov.name>,
Michael Sterritt <sterritt@google.com>
Subject: Re: [PATCH v14 1/3] virt/coco/sev-guest: Add throttling awareness
Date: Tue, 14 Feb 2023 08:27:47 -0600 [thread overview]
Message-ID: <046992ea-c201-016d-ee59-e1af72d8a6d8@amd.com> (raw)
In-Reply-To: <CAAH4kHYrz2pZzwAqoy-mpA_om1+tO8qB-4ZHc9jKh_ucwZe3OQ@mail.gmail.com>
On 2/13/23 16:28, Dionna Amalie Glaze wrote:
>>
>> This should really be a new, separate patch.
>>
>
> I had it as a separate patch and squashed since I felt it necessary to
> be considered still a "Fixes" patch. Should both claim to fix the same
> patch?
If they both fix a bug, yes. You can have multiple patches that fix
different bugs that were all introduced by one commit.
Thanks,
Tom
>
>>
>> It looks like you will ensure throttling by continually calling the
>> hypervisor for 60 seconds, shouldn't there be a delay here?
>>
>
> I can change cond_resched() to sleep_timeout_killable(some_constant)
>
>>> - rc = snp_issue_guest_request(exit_code, &snp_dev->input, &err);
>>> + cond_resched();
>>> + goto retry;
>>>
>>> + }
>>
>> Nit, add a blank line here.
>>
>
> Will do.
>
>> Thanks,
>> Tom
>>
>
>
next prev parent reply other threads:[~2023-02-14 14:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-13 17:25 [PATCH v14 0/3] Add throttling detection to sev-guest Dionna Glaze
2023-02-13 17:25 ` [PATCH v14 1/3] virt/coco/sev-guest: Add throttling awareness Dionna Glaze
2023-02-13 21:43 ` Tom Lendacky
2023-02-13 22:28 ` Dionna Amalie Glaze
2023-02-14 14:27 ` Tom Lendacky [this message]
2023-02-13 17:25 ` [PATCH v14 2/3] crypto: ccp - Name -1 return value as SEV_RET_NO_FW_CALL Dionna Glaze
2023-02-13 17:25 ` [PATCH v14 3/3] x86/sev: Change snp_guest_issue_request's fw_err Dionna Glaze
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=046992ea-c201-016d-ee59-e1af72d8a6d8@amd.com \
--to=thomas.lendacky@amd.com \
--cc=Borislav.Petkov@amd.com \
--cc=dave.hansen@linux.intel.com \
--cc=dionnaglaze@google.com \
--cc=hpa@zytor.com \
--cc=jroedel@suse.de \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.roth@amd.com \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=pgonda@google.com \
--cc=sterritt@google.com \
--cc=tglx@linutronix.de \
--cc=venu.busireddy@oracle.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox