From: sunran001@208suo.com
To: gregkh@linuxfoundation.org
Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] tty: serial: add missing clk_put()
Date: Tue, 18 Jul 2023 15:55:23 +0800 [thread overview]
Message-ID: <047273ae4e4c25eb7b81fd69d761161e@208suo.com> (raw)
In-Reply-To: <20230718075401.16668-1-xujianghui@cdjrlc.com>
This patch fixes the following Coccinelle error:
./drivers/tty/serial/bcm63xx_uart.c:854:2-8: ERROR: missing clk_put;
clk_get on line 849 and execution via conditional on line 853
Signed-off-by: Ran Sun <sunran001@208suo.com>
---
drivers/tty/serial/bcm63xx_uart.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/tty/serial/bcm63xx_uart.c
b/drivers/tty/serial/bcm63xx_uart.c
index 55e82d0bf92d..7353b683952d 100644
--- a/drivers/tty/serial/bcm63xx_uart.c
+++ b/drivers/tty/serial/bcm63xx_uart.c
@@ -851,6 +851,7 @@ static int bcm_uart_probe(struct platform_device
*pdev)
clk = of_clk_get(pdev->dev.of_node, 0);
if (IS_ERR(clk))
+ clk_put(clk);
return -ENODEV;
port->iotype = UPIO_MEM;
next parent reply other threads:[~2023-07-18 7:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230718075401.16668-1-xujianghui@cdjrlc.com>
2023-07-18 7:55 ` sunran001 [this message]
2023-07-18 8:40 ` [PATCH] tty: serial: add missing clk_put() Dmitry Baryshkov
2023-07-18 13:25 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=047273ae4e4c25eb7b81fd69d761161e@208suo.com \
--to=sunran001@208suo.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox