From: "대인기/Tizen Platform Lab(SR)/삼성전자" <inki.dae@samsung.com>
To: "'Paul Cercueil'" <paul@crapouillou.net>,
"'Seung-Woo Kim'" <sw0312.kim@samsung.com>,
"'Kyungmin Park'" <kyungmin.park@samsung.com>,
"'Krzysztof Kozlowski'" <krzysztof.kozlowski@linaro.org>,
"'Alim Akhtar'" <alim.akhtar@samsung.com>
Cc: "'David Airlie'" <airlied@gmail.com>,
"'Daniel Vetter'" <daniel@ffwll.ch>,
<dri-devel@lists.freedesktop.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-samsung-soc@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: RE: [PATCH RESEND] drm/exynos: dpi: Change connector type to DPI
Date: Thu, 7 Dec 2023 11:42:07 +0900 [thread overview]
Message-ID: <048a01da28b6$f84c2670$e8e47350$@samsung.com> (raw)
In-Reply-To: <20231206221841.15685-1-paul@crapouillou.net>
Hi Paul,
> -----Original Message-----
> From: Paul Cercueil <paul@crapouillou.net>
> Sent: Thursday, December 7, 2023 7:19 AM
> To: Inki Dae <inki.dae@samsung.com>; Seung-Woo Kim
> <sw0312.kim@samsung.com>; Kyungmin Park <kyungmin.park@samsung.com>;
> Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>; Alim Akhtar
> <alim.akhtar@samsung.com>
> Cc: David Airlie <airlied@gmail.com>; Daniel Vetter <daniel@ffwll.ch>;
> dri-devel@lists.freedesktop.org; linux-arm-kernel@lists.infradead.org;
> linux-samsung-soc@vger.kernel.org; linux-kernel@vger.kernel.org; Paul
> Cercueil <paul@crapouillou.net>
> Subject: [PATCH RESEND] drm/exynos: dpi: Change connector type to DPI
>
> When exynos_drm_dpi.c was written, DRM_MODE_CONNECTOR_DPI did not exist
> yet and I guess that's the reason why DRM_MODE_CONNECTOR_VGA was used as
> the connector type.
>
> However, now it makes more sense to use DRM_MODE_CONNECTOR_DPI as the
> connector type.
Sorry for late. Merged.
Thanks,
Inki Dae
>
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
> ---
> drivers/gpu/drm/exynos/exynos_drm_dpi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_dpi.c
> b/drivers/gpu/drm/exynos/exynos_drm_dpi.c
> index 378e5381978f..0dc36df6ada3 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_dpi.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_dpi.c
> @@ -101,7 +101,7 @@ static int exynos_dpi_create_connector(struct
> drm_encoder *encoder)
>
> ret = drm_connector_init(encoder->dev, connector,
> &exynos_dpi_connector_funcs,
> - DRM_MODE_CONNECTOR_VGA);
> + DRM_MODE_CONNECTOR_DPI);
> if (ret) {
> DRM_DEV_ERROR(ctx->dev,
> "failed to initialize connector with drm\n");
> --
> 2.42.0
>
next prev parent reply other threads:[~2023-12-07 2:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20231206221903epcas1p2e9d90110b0f2901e3e7db86f748026f1@epcas1p2.samsung.com>
2023-12-06 22:18 ` [PATCH RESEND] drm/exynos: dpi: Change connector type to DPI Paul Cercueil
2023-12-07 2:42 ` 대인기/Tizen Platform Lab(SR)/삼성전자 [this message]
2023-12-07 9:16 ` Paul Cercueil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='048a01da28b6$f84c2670$e8e47350$@samsung.com' \
--to=inki.dae@samsung.com \
--cc=airlied@gmail.com \
--cc=alim.akhtar@samsung.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=paul@crapouillou.net \
--cc=sw0312.kim@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox