Re: [PATCH 4/4] net: amd-xgbe: fix comparison to bitshift when dealing with a mask

Tom Lendacky
2018-02-05T22:35:50Z

On 2/5/2018 2:10 PM, Wolfram Sang wrote:
> Due to a typo, the mask was destroyed by a comparison instead of a bit
> shift.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Excellent find.

Acked-by: Tom Lendacky <thomas.lendacky@amd.com>

David, this should also be applied to the 4.14 and 4.15 stable releases.

Thanks,
Tom

> ---
> Only build tested. To be applied individually per subsystem.
>
> drivers/net/ethernet/amd/xgbe/xgbe-drv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-drv.c b/drivers/net/ethernet/amd/xgbe/xgbe-drv.c
> index 7a3ebfd236f5eb..100adee778dfd6 100644
> --- a/drivers/net/ethernet/amd/xgbe/xgbe-drv.c
> +++ b/drivers/net/ethernet/amd/xgbe/xgbe-drv.c
> @@ -595,7 +595,7 @@ static void xgbe_isr_task(unsigned long data)
>
> reissue_mask = 1 << 0;
> if (!pdata->per_channel_irq)
> - reissue_mask |= 0xffff < 4;
> + reissue_mask |= 0xffff << 4;
>
> XP_IOWRITE(pdata, XP_INT_REISSUE_EN, reissue_mask);
> }
>