Re: [PATCH 0/4] tree-wide: fix comparison to bitshift when dealing with a mask

Dan Carpenter
2018-02-06T14:00:04Z

That found 4 that I think Wolfram's grep missed.

arch/um/drivers/vector_user.h | 2 --
drivers/gpu/drm/mxsfb/mxsfb_regs.h | 2 --
drivers/video/fbdev/mxsfb.c | 2 --
include/drm/drm_scdc_helper.h | 3 ---

But it didn't find the two bugs that Geert found where the right side
wasn't a number literal.

drivers/net/can/m_can/m_can.c:#define RXFC_FWM_MASK (0x7f < RXFC_FWM_SHIFT)
drivers/usb/gadget/udc/goku_udc.h:#define INT_EPnNAK(n) (0x00100 < (n)) /* 0 < n < 4 */

regards,
dan carpenter