[PATCH v3 0/2] Add video clock controller DT support for sc8180x

[PATCH v3 0/2] Add video clock controller DT support for sc8180x

[Satya Priya Kakitapalli]

Signed-off-by: Satya Priya Kakitapalli <quic_skakitap@quicinc.com>
---
Changes in v3:
- Fix the yaml binding indentation warnings.
- Link to v2: https://lore.kernel.org/r/20250701-sc8180x-videocc-dt-v2-0-b05db66cc1f6@quicinc.com

Changes in v2:
- Introduce new compatible for sc8180x videocc and use sm8150 as
  fallback. 
- Add new patch to update the bindings accordingly.
- Link to v1: https://lore.kernel.org/r/20250623-sc8180x-videocc-dt-v1-1-9d210c140600@quicinc.com

---
Satya Priya Kakitapalli (2):
      dt-bindings: clock: qcom,videocc: Add sc8180x compatible
      arm64: dts: qcom: sc8180x: Add video clock controller node

 .../devicetree/bindings/clock/qcom,videocc.yaml       | 19 ++++++++++++-------
 arch/arm64/boot/dts/qcom/sc8180x.dtsi                 | 15 +++++++++++++++
 2 files changed, 27 insertions(+), 7 deletions(-)
---
base-commit: 5d4809e25903ab8e74034c1f23c787fd26d52934
change-id: 20250623-sc8180x-videocc-dt-4ec3c0761f8d

Best regards,
-- 
Satya Priya Kakitapalli <quic_skakitap@quicinc.com>

[PATCH v3 1/2] dt-bindings: clock: qcom,videocc: Add sc8180x compatible

[Satya Priya Kakitapalli]

The sc8180x video clock controller block is identical to that
of sm8150. Add a new compatible string for sc8180x videocc and
use sm8150 as fallback.

Signed-off-by: Satya Priya Kakitapalli <quic_skakitap@quicinc.com>
---
 .../devicetree/bindings/clock/qcom,videocc.yaml       | 19 ++++++++++++-------
 1 file changed, 12 insertions(+), 7 deletions(-)

diff --git a/Documentation/devicetree/bindings/clock/qcom,videocc.yaml b/Documentation/devicetree/bindings/clock/qcom,videocc.yaml
index 5f7738d6835c4ba999402e163fc85a07e3a47a5a..b490caaf843243a7a96395fdd2b99972a45679f9 100644
--- a/Documentation/devicetree/bindings/clock/qcom,videocc.yaml
+++ b/Documentation/devicetree/bindings/clock/qcom,videocc.yaml
@@ -23,13 +23,17 @@ description: |
 
 properties:
   compatible:
-    enum:
-      - qcom,sc7180-videocc
-      - qcom,sc7280-videocc
-      - qcom,sdm845-videocc
-      - qcom,sm6350-videocc
-      - qcom,sm8150-videocc
-      - qcom,sm8250-videocc
+    oneOf:
+      - enum:
+          - qcom,sc7180-videocc
+          - qcom,sc7280-videocc
+          - qcom,sdm845-videocc
+          - qcom,sm6350-videocc
+          - qcom,sm8150-videocc
+          - qcom,sm8250-videocc
+      - items:
+          - const: qcom,sc8180x-videocc
+          - const: qcom,sm8150-videocc
 
   clocks:
     minItems: 1
@@ -111,6 +115,7 @@ allOf:
       properties:
         compatible:
           enum:
+            - qcom,sc8180x-videocc
             - qcom,sm8150-videocc
     then:
       properties:

-- 
2.25.1

[PATCH v3 2/2] arm64: dts: qcom: sc8180x: Add video clock controller node

[Satya Priya Kakitapalli]

Add device node for video clock controller on Qualcomm
sc8180x platform.

Signed-off-by: Satya Priya Kakitapalli <quic_skakitap@quicinc.com>
---
 arch/arm64/boot/dts/qcom/sc8180x.dtsi | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sc8180x.dtsi b/arch/arm64/boot/dts/qcom/sc8180x.dtsi
index b74ce3175d209b569e634073662307964158b340..e0dfa1eae8202881a02cc8531111792e7c962fa6 100644
--- a/arch/arm64/boot/dts/qcom/sc8180x.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc8180x.dtsi
@@ -10,6 +10,7 @@
 #include <dt-bindings/clock/qcom,gpucc-sm8150.h>
 #include <dt-bindings/clock/qcom,rpmh.h>
 #include <dt-bindings/clock/qcom,sc8180x-camcc.h>
+#include <dt-bindings/clock/qcom,videocc-sm8150.h>
 #include <dt-bindings/interconnect/qcom,icc.h>
 #include <dt-bindings/interconnect/qcom,osm-l3.h>
 #include <dt-bindings/interconnect/qcom,sc8180x.h>
@@ -2943,6 +2944,20 @@ usb_sec_dwc3_ss: endpoint {
 			};
 		};
 
+		videocc: clock-controller@ab00000 {
+			compatible = "qcom,sc8180x-videocc",
+				     "qcom,sm8150-videocc";
+			reg = <0 0x0ab00000 0 0x10000>;
+			clocks = <&gcc GCC_VIDEO_AHB_CLK>,
+				 <&rpmhcc RPMH_CXO_CLK>;
+			clock-names = "iface", "bi_tcxo";
+			power-domains = <&rpmhpd SC8180X_MMCX>;
+			required-opps = <&rpmhpd_opp_low_svs>;
+			#clock-cells = <1>;
+			#reset-cells = <1>;
+			#power-domain-cells = <1>;
+		};
+
 		camcc: clock-controller@ad00000 {
 			compatible = "qcom,sc8180x-camcc";
 			reg = <0 0x0ad00000 0 0x20000>;

-- 
2.25.1

Re: [PATCH v3 1/2] dt-bindings: clock: qcom,videocc: Add sc8180x compatible

[Krzysztof Kozlowski]

On 02/07/2025 17:13, Satya Priya Kakitapalli wrote:
>  
>    clocks:
>      minItems: 1
> @@ -111,6 +115,7 @@ allOf:
>        properties:
>          compatible:
>            enum:
> +            - qcom,sc8180x-videocc

This is not correct, does not match the compatibles - test yourself. You
want here contains.

Best regards,
Krzysztof

Re: [PATCH v3 1/2] dt-bindings: clock: qcom,videocc: Add sc8180x compatible

[Dmitry Baryshkov]

On Wed, Jul 02, 2025 at 08:43:13PM +0530, Satya Priya Kakitapalli wrote:
> The sc8180x video clock controller block is identical to that
> of sm8150. Add a new compatible string for sc8180x videocc and
> use sm8150 as fallback.
> 
> Signed-off-by: Satya Priya Kakitapalli <quic_skakitap@quicinc.com>
> ---
>  .../devicetree/bindings/clock/qcom,videocc.yaml       | 19 ++++++++++++-------
>  1 file changed, 12 insertions(+), 7 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/clock/qcom,videocc.yaml b/Documentation/devicetree/bindings/clock/qcom,videocc.yaml
> index 5f7738d6835c4ba999402e163fc85a07e3a47a5a..b490caaf843243a7a96395fdd2b99972a45679f9 100644
> --- a/Documentation/devicetree/bindings/clock/qcom,videocc.yaml
> +++ b/Documentation/devicetree/bindings/clock/qcom,videocc.yaml
> @@ -23,13 +23,17 @@ description: |
>  
>  properties:
>    compatible:
> -    enum:
> -      - qcom,sc7180-videocc
> -      - qcom,sc7280-videocc
> -      - qcom,sdm845-videocc
> -      - qcom,sm6350-videocc
> -      - qcom,sm8150-videocc
> -      - qcom,sm8250-videocc
> +    oneOf:
> +      - enum:
> +          - qcom,sc7180-videocc
> +          - qcom,sc7280-videocc
> +          - qcom,sdm845-videocc
> +          - qcom,sm6350-videocc
> +          - qcom,sm8150-videocc
> +          - qcom,sm8250-videocc
> +      - items:
> +          - const: qcom,sc8180x-videocc
> +          - const: qcom,sm8150-videocc
>  
>    clocks:
>      minItems: 1
> @@ -111,6 +115,7 @@ allOf:
>        properties:
>          compatible:
>            enum:
> +            - qcom,sc8180x-videocc

Is there a need for this? Isn't it already covered by the SM8150 entry?

>              - qcom,sm8150-videocc
>      then:
>        properties:
> 
> -- 
> 2.25.1
> 

-- 
With best wishes
Dmitry

Re: [PATCH v3 1/2] dt-bindings: clock: qcom,videocc: Add sc8180x compatible

[Krzysztof Kozlowski]

On Thu, Jul 03, 2025 at 01:29:06AM +0300, Dmitry Baryshkov wrote:
> > -      - qcom,sc7180-videocc
> > -      - qcom,sc7280-videocc
> > -      - qcom,sdm845-videocc
> > -      - qcom,sm6350-videocc
> > -      - qcom,sm8150-videocc
> > -      - qcom,sm8250-videocc
> > +    oneOf:
> > +      - enum:
> > +          - qcom,sc7180-videocc
> > +          - qcom,sc7280-videocc
> > +          - qcom,sdm845-videocc
> > +          - qcom,sm6350-videocc
> > +          - qcom,sm8150-videocc
> > +          - qcom,sm8250-videocc
> > +      - items:
> > +          - const: qcom,sc8180x-videocc
> > +          - const: qcom,sm8150-videocc
> >  
> >    clocks:
> >      minItems: 1
> > @@ -111,6 +115,7 @@ allOf:
> >        properties:
> >          compatible:
> >            enum:
> > +            - qcom,sc8180x-videocc
> 
> Is there a need for this? Isn't it already covered by the SM8150 entry?

Yes and no. Yes - some change here is needed as I explained. No - this
exact change does not work, so it is obviously redundant.

Best regards,
Krzysztof

Re: [PATCH v3 1/2] dt-bindings: clock: qcom,videocc: Add sc8180x compatible

[Satya Priya Kakitapalli]

On 7/3/2025 12:55 PM, Krzysztof Kozlowski wrote:
> On Thu, Jul 03, 2025 at 01:29:06AM +0300, Dmitry Baryshkov wrote:
>>> -      - qcom,sc7180-videocc
>>> -      - qcom,sc7280-videocc
>>> -      - qcom,sdm845-videocc
>>> -      - qcom,sm6350-videocc
>>> -      - qcom,sm8150-videocc
>>> -      - qcom,sm8250-videocc
>>> +    oneOf:
>>> +      - enum:
>>> +          - qcom,sc7180-videocc
>>> +          - qcom,sc7280-videocc
>>> +          - qcom,sdm845-videocc
>>> +          - qcom,sm6350-videocc
>>> +          - qcom,sm8150-videocc
>>> +          - qcom,sm8250-videocc
>>> +      - items:
>>> +          - const: qcom,sc8180x-videocc
>>> +          - const: qcom,sm8150-videocc
>>>   
>>>     clocks:
>>>       minItems: 1
>>> @@ -111,6 +115,7 @@ allOf:
>>>         properties:
>>>           compatible:
>>>             enum:
>>> +            - qcom,sc8180x-videocc
>> Is there a need for this? Isn't it already covered by the SM8150 entry?
> Yes and no. Yes - some change here is needed as I explained. No - this
> exact change does not work, so it is obviously redundant.


Yes, I agree. I'll add 'contains:' throughout the schema and remove this 
compatible since anyway it matches with sm8150 compatible.


Thanks,

Satya Priya

Re: [PATCH v3 1/2] dt-bindings: clock: qcom,videocc: Add sc8180x compatible

[Satya Priya Kakitapalli]

Hi Krzysztof,


On 7/4/2025 4:41 PM, Satya Priya Kakitapalli wrote:
>
> On 7/3/2025 12:55 PM, Krzysztof Kozlowski wrote:
>> On Thu, Jul 03, 2025 at 01:29:06AM +0300, Dmitry Baryshkov wrote:
>>>> -      - qcom,sc7180-videocc
>>>> -      - qcom,sc7280-videocc
>>>> -      - qcom,sdm845-videocc
>>>> -      - qcom,sm6350-videocc
>>>> -      - qcom,sm8150-videocc
>>>> -      - qcom,sm8250-videocc
>>>> +    oneOf:
>>>> +      - enum:
>>>> +          - qcom,sc7180-videocc
>>>> +          - qcom,sc7280-videocc
>>>> +          - qcom,sdm845-videocc
>>>> +          - qcom,sm6350-videocc
>>>> +          - qcom,sm8150-videocc
>>>> +          - qcom,sm8250-videocc
>>>> +      - items:
>>>> +          - const: qcom,sc8180x-videocc
>>>> +          - const: qcom,sm8150-videocc
>>>>       clocks:
>>>>       minItems: 1
>>>> @@ -111,6 +115,7 @@ allOf:
>>>>         properties:
>>>>           compatible:
>>>>             enum:
>>>> +            - qcom,sc8180x-videocc
>>> Is there a need for this? Isn't it already covered by the SM8150 entry?
>> Yes and no. Yes - some change here is needed as I explained. No - this
>> exact change does not work, so it is obviously redundant.
>
>
> Yes, I agree. I'll add 'contains:' throughout the schema and remove 
> this compatible since anyway it matches with sm8150 compatible.
>

I checked this further and see that 'contains' is only needed for 
devices having multiple compatibles or using fallback.
Since we are not using the fallback for any of the other compatibles in 
this schema, I will add contains only for the sm8150 if/then block.


>
> Thanks,
>
> Satya Priya
>
>

Re: [PATCH v3 2/2] arm64: dts: qcom: sc8180x: Add video clock controller node

[Konrad Dybcio]

On 7/2/25 5:13 PM, Satya Priya Kakitapalli wrote:
> Add device node for video clock controller on Qualcomm
> sc8180x platform.
> 
> Signed-off-by: Satya Priya Kakitapalli <quic_skakitap@quicinc.com>
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad