From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 15E7A3A7D7A for ; Tue, 12 May 2026 14:04:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778594671; cv=none; b=lz7b8fsK0e9FYa/2fYE/miJ5Nb1ixLoO9UpdlWqRSZetNOi1quy1xjzo8s/F0igTVLkieIYXGaidBsAUTcuFOb3JaeucA/oUWjQT0hHJv+XUxnyoRPuifdBmRqhWzXGmvgmk+oGIAKBIznam1bxDMu2vw42+TUNmUXq9NEH3/Rc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778594671; c=relaxed/simple; bh=3muT45THtU7AFLqgCb7knyob5ZerZQngSBMzVk1fSck=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=RHTbx6Qw8jzIgcUGROg/f6VN/aXcun6oJ2tuA7z9djruk6RyfCZ7hPnyoOcfH9kffR96DUu3sWlD/lR36eGEnu057inGDYiJrp+oFSXQdaQSf70HeOG4j0M9wSLbGpK194OTCpahtDRteV+nZmT4DohhB16w4KSzBY4o2FuatLE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=QgrhyGFS; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=5e5znqH6; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=N9cCHTDr; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=t5rYxb1v; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="QgrhyGFS"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="5e5znqH6"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="N9cCHTDr"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="t5rYxb1v" Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 362846C1B6; Tue, 12 May 2026 14:04:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1778594664; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3J7CU0OeJ9O9jg81qZWhmHO0hthpveFr+UPeIlsLKTo=; b=QgrhyGFSZ7RlJtSPhOYxGUYsZ2AY9SxpNcJLlfGsCATyRpcsD3amtYFKJyt7E5v8zD9/ky GoPPcgPcIguwZLmlX26uoEIxKA0M856nxncmOJai/IhqHD5Mnr7X59t61mb0/5mRuJLQDc AJB1XToRqQmrEl5Ei2110wIreMr2vYk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1778594664; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3J7CU0OeJ9O9jg81qZWhmHO0hthpveFr+UPeIlsLKTo=; b=5e5znqH6q/Vdo98ETX8Ff9lbwN5DYJUnb7nir9q/iAWQoJsRGkPHAs6tvkLJVzk4azSJlV 2YYhA/2HSav1GlDg== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1778594660; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3J7CU0OeJ9O9jg81qZWhmHO0hthpveFr+UPeIlsLKTo=; b=N9cCHTDrj1L+ZbKQDUjcN8oEgmAddw0zsZx6ydG1V9J5NihMV3kXerzMAliIqSrktq7iDT Df0PlAS51VvZNCHNcVNucBGb9a1pJgAt1ByNb+YyhPag1SnXfAtSdp4ISX38QLOAvDFsaQ JBXw1ayglMHBJQ9Ypk1J8dTwG34P8dA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1778594660; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3J7CU0OeJ9O9jg81qZWhmHO0hthpveFr+UPeIlsLKTo=; b=t5rYxb1vMsiqMm72aYas1YRqssLI0s3Bg8V4TM3LokpH6Xxh7ojMdfeDKgsl/HUsFHS3oW 6Rd8yR/lQheg2bCw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id D3C36593A9; Tue, 12 May 2026 14:04:19 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id v/DrMWMzA2oVeQAAD6G6ig (envelope-from ); Tue, 12 May 2026 14:04:19 +0000 Message-ID: <04a007f9-0a34-4cf5-9feb-9b43ae591b93@suse.de> Date: Tue, 12 May 2026 16:04:15 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] nvme/tcp: release socket on sock_alloc_file() failure To: Wilfred Mallawa , Keith Busch , Jens Axboe , Christoph Hellwig , Sagi Grimberg Cc: linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, Damien Le'Moal , Wilfred Mallawa References: <20260512102831.3593121-2-wilfred.opensource@gmail.com> Content-Language: en-US From: Hannes Reinecke In-Reply-To: <20260512102831.3593121-2-wilfred.opensource@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Level: X-Spamd-Result: default: False [-2.80 / 50.00]; BAYES_HAM(-3.00)[99.99%]; SUSPICIOUS_RECIPS(1.50)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; FREEMAIL_TO(0.00)[gmail.com,kernel.org,kernel.dk,lst.de,grimberg.me]; TAGGED_RCPT(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; RCPT_COUNT_SEVEN(0.00)[9]; MIME_TRACE(0.00)[0:+]; MID_RHS_MATCH_FROM(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; URIBL_BLOCKED(0.00)[suse.de:mid,suse.de:email,wdc.com:email,imap1.dmz-prg2.suse.org:helo]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,suse.de:mid,suse.de:email] X-Spam-Flag: NO X-Spam-Score: -2.80 On 5/12/26 12:28, Wilfred Mallawa wrote: > From: Wilfred Mallawa > > If sock_alloc_file() fails after a sock_create_kern() in > nvme_tcp_alloc_queue(), the socket is not released. > > Add sock_release() to release the socket if sock_alloc_file() fails. > > Fixes: e40d4eb84089eae1 ("nvme-tcp: allocate socket file") > Signed-off-by: Wilfred Mallawa > --- > drivers/nvme/host/tcp.c | 2 ++ > 1 file changed, 2 insertions(+) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich