From: "Sungjong Seo" <sj1557.seo@samsung.com>
To: "'Hyeongseok Kim'" <hyeongseok@gmail.com>, <namjae.jeon@samsung.com>
Cc: <linux-kernel@vger.kernel.org>, <linux-fsdevel@vger.kernel.org>,
"'Chaitanya Kulkarni'" <chaitanya.kulkarni@wdc.com>,
<sj1557.seo@samsung.com>
Subject: RE: [PATCH v4 2/2] exfat: add support ioctl and FITRIM function
Date: Tue, 2 Mar 2021 15:58:20 +0900 [thread overview]
Message-ID: <04aa01d70f31$6de160a0$49a421e0$@samsung.com> (raw)
In-Reply-To: <20210302050521.6059-3-hyeongseok@gmail.com>
> Add FITRIM ioctl to enable discarding unused blocks while mounted.
> As current exFAT doesn't have generic ioctl handler, add empty ioctl
> function first, and add FITRIM handler.
>
> Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
> Signed-off-by: Hyeongseok Kim <hyeongseok@gmail.com>
> ---
> fs/exfat/balloc.c | 80 +++++++++++++++++++++++++++++++++++++++++++++
> fs/exfat/dir.c | 5 +++
> fs/exfat/exfat_fs.h | 4 +++
> fs/exfat/file.c | 53 ++++++++++++++++++++++++++++++
> 4 files changed, 142 insertions(+)
>
It looks better than v3.
Thanks for your work!
Acked-by: Sungjong Seo <sj1557.seo@samsung.com>
BTW, there is still a problem that the alloc/free cluster operation waits
until the trimfs operation is finished.
Any ideas for improvement in the future are welcome. :)
next prev parent reply other threads:[~2021-03-02 8:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20210302050548epcas1p2ccec84f5de16f0971fc0479abe64ec3e@epcas1p2.samsung.com>
2021-03-02 5:05 ` [PATCH v4 0/2] Add FITRIM ioctl support for exFAT filesystem Hyeongseok Kim
2021-03-02 5:05 ` [PATCH v4 1/2] exfat: introduce bitmap_lock for cluster bitmap access Hyeongseok Kim
2021-03-02 6:54 ` Sungjong Seo
2021-03-02 5:05 ` [PATCH v4 2/2] exfat: add support ioctl and FITRIM function Hyeongseok Kim
2021-03-02 6:58 ` Sungjong Seo [this message]
2021-03-04 3:43 ` [PATCH v4 0/2] Add FITRIM ioctl support for exFAT filesystem Namjae Jeon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='04aa01d70f31$6de160a0$49a421e0$@samsung.com' \
--to=sj1557.seo@samsung.com \
--cc=chaitanya.kulkarni@wdc.com \
--cc=hyeongseok@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=namjae.jeon@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox