From: Krzysztof Kozlowski <krzk@kernel.org>
To: liu.qingtao2@zte.com.cn
Cc: gregkh@linuxfoundation.org, jirislaby@kernel.org,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
marex@nabladev.com, pjw@kernel.org, palmer@dabbelt.com,
aou@eecs.berkeley.edu, alex@ghiti.fr, rdunlap@infradead.org,
geert+renesas@glider.be, quic_zongjian@quicinc.com,
arturs.artamonovs@analog.com, robert.marko@sartura.hr,
hvilleneuve@dimonoff.com, thierry.bultel.yh@bp.renesas.com,
julianbraha@gmail.com, flavra@baylibre.com,
prabhakar.mahadev-lad.rj@bp.renesas.com,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linux-riscv@lists.infradead.org,
liu.wenhong35@zte.com.cn, dai.hualiang@zte.com.cn,
deng.weixian@zte.com.cn, jia.yunxiang@zte.com.cn,
bai.lu5@zte.com.cn, yang.susheng@zte.com.cn,
shen.lin1@zte.com.cn, zuo.jiang@zte.com.cn,
hu.shengming@zte.com.cn, gao.rui@zte.com.cn, tan.hu@zte.com.cn
Subject: Re: [PATCH v1 1/2] LRW UART: dt-bindings: Add binding for LRW UART
Date: Wed, 13 May 2026 20:07:42 +0200 [thread overview]
Message-ID: <04b8c5eb-03fa-444c-86c1-07beb20e13f5@kernel.org> (raw)
In-Reply-To: <202605130853.64D8r4bc045011@mse-fl2.zte.com.cn>
On 13/05/2026 10:43, liu.qingtao2@zte.com.cn wrote:
> Thanks for your kindly review. Sorry for the delay.
>
>> On 13/02/2026 10:33, LiuQingtao wrote:
>>> From: Wenhong Liu <liu.wenhong35@zte.com.cn>
>>>
>>> Add documentation for LRW UART devicetree bindings.
>>>
>>> Signed-off-by: Wenhong Liu <liu.wenhong35@zte.com.cn>
>>> Signed-off-by: Qingtao Liu <liu.qingtao2@zte.com.cn>
>>
>> Please use subject prefixes matching the subsystem. You can get them for
>> example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
>> your patch is touching. For bindings, the preferred subjects are
>> explained here:
>> https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters
>>
>>
>> A nit, subject: drop second/last, redundant "bindings". The
>> "dt-bindings" prefix is already stating that these are bindings.
>> See also:
>> https://elixir.bootlin.com/linux/v6.17-rc3/source/Documentation/devicetree/bindings/submitting-patches.rst#L18
>
> Thanks for the notice. I will change the subject to "Add devicetree binding for ZTE LRX UART controller"
> in the v2 patch series.
NAK. Read the comment again. You improved nothing.
>
>
>>> ---
>>> .../bindings/serial/lrw,lrw-uart.yaml | 49 +++++++++++++++++++
>>> .../devicetree/bindings/vendor-prefixes.yaml | 2 +
>>> MAINTAINERS | 7 +++
>>> 3 files changed, 58 insertions(+)
>>> create mode 100644 Documentation/devicetree/bindings/serial/lrw,lrw-uart.yaml
>>>
>>> diff --git a/Documentation/devicetree/bindings/serial/lrw,lrw-uart.yaml b/Documentation/devicetree/bindings/> serial/lrw,lrw-uart.yaml
>>> new file mode 100644
>>> index 000000000000..a2d41c278c4f
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/serial/lrw,lrw-uart.yaml
>>> @@ -0,0 +1,49 @@
>>> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
>>> +
>>> +%YAML 1.2
>>> +---
>>> +$id: http://devicetree.org/schemas/serial/lrw-uart.yaml#
>>
>> Never tested, NAK. There are several other issues here, but I am not
>> going through rest of review if you did not bother to even build test
>> it. Please open any other recent binding and apply same style here
>> (filename, descriptions etc), so you won't be repeating SAME mistakes.
>>
>>
>
> Sorry, i tested on an older version kernel.
> No errors or warnings ever showed up running the command
> "make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/serial/zte,lrx-uart.yaml".
>
Don't work on older kernel. It's not an excuse.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-05-13 18:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-13 8:43 [PATCH v1 1/2] LRW UART: dt-bindings: Add binding for LRW UART liu.qingtao2
2026-05-13 18:07 ` Krzysztof Kozlowski [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-05-13 8:44 liu.qingtao2
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=04b8c5eb-03fa-444c-86c1-07beb20e13f5@kernel.org \
--to=krzk@kernel.org \
--cc=alex@ghiti.fr \
--cc=aou@eecs.berkeley.edu \
--cc=arturs.artamonovs@analog.com \
--cc=bai.lu5@zte.com.cn \
--cc=conor+dt@kernel.org \
--cc=dai.hualiang@zte.com.cn \
--cc=deng.weixian@zte.com.cn \
--cc=devicetree@vger.kernel.org \
--cc=flavra@baylibre.com \
--cc=gao.rui@zte.com.cn \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=hu.shengming@zte.com.cn \
--cc=hvilleneuve@dimonoff.com \
--cc=jia.yunxiang@zte.com.cn \
--cc=jirislaby@kernel.org \
--cc=julianbraha@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-serial@vger.kernel.org \
--cc=liu.qingtao2@zte.com.cn \
--cc=liu.wenhong35@zte.com.cn \
--cc=marex@nabladev.com \
--cc=palmer@dabbelt.com \
--cc=pjw@kernel.org \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=quic_zongjian@quicinc.com \
--cc=rdunlap@infradead.org \
--cc=robert.marko@sartura.hr \
--cc=robh@kernel.org \
--cc=shen.lin1@zte.com.cn \
--cc=tan.hu@zte.com.cn \
--cc=thierry.bultel.yh@bp.renesas.com \
--cc=yang.susheng@zte.com.cn \
--cc=zuo.jiang@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox