From: "Steve Wise" <swise@opengridcomputing.com>
To: "'Joe Perches'" <joe@perches.com>
Cc: "'Doug Ledford'" <dledford@redhat.com>,
"'Sean Hefty'" <sean.hefty@intel.com>,
"'Hal Rosenstock'" <hal.rosenstock@gmail.com>,
<linux-rdma@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 1/4] cxgb3: Use more common logging style
Date: Thu, 9 Feb 2017 16:34:21 -0600 [thread overview]
Message-ID: <04c801d28324$a8459740$f8d0c5c0$@opengridcomputing.com> (raw)
In-Reply-To: <15772862930dfd2f2e10574b86c063d781976a89.1486678686.git.joe@perches.com>
> Subject: [PATCH 1/4] cxgb3: Use more common logging style
>
> Convert printks to pr_<level>
>
> Miscellanea:
>
> o Coalesce formats
> o Realign arguments
>
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
> drivers/infiniband/hw/cxgb3/cxio_hal.c | 27 ++++++------
> drivers/infiniband/hw/cxgb3/cxio_hal.h | 9 +++-
> drivers/infiniband/hw/cxgb3/cxio_resource.c | 5 ++-
> drivers/infiniband/hw/cxgb3/iwch.c | 13 +++---
> drivers/infiniband/hw/cxgb3/iwch_cm.c | 66
++++++++++++-----------------
> drivers/infiniband/hw/cxgb3/iwch_cq.c | 7 ++-
> drivers/infiniband/hw/cxgb3/iwch_ev.c | 11 +++--
> drivers/infiniband/hw/cxgb3/iwch_provider.c | 11 ++---
> drivers/infiniband/hw/cxgb3/iwch_qp.c | 7 ++-
> 9 files changed, 70 insertions(+), 86 deletions(-)
<snip>
> diff --git a/drivers/infiniband/hw/cxgb3/cxio_hal.h
> b/drivers/infiniband/hw/cxgb3/cxio_hal.h
> index 78fbe9ffe7f0..115c0e3a5df5 100644
> --- a/drivers/infiniband/hw/cxgb3/cxio_hal.h
> +++ b/drivers/infiniband/hw/cxgb3/cxio_hal.h
> @@ -196,8 +196,13 @@ int cxio_poll_cq(struct t3_wq *wq, struct t3_cq *cq,
struct
> t3_cqe *cqe,
> u8 *cqe_flushed, u64 *cookie, u32 *credit);
> int iwch_cxgb3_ofld_send(struct t3cdev *tdev, struct sk_buff *skb);
>
> -#define MOD "iw_cxgb3: "
> -#define PDBG(fmt, args...) pr_debug(MOD fmt, ## args)
> +#ifdef pr_fmt
> +#undef pr_fmt
> +#endif
Is the ifdef/undef needed? I see other modules just define pr_fmt() regardless.
Otherwise, looks good (and thanks).
Reviewed-by: Steve Wise <swise@opengridcomputing.com>
next prev parent reply other threads:[~2017-02-09 22:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-09 22:23 [PATCH 0/4] infiniband: chelsio Joe Perches
2017-02-09 22:23 ` [PATCH 1/4] cxgb3: Use more common logging style Joe Perches
2017-02-09 22:34 ` Steve Wise [this message]
2017-02-09 22:39 ` Joe Perches
2017-02-09 22:23 ` [PATCH 2/4] cxgb3: Convert PDBG to pr_debug Joe Perches
2017-02-09 22:35 ` Steve Wise
2017-02-09 22:23 ` [PATCH 3/4] cxgb4: Use more common logging style Joe Perches
2017-02-09 22:36 ` Steve Wise
2017-02-09 22:23 ` [PATCH 4/4] cxgb4: Convert PDBG to pr_debug Joe Perches
2017-02-09 22:37 ` Steve Wise
2017-04-20 20:14 ` [PATCH 0/4] infiniband: chelsio Doug Ledford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='04c801d28324$a8459740$f8d0c5c0$@opengridcomputing.com' \
--to=swise@opengridcomputing.com \
--cc=dledford@redhat.com \
--cc=hal.rosenstock@gmail.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=sean.hefty@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox