From: "Steve Wise" <swise@opengridcomputing.com>
To: "'Joe Perches'" <joe@perches.com>, "'Steve Wise'" <swise@chelsio.com>
Cc: "'Doug Ledford'" <dledford@redhat.com>,
"'Sean Hefty'" <sean.hefty@intel.com>,
"'Hal Rosenstock'" <hal.rosenstock@gmail.com>,
<linux-rdma@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 2/4] cxgb3: Convert PDBG to pr_debug
Date: Thu, 9 Feb 2017 16:35:30 -0600 [thread overview]
Message-ID: <04ca01d28324$d1a99960$74fccc20$@opengridcomputing.com> (raw)
In-Reply-To: <41a74ceecd35cf2f38e2a1a1a394c7718547deb6.1486678686.git.joe@perches.com>
> Subject: [PATCH 2/4] cxgb3: Convert PDBG to pr_debug
>
> Using the normal mechanism, not an indirected one, is clearer.
>
> Miscellanea:
>
> o Coalesce formats
> o Realign arguments
>
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
> drivers/infiniband/hw/cxgb3/cxio_dbg.c | 35 ++---
> drivers/infiniband/hw/cxgb3/cxio_hal.c | 174 ++++++++++++------------
> drivers/infiniband/hw/cxgb3/cxio_hal.h | 2 -
> drivers/infiniband/hw/cxgb3/cxio_resource.c | 20 +--
> drivers/infiniband/hw/cxgb3/iwch.c | 6 +-
> drivers/infiniband/hw/cxgb3/iwch_cm.c | 203
++++++++++++++--------------
> drivers/infiniband/hw/cxgb3/iwch_cm.h | 18 +--
> drivers/infiniband/hw/cxgb3/iwch_cq.c | 14 +-
> drivers/infiniband/hw/cxgb3/iwch_ev.c | 15 +-
> drivers/infiniband/hw/cxgb3/iwch_mem.c | 2 +-
> drivers/infiniband/hw/cxgb3/iwch_provider.c | 101 +++++++-------
> drivers/infiniband/hw/cxgb3/iwch_provider.h | 9 +-
> drivers/infiniband/hw/cxgb3/iwch_qp.c | 60 ++++----
> 13 files changed, 329 insertions(+), 330 deletions(-)
>
Looks good (and thanks).
Reviewed-by: Steve Wise <swise@opengridcomputing.com>
next prev parent reply other threads:[~2017-02-09 22:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-09 22:23 [PATCH 0/4] infiniband: chelsio Joe Perches
2017-02-09 22:23 ` [PATCH 1/4] cxgb3: Use more common logging style Joe Perches
2017-02-09 22:34 ` Steve Wise
2017-02-09 22:39 ` Joe Perches
2017-02-09 22:23 ` [PATCH 2/4] cxgb3: Convert PDBG to pr_debug Joe Perches
2017-02-09 22:35 ` Steve Wise [this message]
2017-02-09 22:23 ` [PATCH 3/4] cxgb4: Use more common logging style Joe Perches
2017-02-09 22:36 ` Steve Wise
2017-02-09 22:23 ` [PATCH 4/4] cxgb4: Convert PDBG to pr_debug Joe Perches
2017-02-09 22:37 ` Steve Wise
2017-04-20 20:14 ` [PATCH 0/4] infiniband: chelsio Doug Ledford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='04ca01d28324$d1a99960$74fccc20$@opengridcomputing.com' \
--to=swise@opengridcomputing.com \
--cc=dledford@redhat.com \
--cc=hal.rosenstock@gmail.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=sean.hefty@intel.com \
--cc=swise@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox