From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754001AbdBIWn2 (ORCPT <rfc822;w@1wt.eu>);
        Thu, 9 Feb 2017 17:43:28 -0500
Received: from smtp.opengridcomputing.com ([72.48.136.20]:47379 "EHLO
        smtp.opengridcomputing.com" rhost-flags-OK-OK-OK-OK)
        by vger.kernel.org with ESMTP id S1752582AbdBIWnX (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 9 Feb 2017 17:43:23 -0500
From: "Steve Wise" <swise@opengridcomputing.com>
To: "'Joe Perches'" <joe@perches.com>, "'Steve Wise'" <swise@chelsio.com>
Cc: "'Doug Ledford'" <dledford@redhat.com>,
        "'Sean Hefty'" <sean.hefty@intel.com>,
        "'Hal Rosenstock'" <hal.rosenstock@gmail.com>,
        <linux-rdma@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <cover.1486678686.git.joe@perches.com> <41a74ceecd35cf2f38e2a1a1a394c7718547deb6.1486678686.git.joe@perches.com>
In-Reply-To: <41a74ceecd35cf2f38e2a1a1a394c7718547deb6.1486678686.git.joe@perches.com>
Subject: RE: [PATCH 2/4] cxgb3: Convert PDBG to pr_debug
Date: Thu, 9 Feb 2017 16:35:30 -0600
Message-ID: <04ca01d28324$d1a99960$74fccc20$@opengridcomputing.com>
MIME-Version: 1.0
Content-Type: text/plain;
        charset="us-ascii"
Content-Transfer-Encoding: 7bit
X-Mailer: Microsoft Outlook 14.0
Thread-Index: AQE3l8a0Ex4Du7XXJL7q5vsjOCa/2wDymjnFoo+FMFA=
Content-Language: en-us
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> Subject: [PATCH 2/4] cxgb3: Convert PDBG to pr_debug
> 
> Using the normal mechanism, not an indirected one, is clearer.
> 
> Miscellanea:
> 
> o Coalesce formats
> o Realign arguments
> 
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
>  drivers/infiniband/hw/cxgb3/cxio_dbg.c      |  35 ++---
>  drivers/infiniband/hw/cxgb3/cxio_hal.c      | 174 ++++++++++++------------
>  drivers/infiniband/hw/cxgb3/cxio_hal.h      |   2 -
>  drivers/infiniband/hw/cxgb3/cxio_resource.c |  20 +--
>  drivers/infiniband/hw/cxgb3/iwch.c          |   6 +-
>  drivers/infiniband/hw/cxgb3/iwch_cm.c       | 203
++++++++++++++--------------
>  drivers/infiniband/hw/cxgb3/iwch_cm.h       |  18 +--
>  drivers/infiniband/hw/cxgb3/iwch_cq.c       |  14 +-
>  drivers/infiniband/hw/cxgb3/iwch_ev.c       |  15 +-
>  drivers/infiniband/hw/cxgb3/iwch_mem.c      |   2 +-
>  drivers/infiniband/hw/cxgb3/iwch_provider.c | 101 +++++++-------
>  drivers/infiniband/hw/cxgb3/iwch_provider.h |   9 +-
>  drivers/infiniband/hw/cxgb3/iwch_qp.c       |  60 ++++----
>  13 files changed, 329 insertions(+), 330 deletions(-)
> 

Looks good (and thanks).

Reviewed-by: Steve Wise <swise@opengridcomputing.com>