Re: [PATCH 2/6] media: qcom: camss: Add CAMSS_SC7180 enum

Bryan O'Donoghue
2024-06-21T11:16:22Z

On 21/06/2024 11:03, Krzysztof Kozlowski wrote:
> On 21/06/2024 11:40, George Chan via B4 Relay wrote:
>> From: George Chan <gchan9527@gmail.com>
>>
>> Adds a CAMSS SoC identifier for the SC7180.
>>
>> Signed-off-by: George Chan <gchan9527@gmail.com>
>> ---
>> drivers/media/platform/qcom/camss/camss.h | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/media/platform/qcom/camss/camss.h b/drivers/media/platform/qcom/camss/camss.h
>> index ac15fe23a702..5e750c481b74 100644
>> --- a/drivers/media/platform/qcom/camss/camss.h
>> +++ b/drivers/media/platform/qcom/camss/camss.h
>> @@ -76,6 +76,7 @@ enum camss_version {
>> CAMSS_8x96,
>> CAMSS_660,
>> CAMSS_845,
>> + CAMSS_7180,
>
> This patch on its own makes no sense. Squash it with patch adding 7180.
>
> Best regards,
> Krzysztof
>

Agreed you can put it into the PHY init sequence in patch #3

---
bod