From: "Florian Schirmer" <jolt@tuxbox.org>
To: "Manu Abraham" <abraham.manu@gmail.com>, "Adrian Bunk" <bunk@stusta.de>
Cc: <v4l-dvb-maintainer@linuxtv.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [v4l-dvb-maintainer] Re: [2.6 patch] drivers/media/dvb/bt8xx/: make2 structs static
Date: Fri, 10 Feb 2006 11:19:15 +0100 [thread overview]
Message-ID: <04cc01c62e2b$724a2110$be02010a@bln.nativeinstruments.de> (raw)
In-Reply-To: 43EC26E1.5020804@gmail.com
Hi,
looks good. Thanks.
Signed-off-by: Florian Schirmer <jolt@tuxbox.org>
Best,
Florian
----- Original Message -----
From: "Manu Abraham" <abraham.manu@gmail.com>
To: "Adrian Bunk" <bunk@stusta.de>
Cc: <v4l-dvb-maintainer@linuxtv.org>; <linux-kernel@vger.kernel.org>
Sent: Friday, February 10, 2006 6:38 AM
Subject: [v4l-dvb-maintainer] Re: [2.6 patch] drivers/media/dvb/bt8xx/:
make2 structs static
> Adrian Bunk wrote:
>> This patch makes two needlessly global structs static.
>>
>>
>> Signed-off-by: Adrian Bunk <bunk@stusta.de>
>>
>> ---
>>
>> drivers/media/dvb/bt8xx/bt878.c | 2 +-
>> drivers/media/dvb/bt8xx/dst.c | 2 +-
>> 2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> --- linux-2.6.16-rc2-mm1-full/drivers/media/dvb/bt8xx/bt878.c.old
>> 2006-02-09 22:09:00.000000000 +0100
>> +++ linux-2.6.16-rc2-mm1-full/drivers/media/dvb/bt8xx/bt878.c 2006-02-09
>> 22:09:07.000000000 +0100
>> @@ -382,7 +382,7 @@
>> EXPORT_SYMBOL(bt878_device_control);
>> -struct cards card_list[] __devinitdata = {
>> +static struct cards card_list[] __devinitdata = {
>> { 0x01010071, BTTV_BOARD_NEBULA_DIGITV, "Nebula Electronics DigiTV" },
>> { 0x07611461, BTTV_BOARD_AVDVBT_761, "AverMedia AverTV DVB-T 761" },
>> --- linux-2.6.16-rc2-mm1-full/drivers/media/dvb/bt8xx/dst.c.old
>> 2006-02-09 22:09:21.000000000 +0100
>> +++ linux-2.6.16-rc2-mm1-full/drivers/media/dvb/bt8xx/dst.c 2006-02-09
>> 22:09:29.000000000 +0100
>> @@ -602,7 +602,7 @@
>> */
>> -struct dst_types dst_tlist[] = {
>> +static struct dst_types dst_tlist[] = {
>> {
>> .device_id = "200103A",
>> .offset = 0,
>>
>> -
>>
>
>
> Ack'd-by: Manu Abraham <manu@linuxtv.org>
>
>
> _______________________________________________
> v4l-dvb-maintainer mailing list
> v4l-dvb-maintainer@linuxtv.org
> http://www.linuxtv.org/cgi-bin/mailman/listinfo/v4l-dvb-maintainer
>
prev parent reply other threads:[~2006-02-10 10:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-10 0:46 [2.6 patch] drivers/media/dvb/bt8xx/: make 2 structs static Adrian Bunk
2006-02-10 5:38 ` Manu Abraham
2006-02-10 10:19 ` Florian Schirmer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='04cc01c62e2b$724a2110$be02010a@bln.nativeinstruments.de' \
--to=jolt@tuxbox.org \
--cc=abraham.manu@gmail.com \
--cc=bunk@stusta.de \
--cc=linux-kernel@vger.kernel.org \
--cc=v4l-dvb-maintainer@linuxtv.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox