Re: [PATCH] usb: xhci: Fix build warning seen with CONFIG_PM=n

Guenter Roeck
2019-12-18T15:59:50Z

On Wed, Dec 18, 2019 at 05:38:06PM +0200, Mathias Nyman wrote:
> On 18.12.2019 16.29, Greg Kroah-Hartman wrote:
> > On Tue, Dec 17, 2019 at 05:19:11PM -0800, Guenter Roeck wrote:
> > > The following build warning is seen if CONFIG_PM is disabled.
> > >
> > > drivers/usb/host/xhci-pci.c:498:13: warning:
> > > unused function 'xhci_pci_shutdown'
> > >
> > > Fixes: f2c710f7dca8 ("usb: xhci: only set D3hot for pci device")
> > > Cc: Henry Lin <henryl@nvidia.com>
> > > Cc: stable@vger.kernel.org # all stable releases with 2f23dc86c3f8

Somehow I messed up the commit sha here. It is f2c710f7dca8, obviously.
2f23dc86c3f8 is the sha from v4.19.y. Sorry for that.

Guenter

> > > Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> > > ---
> > > drivers/usb/host/xhci-pci.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > Nice catch.
> >
> > Mathias, I can queue this up now if you give me an ack.
>
> Yes, please
>
> Acked-by: Mathias Nyman <mathias.nyman@linux.intel.com>
>